Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default folder configuration for Symfony 3 #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix default folder configuration for Symfony 3 #80

wants to merge 1 commit into from

Conversation

rubenrubiob
Copy link
Contributor

Hi!

The deployer fails when trying to deploy a Symfony 3.4 application, as the default configuration sets the folder structure as it is a Symfony 4 application. Symfony's documentation explains the architecture for 3.4 applications: https://symfony.com/doc/3.4/quick_tour/the_architecture.html

That is specially true for applications that have been upgraded from earlier versions.

I have removed the check, but maybe the checks should be more accurate? I can try to do it, if I know how versions differ between them.

Thank you!

Regards!

@YetiCGN
Copy link

YetiCGN commented Oct 10, 2018

See #67 for an even better approach which is configurable from userland.

@rubenrubiob
Copy link
Contributor Author

Yes, I saw that pull request, but that would not work for Symfony 3.4 either, as the checking for versions are wrong, you can see it with the minor version checking.

But that way seems more elegant, indeed, so, if the pull request is merged, I will be happy to do a pull request changing the version checking. It is pretty simple, actually.

Copy link

@fd6130 fd6130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch indeed fix the issue. Going to merge this to my fork instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants