Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use special unit conversion for derived variables #2471

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 2, 2024

Description

Closes ESMValGroup/ESMValTool#3709


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (d472381) to head (3f3bf19).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2471   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files         247      247           
  Lines       14055    14057    +2     
=======================================
+ Hits        13299    13301    +2     
  Misses        756      756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review July 2, 2024 12:31
@bouweandela bouweandela requested a review from schlunma July 2, 2024 12:31
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a tiny comment. Thanks 🚀

esmvalcore/preprocessor/_derive/__init__.py Outdated Show resolved Hide resolved
@schlunma
Copy link
Contributor

schlunma commented Jul 2, 2024

Successfully tests this with recipe_preprocessor_derive_test.yml 👍

@schlunma schlunma merged commit 60aec3e into main Jul 2, 2024
6 checks passed
@schlunma schlunma deleted the use-special-unit-conversion-for-derive branch July 2, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recipe_preprocessor_derive_test.yml is broken for CMIP6 toz
2 participants