Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid large chunks in climate_statistics preprocessor function with period='full' #2404

Merged
merged 1 commit into from
May 6, 2024

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented May 6, 2024

Description

Avoid very large chunks in climate_statistics preprocessor function when used with period=full.

Issue reported in ESMValGroup/ESMValTool#3244 (comment)


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (801ffba) to head (716cf76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2404   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files         246      246           
  Lines       13743    13745    +2     
=======================================
+ Hits        12979    12981    +2     
  Misses        764      764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review May 6, 2024 12:36
@bouweandela bouweandela requested a review from schlunma May 6, 2024 12:36
@bouweandela bouweandela added the preprocessor Related to the preprocessor label May 6, 2024
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bouweandela! Let's include this in v2.11.0.

@schlunma schlunma added this to the v2.11.0 milestone May 6, 2024
@sloosvel sloosvel merged commit c14213d into main May 6, 2024
6 checks passed
@sloosvel sloosvel deleted the fix-climate-statistics-chunks branch May 6, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask related to improvements using Dask preprocessor Related to the preprocessor
Projects
Development

Successfully merging this pull request may close these issues.

3 participants