create_test: add --driver support for e3sm #4673
Conversation
Also, fix a couple issues in driver handling in test_scheduler.
| @@ -681,15 +683,16 @@ def _create_newcase_phase(self, test): | |||
| ) | |||
| ) | |||
| elif case_opt.startswith("V"): | |||
| self._cime_driver = case_opt[1:] | |||
There was a problem hiding this comment.
The original code looks like a bug. The presence of one test with Vdriver would change the driver for all the tests.
There was a problem hiding this comment.
That's been there for a long time, seems like we would have seen problems by now if that were the case. On the other hand, I agree.
There was a problem hiding this comment.
You mean adding one Vdriver a test in a suite would change all tests in that suite?
There was a problem hiding this comment.
@rljacob , yes. self._cime_driver is shared for all tests.
| @@ -924,7 +932,9 @@ def _xml_phase(self, test): | |||
| elif opt.startswith("A"): | |||
| # A option is for testing in ASYNC IO mode, only available with nuopc driver and pio2 | |||
| envtest.set_test_parameter("PIO_ASYNC_INTERFACE", "TRUE") | |||
| envtest.set_test_parameter("CIME_DRIVER", "nuopc") | |||
There was a problem hiding this comment.
This also looked really problematic. Setting the driver to nuopc even if that doesn't match cime_driver?
There was a problem hiding this comment.
PIO async mode is only supported in nuopc - but since cesm only supports the nuopc driver now, this is okay to remove.
|
@jedwards4b , is this error |
| @@ -681,15 +683,16 @@ def _create_newcase_phase(self, test): | |||
| ) | |||
| ) | |||
| elif case_opt.startswith("V"): | |||
| self._cime_driver = case_opt[1:] | |||
There was a problem hiding this comment.
That's been there for a long time, seems like we would have seen problems by now if that were the case. On the other hand, I agree.
| @@ -924,7 +932,9 @@ def _xml_phase(self, test): | |||
| elif opt.startswith("A"): | |||
| # A option is for testing in ASYNC IO mode, only available with nuopc driver and pio2 | |||
| envtest.set_test_parameter("PIO_ASYNC_INTERFACE", "TRUE") | |||
| envtest.set_test_parameter("CIME_DRIVER", "nuopc") | |||
There was a problem hiding this comment.
PIO async mode is only supported in nuopc - but since cesm only supports the nuopc driver now, this is okay to remove.
|
@jedwards4b , would you mind trying a CESM test on this branch? I don't see how this PR is causing an ESMF problem. |
|
According to the docker README: |
|
@jgfouca I don't either and I think that we may need to rethink this docker testing framework - it seems like it's been a problem in nearly every cime PR since it was introduced. Testing on derecho now... |
|
cesm tests are passing locally - |
|
I see the same failure on a PR that changed nothing: #4674 Merging. |
Also, fix a couple issues in driver handling in test_scheduler.
Test suite:
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes [CIME Github issue #]
User interface changes?:
Update gh-pages html (Y/N)?: