Fix/rest n in tests #4667
Merged
Fix/rest n in tests #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
approved these changes
Aug 21, 2024
|
@jedwards4b LGTM, ignore the pre-commit, I'll address it after this has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting REST_N=STOP_N/2 + 1 in config_tests.xml was too simplified and required a lot of comprimises to get tests to run. Here we move the computation of REST_N into the python
so that tests with different NCPL times for different components work correctly.
Test suite:
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #4666
User interface changes?:
Update gh-pages html (Y/N)?: