Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mct for cesm #4647

Merged
merged 31 commits into from
Jul 5, 2024
Merged

Remove mct for cesm #4647

merged 31 commits into from
Jul 5, 2024

Conversation

jedwards4b
Copy link
Contributor

mct library is no longer needed for cesm.

Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

@jedwards4b jedwards4b requested a review from jgfouca June 26, 2024 15:13
@jedwards4b jedwards4b self-assigned this Jun 26, 2024
Copy link
Contributor

@jgfouca jgfouca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me a little nervous due to the path changes, but I can fix up any impacts to CMake.

@rljacob
Copy link
Member

rljacob commented Jun 26, 2024

This makes me a little...wistful. But E3SM will be doing this eventually.

@jedwards4b jedwards4b mentioned this pull request Jun 27, 2024
@brian-eaton
Copy link
Contributor

@rljacob, me too:) Thanks for the good work on MCT which got the job done for many years. It was a rock solid lightweight coupling toolkit!

@jedwards4b
Copy link
Contributor Author

@jasonb5 I would like the entrypoint.sh for cesm to look like this:

    echo "Setting up CESM"                                                                                                                                                                                      
                                                                                                                                                                                                                
    [[ ! -e "${SRC_PATH}/CESM" ]] && git clone -b ${CESM_BRANCH:-master} ${GIT_FLAGS} ${E3SM_REPO:-https://github.com/ESCOMP/CESM} "${SRC_PATH}/CESM"                                                           
                                                                                                                                                                                                                
    pushd "${SRC_PATH}/CESM"                                                                                                                                                                                    
                                                                                                                                                                                                                
    git config --global --add safe.directory "*"                                                                                                                                                                
                                                                                                                                                                                                                
    ./bin/git-fleximod update                                                                                                                                                                                   
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          
    git status                                                                                                                                                                                                  
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
    pushd cime                                                                                                                                                                                                  
  # here we should update cime to the branch we want to test?                                                                                                                                                                                                                                                                                                                                                                           
                                                                                                                                                                                                                                                                                                                       
    # link v3 config_machines                                                                                                                                                                                   
    ln -sf /root/.cime/config_machines.v3.xml /root/.cime/config_machines.xml                      

@jasonb5
Copy link
Collaborator

jasonb5 commented Jul 4, 2024

@jedwards4b I believe the remaining failures are due to cmeps and csm_share submodules needing to be updated.

@jedwards4b
Copy link
Contributor Author

Is it okay to merge then? Thank you so much for your help.

@jasonb5
Copy link
Collaborator

jasonb5 commented Jul 4, 2024

@jedwards4b Yea it should be fine to merge.

@jedwards4b jedwards4b merged commit fcb9c6e into ESMCI:master Jul 5, 2024
6 of 7 checks passed
@jedwards4b jedwards4b deleted the remove_mct_for_cesm branch July 5, 2024 12:31
@jedwards4b
Copy link
Contributor Author

Updated latest cime tag to be cime6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants