Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard Fortran functions for getting command-line arguments #4457

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

billsacks
Copy link
Member

Test suite: Manual testing: compared before and after output from printing args with these diffs:

diff --git a/tools/mapping/gen_domain_files/src/gen_domain.F90 b/tools/mapping/gen_domain_files/src/gen_domain.F90
index f0b97f20e..289fbce6b 100644
--- a/tools/mapping/gen_domain_files/src/gen_domain.F90
+++ b/tools/mapping/gen_domain_files/src/gen_domain.F90
@@ -118,6 +118,15 @@ program fmain
     end select
   end do
 
+  print *, 'fmap = ', trim(fmap)
+  print *, 'fn1_out = ', trim(fn1_out)
+  print *, 'fn2_out = ', trim(fn2_out)
+  print *, 'set_fv_pole_yc = ', set_fv_pole_yc
+  print *, 'fminval = ', fminval
+  print *, 'fmaxval = ', fmaxval
+  print *, 'usercomment = ', trim(usercomment)
+  print *, 'set_omask = ', set_omask
+
   if (fmap == 'null' .or. fn1_out == 'null' .or. fn2_out== 'null') then
     call usage_exit ('Must specify all the following arguments')
   end if

Test baseline: n/a
Test namelist changes: none
Test status: bit for bit

Fixes #4455

User interface changes?: N

Update gh-pages html (Y/N)?: N

Copy link
Collaborator

@jasonb5 jasonb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedwards4b jedwards4b merged commit 5877fde into ESMCI:master Jul 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gen_domain uses non-standard fortran extensions that don't work with all compilers
3 participants