Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing doctests #4448

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Fix failing doctests #4448

merged 2 commits into from
Jul 5, 2023

Conversation

jasonb5
Copy link
Collaborator

@jasonb5 jasonb5 commented Jun 27, 2023

Replaces failing doctests dependent on cori-knl machine with generic
unittests.

Test suite: pytest in container
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a

Fixes n/a
User interface changes?: N
Update gh-pages html (Y/N)?: N

@jasonb5
Copy link
Collaborator Author

jasonb5 commented Jun 27, 2023

cori-knl was removed from E3SM's config_machines with E3SM-Project/E3SM#5742.

@jasonb5 jasonb5 requested a review from jgfouca July 5, 2023 16:11
jgfouca
jgfouca approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@jgfouca jgfouca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jgfouca jgfouca merged commit 4fb404f into master Jul 5, 2023
12 checks passed
@jgfouca jgfouca deleted the fix_doctests branch July 5, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgfouca jgfouca jgfouca approved these changes

Assignees

@jgfouca jgfouca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonb5 @jgfouca