Fix SLIM testlist name, and tweak the stale bot #4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Low Priority from examination fixing ESMCI#4441
jedwards4b
approved these changes
Jun 10, 2023
|
@jasonb5 @jgfouca @rljacob @billsacks could one of you approve this PR and merge to main? Normally I'd ask @jedwards4b or @fischer-ncar but they are both out this week. When I committed this the tests were failing, because of an unrelated problem, but I've updated to the latest and testing is passing now. So there seems to be no reason not to bring it in. @jedwards4b did approve the code review. I do agree with @billsacks in #4441 that we could bump up the time of activation. @jedwards4b thought his suggestion of a year was too long, but maybe 6 months would be a good compromise? If people agree with that I can push a change to a longer activation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SLIM testlist name, and tweak the stale bot
Test suite: none
Test baseline: none
Test namelist changes: none
Test status: bit for bit
Fixes #4444
Fixes #4441
User interface changes?: No
Update gh-pages html (Y/N)?: N
I did run the testlist change in SLIM to verify it's OK. I didn't see a way to test the stale bot changes. Let me know about ideas for further testing.