Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add water variables #69

Merged
merged 4 commits into from
Jun 2, 2024

Conversation

MayeulDestouches
Copy link
Collaborator

This PR extends a few variables related to atmospheric water:

  • It extends the 3D mass contents to include a rain, snow, graupel and hail versions.
  • It extends the water mixing ratios of water vapor, cloud ice, cloud liquid water and rain by adding variants with the _at_top_interfaces vertical stagger. I only updated the mixing ratios wrt dry air and the mixing ratios wrt moist air and condensed water, as I don't need the mixing ratios wrt moist air alone.

It also adds a few water-related variables:

  • Mixing ratios of total water.
  • water_vapor_mixing_ratio_wrt_moist_air_and_condensed_water_assuming_saturation for saturated specific humidity.
  • derivative_of_ln_water_vapor_partial_pressure_assuming_saturation_wrt_air_temperature for the log derivative of saturation vapor pressure wrt temperature.
  • The _at_top_interaces variants of the latter two variables.

@MayeulDestouches
Copy link
Collaborator Author

Tagging @danholdaway for information.

Copy link
Collaborator

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We noticed in our weekly meeting that this PR was not assigned the correct codeowners for review due to an incorrect setting, so I have added them manually.

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions about hail and graupel.

Comment on lines +415 to +420
<standard_name name="mass_content_of_graupel_in_atmosphere_layer">
<type kind="kind_phys" units="kg m-2">real</type>
</standard_name>
<standard_name name="mass_content_of_hail_in_atmosphere_layer">
<type kind="kind_phys" units="kg m-2">real</type>
</standard_name>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do these two interact with do_graupel_instead_of_hail and do_hail_instead_of_graupel? Does the CCPP consider these either / or or are can you use both? Can you use do_graupel_instead_of_hail with mass_content_of_hail_in_atmosphere_layer? How does that work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graupel and hail are different things, so you can definitely use both hail "mass content" and graupel "mass content", although I kwow schemes which assume that all graupel and hail can be considered as graupel, for simplification.

I didn't know about the do_hail_instead_of_graupel and do_graupel_instead_of_hail flags. My guess is that these flags are used in the some part of GFS microphysics scheme do activate similar simplifications.
Maybe @grantfirl (who added these flag names) or @gthompsnJCSDA can give some insight on this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graupel and hail are different things

Well for sure I'd rather get hit on the head with graupel :)

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but did have one change request and a question.

standard_names.xml Outdated Show resolved Hide resolved
long_name="ratio of the mass of rain to the mass of dry air at all interfaces excluding surface">
<type kind="kind_phys" units="kg kg-1">real</type>
</standard_name>
<standard_name name="total_water_mixing_ratio_wrt_moist_air_and_condensed_water"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a new rule to StandardNamesRules.rst stating that the phrase total_water includes all types of water in all phases? I realize that it is somewhat obvious, but I would rather be overly-pedantic then risk potential confusion/argument later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nusbaume I did not pick up on it before, but now I think I am also confused in the same way you are. In this particular case, "total water" would imply that this ratio is:

(mass water vapor) + (mass liquid water) + (mass water ice)
---------------------------------------------------------
(mass water vapor) + (mass liquid water) + (mass dry air)

@MayeulDestouches am I interpreting that correctly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a rule to clarify what total_water is.

@mkavulich, this ratio is

       (mass water vapor) + (mass liquid water) + (mass water ice)
----------------------------------------------------------------------------
(mass water vapor) + (mass liquid water) + (mass water ice) + (mass dry air)

MayeulDestouches and others added 3 commits May 21, 2024 10:33
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @MayeulDestouches! This PR looks ready to me now.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @MayeulDestouches

@MayeulDestouches
Copy link
Collaborator Author

Is anything missing for this PR to be merged?

@nusbaume
Copy link
Collaborator

nusbaume commented Jun 1, 2024

Sorry for the slow response! It looks like we still need an approval from @ss421 before we can merge.

Copy link
Collaborator

@ss421 ss421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou.

@nusbaume nusbaume merged commit 71c92e3 into ESCOMP:main Jun 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants