Minor refactoring of refined injection for AddPlasmaFlux #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
commented
Sep 15, 2024
| const auto index = overlap_box.index(iv); | ||
|
|
||
| Real scale_fac = compute_scale_fac_area(dx, num_ppc_real, flux_normal_axis); | ||
|
|
||
| auto lo = getCellCoords(overlap_corner, dx, {0._rt, 0._rt, 0._rt}, iv); | ||
| auto hi = getCellCoords(overlap_corner, dx, {1._rt, 1._rt, 1._rt}, iv); | ||
|
|
||
| if (flux_pos->overlapsWith(lo, hi)) |
There was a problem hiding this comment.
This if condition is not key here, since the pcounts[index] is 0 anyway for cells that do not overlap.
ax3l
added
cleaning
dpgrote
reviewed
Sep 16, 2024
| auto lo = getCellCoords(overlap_corner, dx, {0._rt, 0._rt, 0._rt}, iv); | ||
| auto hi = getCellCoords(overlap_corner, dx, {1._rt, 1._rt, 1._rt}, iv); | ||
|
|
||
| if (flux_pos->overlapsWith(lo, hi)) | ||
| { | ||
| auto index = overlap_box.index(iv); | ||
| int r; | ||
| int r = 1; | ||
| if (fine_overlap_box.ok() && fine_overlap_box.contains(iv)) { | ||
| r = compute_area_weights(lrrfac, flux_normal_axis); |
There was a problem hiding this comment.
There is another small clean up that can be done. The lrrfac is not necessary since rrfac is already locally declared within the routine. Similarly for AddPlasma.
There was a problem hiding this comment.
Sounds good, thanks. I added this in my latest commit.
atmyers
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
AddPlasmaFlux, the code associated with the refined injection can be simplified a bit in a few places.