Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#333 add flexible www/non-www redirect option #486

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

b3nab
Copy link
Contributor

@b3nab b3nab commented Sep 26, 2024

This PR is for #333 , I simply added into the add-redirect modal a select with 2 presets for www and non-www redirect. After selection the fields will auto-fill with the preset values.

Also added a little refactor that improve keyboard navigation on the two add-domain modals by putting the certificate select after the https switch field.

@b3nab b3nab linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link
Contributor

@Siumauricio Siumauricio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!!

@Siumauricio Siumauricio merged commit 5212bde into canary Sep 27, 2024
3 checks passed
@Siumauricio Siumauricio deleted the 333-add-flexible-wwwnon-www-redirect-option branch September 27, 2024 06:42
@Siumauricio Siumauricio mentioned this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flexible www/non-www redirect option
2 participants