Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
For parts with
content-dispostion: inline
its important to reorganize themultipart
arrangement in the adapter. In particular it needs to be arrange liked this:My changes reorganize the parts as shown above, while maintaining backwards compatibility. It also adds matching functions for querying for inline attachments as for regular attachments. This change was required for inline images and
.ics
files to work properly, particularly in Outlook webmail.I've stopped short of adding tests to the test suite, and I'll wait for you to validate my approach first. I duplicated this code for
kalys/bamboo_ses
, where it currently functions well for my use cases: kalys/bamboo_ses#43Note: This PR also deprecates #133 as the original order of text parts should be maintained