add context and switches to PlayerQuitEvent #2641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
|
|
||
|
|
|
|
||
| public PlayerQuitsScriptEventPaperImpl() { | ||
| registerSwitches("cause"); | ||
| this.<PlayerQuitsScriptEventPaperImpl>registerTextDetermination("none", (evt) -> { |
There was a problem hiding this comment.
This seems like it'd be redundant given the existing registration on none?
mcmonkey4eva
previously approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the PlayerQuitEvent. Additionally to that it adds the following:
Switches
@Location true, requested by Chaps79 on Discord.cause:<cause>to only process the event when it matches the specific cause (only on Paper).`Context
<context.cause>returns an ElementTag of the cause of the quit (only on Paper)The PaperImplementation makes also use of the non-deprecated Methods