-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XY Finance: list XY Finance on the aggregators page #1931
Open
coolryanc
wants to merge
2
commits into
DefiLlama:master
Choose a base branch
from
XY-Finance:feature/xy_finance_bridge-aggregator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
XY Finance: list XY Finance on the aggregators page #1931
coolryanc
wants to merge
2
commits into
DefiLlama:master
from
XY-Finance:feature/xy_finance_bridge-aggregator
+189
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xy-finance adapter exports:
|
could you revert change package.json and |
coolryanc
force-pushed
the
feature/xy_finance_bridge-aggregator
branch
from
September 20, 2024 15:19
8c80a7f
to
241a935
Compare
@dtmkeng sure, reverted. |
The xy-finance adapter exports:
|
i think should move under |
@dtmkeng thanks, updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi DL team @g1nt0ki @dtmkeng, this is XY Finance, we'd like to list us on https://defillama.com/aggregators, here is the PR could you please help review. 🙏
Quick question, other than submitting the PR here, do we also need to submit PR to https://github.com/DefiLlama/defillama-server? Please let us know, thanks. 🙇
Evidence
yarn test aggregators xy-finance