Change RateLimit test to assert value of 1 for sampling priority #3137
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
test_trace_rate_limit_without_trace_sample_rate
tests that rules sampling is not applied when just DD_TRACE_RATE_LIMIT is set without any sampling rules, however, the test was previously looking for a value of2
on the spans'_sampling_priority_v1
tag, which was incorrect because2
represents a form of "user keep."Changes
Change assert statements to expect value of
1
on spans'_sampling_priority_v1
tag.Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present