Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] RASP: Declare not supported feature #3136

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

NachoEchevarria
Copy link
Contributor

Motivation

This feature was declared as bug in dotnet in this PR

It seems that in this test, we are enabling ASM and RASP by remote config. While RASP supports RC changes regarding rules or actions, we still don't support enabling RASP at runtime if ASM was initially disabled. We will add this feature but, in the meantime, this should be marked as missing feature instead of bug.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@NachoEchevarria NachoEchevarria marked this pull request as ready for review September 27, 2024 15:33
@NachoEchevarria NachoEchevarria merged commit 2f2f8c0 into main Sep 27, 2024
27 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/RaspNotSupported branch September 27, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants