Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashtracking tests #3135

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix crashtracking tests #3135

merged 1 commit into from
Sep 30, 2024

Conversation

kevingosse
Copy link
Contributor

Motivation

is_crash_report doesn't behave correctly when it receives telemetry logs that are not a crash report.

Changes

Assertions were added in #3080. Instead, the is_crash_report function should just return false.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@kevingosse kevingosse requested review from dmehala and removed request for a team September 27, 2024 14:33
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assertions were added in #3080

More precisely : Before #3080 , the function raised an exception hard to understand when the data was not on the expected format. The PR didn't add any particular check, but juste made the exception easier to understand 😉

@kevingosse kevingosse merged commit cfeca0c into main Sep 30, 2024
280 of 292 checks passed
@kevingosse kevingosse deleted the kevin/is_crash_report branch September 30, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants