Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test section for OTLP Log ingestion in backend #2914

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

IbraheemA
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@IbraheemA IbraheemA requested review from a team as code owners August 26, 2024 03:43
@IbraheemA IbraheemA requested a review from mx-psi August 26, 2024 03:43
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint fails. Just execute ./format.sh and all should be good.

@cbeauchesne
Copy link
Collaborator

Changing to draft, you can set it back to normal once you need a review from us.

@cbeauchesne cbeauchesne marked this pull request as draft August 26, 2024 07:28
@mx-psi mx-psi requested a review from songy23 August 26, 2024 10:06
tests/otel_tracing_e2e/test_e2e.py Outdated Show resolved Hide resolved
tests/otel_tracing_e2e/test_e2e.py Outdated Show resolved Hide resolved
tests/otel_tracing_e2e/test_e2e.py Outdated Show resolved Hide resolved
tests/otel_tracing_e2e/test_e2e.py Outdated Show resolved Hide resolved
@IbraheemA IbraheemA marked this pull request as ready for review September 25, 2024 20:55
utils/otel_validators/validator_log.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the pprint if not used

@IbraheemA
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 26, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Sep 26, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@IbraheemA
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 27, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 4m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit dd909b0 into main Sep 27, 2024
506 of 520 checks passed
@dd-mergequeue dd-mergequeue bot deleted the ibraheem/add-otlp-backend-log-intake-testing branch September 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants