-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci_visibility): add unique tests request to test vis API client #10845
Merged
romainkomorndatadog
merged 4 commits into
main
from
romain.komorn/SDTEST-906/add_new_tests_to_test_vis_api_client
Sep 27, 2024
Merged
chore(ci_visibility): add unique tests request to test vis API client #10845
romainkomorndatadog
merged 4 commits into
main
from
romain.komorn/SDTEST-906/add_new_tests_to_test_vis_api_client
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romainkomorndatadog
added
the
changelog/no-changelog
A changelog entry is not required for this PR.
label
Sep 27, 2024
|
BenchmarksBenchmark execution time: 2024-09-27 15:17:21 Comparing candidate commit e5fc750 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics. |
vitor-de-araujo
approved these changes
Sep 27, 2024
romainkomorndatadog
deleted the
romain.komorn/SDTEST-906/add_new_tests_to_test_vis_api_client
branch
September 27, 2024 15:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the unique tests request (
self.fetch_unique_tests()
) to the API client to support Early Flake Detection work.A refactor wraps the client's
_do_request()
method is also wrapped in_do_request_with_telemetry()
to DRY the three_do_request()
callers. The telemetry calls are also refactored into aapi_request
telemetry module.This also fixes the test verifying the skippable API request payload which had been shamefully copy/pasted and was actually not testing what it was supposed to.
Checklist
Reviewer Checklist