Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci_visibility): add unique tests request to test vis API client #10845

Conversation

romainkomorndatadog
Copy link
Collaborator

@romainkomorndatadog romainkomorndatadog commented Sep 27, 2024

This adds the unique tests request (self.fetch_unique_tests()) to the API client to support Early Flake Detection work.

A refactor wraps the client's _do_request() method is also wrapped in _do_request_with_telemetry() to DRY the three _do_request() callers. The telemetry calls are also refactored into a api_request telemetry module.

This also fixes the test verifying the skippable API request payload which had been shamefully copy/pasted and was actually not testing what it was supposed to.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@romainkomorndatadog romainkomorndatadog added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 27, 2024
@romainkomorndatadog romainkomorndatadog self-assigned this Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

CODEOWNERS have been resolved as:

ddtrace/internal/ci_visibility/telemetry/api_request.py                 @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/telemetry/early_flake_detection.py       @DataDog/ci-app-libraries
tests/ci_visibility/api_client/test_ci_visibility_api_client_unique_tests_responses.py  @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/_api_client.py                           @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/constants.py                             @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/recorder.py                              @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/telemetry/git.py                         @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/telemetry/itr.py                         @DataDog/ci-app-libraries
tests/ci_visibility/api_client/_util.py                                 @DataDog/ci-app-libraries
tests/ci_visibility/api_client/test_ci_visibility_api_client.py         @DataDog/ci-app-libraries
tests/ci_visibility/api_client/test_ci_visibility_api_client_setting_responses.py  @DataDog/ci-app-libraries
tests/ci_visibility/test_ci_visibility.py                               @DataDog/ci-app-libraries

@romainkomorndatadog romainkomorndatadog marked this pull request as ready for review September 27, 2024 12:58
@romainkomorndatadog romainkomorndatadog requested a review from a team as a code owner September 27, 2024 12:58
@pr-commenter
Copy link

pr-commenter bot commented Sep 27, 2024

Benchmarks

Benchmark execution time: 2024-09-27 15:17:21

Comparing candidate commit e5fc750 in PR branch romain.komorn/SDTEST-906/add_new_tests_to_test_vis_api_client with baseline commit 0e1f4eb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

@romainkomorndatadog romainkomorndatadog merged commit 73fdc23 into main Sep 27, 2024
621 of 622 checks passed
@romainkomorndatadog romainkomorndatadog deleted the romain.komorn/SDTEST-906/add_new_tests_to_test_vis_api_client branch September 27, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants