Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code origin for span #10843

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: code origin for span #10843

wants to merge 18 commits into from

Conversation

P403n1x87
Copy link
Contributor

We add the feature of collecting code origin information for entry and exit span on traces to allow for a quick navigation to the relevant part of the code base.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Sep 27, 2024
@P403n1x87 P403n1x87 self-assigned this Sep 27, 2024
@P403n1x87 P403n1x87 requested review from a team as code owners September 27, 2024 09:45
Copy link
Contributor

github-actions bot commented Sep 27, 2024

CODEOWNERS have been resolved as:

ddtrace/debugging/_origin/__init__.py                                   @DataDog/debugger-python
ddtrace/debugging/_origin/span.py                                       @DataDog/debugger-python
ddtrace/settings/code_origin.py                                         @DataDog/apm-core-python
tests/debugging/origin/test_span.py                                     @DataDog/debugger-python
benchmarks/django_simple/config.yaml                                    @DataDog/apm-core-python
benchmarks/django_simple/gunicorn.conf.py                               @DataDog/apm-core-python
benchmarks/django_simple/scenario.py                                    @DataDog/apm-core-python
benchmarks/django_simple/utils.py                                       @DataDog/apm-core-python
ddtrace/bootstrap/preload.py                                            @DataDog/apm-core-python
ddtrace/contrib/internal/django/patch.py                                @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/fastapi/patch.py                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/flask/patch.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/starlette/patch.py                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/ext/__init__.py                                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/internal/packages.py                                            @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 27, 2024

Datadog Report

Branch report: chore/span-origin
Commit report: 5735706
Test service: dd-trace-py

✅ 0 Failed, 1014 Passed, 272 Skipped, 25m 38.15s Total duration (11m 52.25s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Sep 27, 2024

Benchmarks

Benchmark execution time: 2024-09-30 14:26:18

Comparing candidate commit 5735706 in PR branch chore/span-origin with baseline commit 7e8eb0b in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 369 metrics, 53 unstable metrics.

scenario:iast_aspects-aspect_iast_do_index_on_dict

  • 🟥 max_rss_usage [+2.586MB; +2.925MB] or [+9.732%; +11.007%]

scenario:iast_aspects-aspect_iast_do_operator_add_params

  • 🟥 max_rss_usage [+2.615MB; +2.887MB] or [+9.807%; +10.828%]

@P403n1x87 P403n1x87 enabled auto-merge (squash) September 30, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant