Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracer): [SVLS-5672] DynamoDB PutItem pointers #10824

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

apiarian-datadog
Copy link
Contributor

PutItem is a bit tricky since it doesn't have a separate primary key section. The primary key is mixed into the Item itself. So we need a way for our customers to identify the primary key field names for a table. We'll start by doing this with configuration, and we may add a way for the user to opt in to us making a (cached) DescribeTable call on their behalf.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 26, 2024

CODEOWNERS have been resolved as:

ddtrace/_trace/trace_handlers.py                                        @DataDog/apm-sdk-api-python
ddtrace/_trace/utils_botocore/span_pointers.py                          @DataDog/apm-sdk-api-python
ddtrace/contrib/internal/botocore/patch.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/botocore/test.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
tests/tracer/utils_botocore/test_span_pointers.py                       @DataDog/apm-sdk-api-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 26, 2024

Datadog Report

Branch report: aleksandr.pasechnik/svls-5672-dynamodb-putitem-pointers
Commit report: a59ec2e
Test service: dd-trace-py

✅ 0 Failed, 1014 Passed, 272 Skipped, 26m 8.89s Total duration (11m 35.27s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Sep 26, 2024

Benchmarks

Benchmark execution time: 2024-09-27 20:10:11

Comparing candidate commit a59ec2e in PR branch aleksandr.pasechnik/svls-5672-dynamodb-putitem-pointers with baseline commit b973953 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 0 unstable metrics.

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5672-dynamodb-putitem-pointers branch from 6812a62 to 4c1df41 Compare September 27, 2024 19:08
@apiarian-datadog
Copy link
Contributor Author

confirmed that this works as expected and is configurable with the DD_BOTOCORE_DYNAMODB_TABLE_PRIMARY_KEYS environment variable in a live tests lambda

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5672-dynamodb-putitem-pointers branch from 4c1df41 to a59ec2e Compare September 27, 2024 19:48
@apiarian-datadog
Copy link
Contributor Author

the commits are arranged in a review-friendly order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant