-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracer): [SVLS-5672] DynamoDB PutItem pointers #10824
base: main
Are you sure you want to change the base?
feat(tracer): [SVLS-5672] DynamoDB PutItem pointers #10824
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 1014 Passed, 272 Skipped, 26m 8.89s Total duration (11m 35.27s time saved) |
BenchmarksBenchmark execution time: 2024-09-27 20:10:11 Comparing candidate commit a59ec2e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 0 unstable metrics. |
6812a62
to
4c1df41
Compare
confirmed that this works as expected and is configurable with the |
4c1df41
to
a59ec2e
Compare
the commits are arranged in a review-friendly order. |
PutItem is a bit tricky since it doesn't have a separate primary key section. The primary key is mixed into the Item itself. So we need a way for our customers to identify the primary key field names for a table. We'll start by doing this with configuration, and we may add a way for the user to opt in to us making a (cached) DescribeTable call on their behalf.
Checklist
Reviewer Checklist