yahya/trace_langchain_vector_search_with_score #10808
Draft
+1,687
−1,442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch_with_score # Conflicts: # ddtrace/contrib/internal/langchain/patch.py
|
|
BenchmarksBenchmark execution time: 2024-09-30 14:41:14 Comparing candidate commit 50a8063 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics. |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| @@ -677,13 +702,14 @@ def test_llmobs_embedding_documents( | |||
| ) | |||
| ) | |||
|
|
|||
| # TODO : update test | |||
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| # TODO : update test | |
| # TODO(<owner>) : update test |
comments must have ownership (...read more)
When using TODO or FIXME, specify who write the annotation. It's a best practice to remind you who created the annotation and have potential context and information about this issue.
sabrenner
reviewed
Sep 27, 2024
| document["name"] = metadata.get("name", document["id"]) | ||
| if score is not None: | ||
| document["score"] = score | ||
| documents.append(document) | ||
| span.set_tag_str(OUTPUT_DOCUMENTS, safe_json(self.format_io(documents))) |
There was a problem hiding this comment.
Suggested change
| span.set_tag_str(OUTPUT_DOCUMENTS, safe_json(self.format_io(documents))) | |
| span.set_tag_str(OUTPUT_DOCUMENTS, safe_json(documents)) |
Datadog ReportBranch report: ✅ 0 Failed, 1286 Passed, 0 Skipped, 34m 42.7s Total duration (2m 10.51s time saved) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.