Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): enable endpoint profiling using libdatadog exporter [backport-2.12] #10787

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Sep 24, 2024

Manual backport of #10649 to 2.12

Endpoint profiling allows you to scope flamegraphs by any endpoint in your service as in the screenshot. stack v2 needs more work.

Screenshot 2024-09-19 at 5 18 57 PM

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance
    policy

(cherry picked from commit 6912987)

…10649)

[Endpoint
profiling](https://docs.datadoghq.com/profiler/connect_traces_and_profiles/?code-lang=python#break-down-code-performance-by-api-endpoints)
allows you to scope flamegraphs by any endpoint in your service as in
the screenshot. stack v2 needs more work.

<img width="1510" alt="Screenshot 2024-09-19 at 5 18 57 PM"
src="https://github.com/user-attachments/assets/4e0b5cc3-a0e2-4208-9a86-91508d362248">

- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 6912987)
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 24, 2024

Datadog Report

Branch report: backport-10649-to-2.12
Commit report: d431309
Test service: dd-trace-py

✅ 0 Failed, 40246 Passed, 787 Skipped, 3h 22m 18.51s Total duration (2h 15m 6.39s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2024

Benchmarks

Benchmark execution time: 2024-09-24 17:56:46

Comparing candidate commit d431309 in PR branch backport-10649-to-2.12 with baseline commit 630aaf2 in branch 2.12.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@taegyunkim taegyunkim enabled auto-merge (squash) September 24, 2024 19:00
@taegyunkim taegyunkim added the Profiling Continous Profling label Sep 24, 2024
@taegyunkim taegyunkim merged commit 8c029f3 into 2.12 Sep 25, 2024
356 of 407 checks passed
@taegyunkim taegyunkim deleted the backport-10649-to-2.12 branch September 25, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants