Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): enable endpoint profiling using libdatadog exporter [backport 2.14] #10786

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 24, 2024

Backport 6912987 from #10649 to 2.14.

Endpoint profiling allows you to scope flamegraphs by any endpoint in your service as in the screenshot. stack v2 needs more work.

Screenshot 2024-09-19 at 5 18 57 PM

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

…10649)

[Endpoint
profiling](https://docs.datadoghq.com/profiler/connect_traces_and_profiles/?code-lang=python#break-down-code-performance-by-api-endpoints)
allows you to scope flamegraphs by any endpoint in your service as in
the screenshot. stack v2 needs more work.

<img width="1510" alt="Screenshot 2024-09-19 at 5 18 57 PM"
src="https://github.com/user-attachments/assets/4e0b5cc3-a0e2-4208-9a86-91508d362248">

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 6912987)
@github-actions github-actions bot requested a review from a team as a code owner September 24, 2024 17:20
@github-actions github-actions bot added the Profiling Continous Profling label Sep 24, 2024
@github-actions github-actions bot requested review from a team as code owners September 24, 2024 17:20
@taegyunkim taegyunkim closed this Sep 24, 2024
@taegyunkim taegyunkim reopened this Sep 24, 2024
Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/profiling-libdatadog-endpoint-b4dd576009754cbd.yaml  @DataDog/apm-python
tests/profiling_v2/collector/test_stack.py                              @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/ddup_interface.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/libdatadog_helpers.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/sample.hpp        @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/ddup_interface.cpp    @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/sample.cpp            @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/uploader.cpp          @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/_ddup.pyi                       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/_ddup.pyx                       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/test/interface.py               @DataDog/profiling-python
ddtrace/internal/processor/endpoint_call_counter.py                     @DataDog/apm-core-python
ddtrace/profiling/collector/__init__.py                                 @DataDog/profiling-python
ddtrace/profiling/collector/_lock.py                                    @DataDog/profiling-python
ddtrace/profiling/collector/stack.pyx                                   @DataDog/profiling-python
ddtrace/profiling/exporter/http.py                                      @DataDog/profiling-python
tests/profiling/collector/pprof_utils.py                                @DataDog/profiling-python
tests/profiling_v2/collector/test_asyncio.py                            @DataDog/profiling-python
tests/profiling_v2/collector/test_threading.py                          @DataDog/profiling-python
tests/tracer/test_processors.py                                         @DataDog/apm-sdk-api-python

@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2024

Benchmarks

Benchmark execution time: 2024-09-25 14:05:09

Comparing candidate commit 69d3aaf in PR branch backport-10649-to-2.14 with baseline commit 528ad4c in branch 2.14.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 356 metrics, 48 unstable metrics.

@taegyunkim taegyunkim enabled auto-merge (squash) September 24, 2024 18:59
@taegyunkim taegyunkim merged commit ca4dafd into 2.14 Sep 25, 2024
614 of 615 checks passed
@taegyunkim taegyunkim deleted the backport-10649-to-2.14 branch September 25, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants