Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iast): fix potential memory leak on IAST exception handling [backport-2.13] #10771

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Sep 24, 2024

Description

Partial manual backport of the memleak fix in #10755.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing
    strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note
    guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if
    applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking
    API
    changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance
    implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the
    release branch maintenance
    policy

Co-authored-by: Emmett Butler [email protected]## Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@juanjux juanjux added the ASM Application Security Monitoring label Sep 24, 2024
@juanjux juanjux self-assigned this Sep 24, 2024
@juanjux juanjux requested a review from a team as a code owner September 24, 2024 08:18
Copy link
Contributor

github-actions bot commented Sep 24, 2024

CODEOWNERS have been resolved as:

releasenotes/notes/memleak-on-iast-error-handling-464f52f5fbeb5e24.yaml  @DataDog/apm-python
ddtrace/appsec/_iast/_taint_tracking/Utils/GenericUtils.cpp             @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 24, 2024

Datadog Report

Branch report: juanjux/backport-memleak-to-213
Commit report: d6e0240
Test service: dd-trace-py

✅ 0 Failed, 1946 Passed, 213 Skipped, 1m 52.28s Total duration (1m 20.59s time saved)

Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux requested a review from a team as a code owner September 24, 2024 08:43
@juanjux juanjux changed the title fix(iast): fix potential memory leak on IAST exception handling fix(iast): fix potential memory leak on IAST exception handling [backport-2.13] Sep 24, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2024

Benchmarks

Benchmark execution time: 2024-09-25 07:25:59

Comparing candidate commit d6e0240 in PR branch juanjux/backport-memleak-to-213 with baseline commit 3942e52 in branch 2.13.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@juanjux juanjux closed this Sep 24, 2024
@juanjux juanjux reopened this Sep 24, 2024
@juanjux juanjux enabled auto-merge (squash) September 25, 2024 07:31
@juanjux juanjux merged commit d3957b1 into 2.13 Sep 25, 2024
533 of 534 checks passed
@juanjux juanjux deleted the juanjux/backport-memleak-to-213 branch September 25, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants