Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update algoliasearch latest version to 4.4.4 #10751

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 22, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions github-actions bot requested a review from a team as a code owner September 22, 2024 00:17
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 22, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 22, 2024

Benchmarks

Benchmark execution time: 2024-09-22 00:57:09

Comparing candidate commit 1dbd426 in PR branch upgrade-latest-algoliasearch-version with baseline commit 33daba9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 356 metrics, 48 unstable metrics.

@taegyunkim
Copy link
Contributor

@quinna-h looks like algoliasearch is not actualy updated here

Copy link
Collaborator

@emmettbutler emmettbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quinna-h This change doesn't seem to do what the title says it does

@quinna-h
Copy link
Contributor

quinna-h commented Sep 23, 2024

Closing this PR, as algoliasearch is one of the 'pinned' integrations so should not actually be updated. This should be fixed by #10612

@quinna-h quinna-h closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants