Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(celery): close celery.apply spans even without after_task_publish, when using apply_async #10676

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

fix(celery): close celery.apply spans even without after_task_publish, when using apply_async #10676

wants to merge 27 commits into from
+99 −0

Commits on Sep 16, 2024

  1. fix(celery) close apply_async spans even when the after_task_publish_… 

    …signal does not get called
    @wantsui
    wantsui committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7baa331 View commit details
    Browse the repository at this point in the history

  2. Update format.

    @wantsui
    wantsui committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3d21563 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'main' into close-apply-async-celery-spans

    @wantsui
    wantsui committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b067390 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Add celery.app.task.Task to the Celery Base Test Case

    @wantsui
    wantsui committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    64abe8f View commit details
    Browse the repository at this point in the history

  2. Remove pin from celery.app.task.Task and update patch and tests accor… 

    …dingly.
    @wantsui
    wantsui committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f0c2892 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Comment out new closing span changes and add a test showing that if t… 

    …he after task publish signal is not called, there are no spans at the moment so the test fails.
    @wantsui
    wantsui committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e5d124f View commit details
    Browse the repository at this point in the history

  2. Add new change to close celery.apply spans back, with debug log messages

    @wantsui
    wantsui committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a9a234e View commit details
    Browse the repository at this point in the history

  3. Simplify conditions in utils and test.

    @wantsui
    wantsui committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c0d387d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into close-apply-async-celery-spans 

    update with latest changes on the main branch
    @wantsui
    wantsui committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f4400ee View commit details
    Browse the repository at this point in the history

  5. Remove unused sys import.

    @wantsui
    wantsui committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    18af2fa View commit details
    Browse the repository at this point in the history

  6. Fix typo.

    @wantsui
    wantsui committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5783790 View commit details
    Browse the repository at this point in the history

  7. Apply formatting suggestions.

    @wantsui
    wantsui committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    16e4424 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Fix more formatting.

    @wantsui
    wantsui committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    444b074 View commit details
    Browse the repository at this point in the history

  2. Add release note describing the fix to celery.apply.

    @wantsui
    wantsui committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    40293ec View commit details
    Browse the repository at this point in the history

  3. Add additional assertions for span metadata.

    @wantsui
    wantsui committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7f54148 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into close-apply-async-celery-spans 

    add changes from main branch
    @wantsui
    wantsui committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0606be9 View commit details
    Browse the repository at this point in the history

  5. Fix typo.

    @wantsui
    wantsui committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2c2db93 View commit details
    Browse the repository at this point in the history

  6. Add clarifying comments

    @wantsui
    wantsui committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    deadb75 View commit details
    Browse the repository at this point in the history

  7. Fix typo.

    @wantsui
    wantsui committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7988da8 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Update releasenotes/notes/fix-celery-apply-async-span-close-b7a8db188… 

    …459f5b5.yaml

Co-authored-by: Emmett Butler <[email protected]>
    @wantsui @emmettbutler
    wantsui and emmettbutler committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    17e521a View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Fix bug in retrieve_task_id that fails to check the body for the task… 

    … id when headers has data (but no task id), which wrongly kept spans open.
    @wantsui
    wantsui committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b4556d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Revert "Fix bug in retrieve_task_id that fails to check the body for … 

    …the task id when headers has data (but no task id), which wrongly kept spans open."

This reverts commit b4556d2.
    @wantsui
    wantsui committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9bd7ed7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into close-apply-async-celery-spans 

    add latest main changes
    @wantsui
    wantsui committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5b96ae7 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge branch 'main' into close-apply-async-celery-spans 

    update with latest changes
    @wantsui
    wantsui committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9548914 View commit details
    Browse the repository at this point in the history

  2. Update apply_async to capture errors on the span and report them.

    @wantsui
    wantsui committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c289c4a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into close-apply-async-celery-spans

    @wantsui
    wantsui committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    dba09d0 View commit details
    Browse the repository at this point in the history

  4. Update release note.

    @wantsui
    wantsui committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ab37114 View commit details
    Browse the repository at this point in the history