Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): avoid assigning span's local root to self, so that the python GC doesn't kick in #10624

Closed
wants to merge 11 commits into from
Closed

fix(tracing): avoid assigning span's local root to self, so that the python GC doesn't kick in #10624

wants to merge 11 commits into from
+42 −5

Commits on Sep 9, 2024

  1. Avoid assigning a span's local root to itself so that the python GC d… 

    …oesn't need to kick in.
    @danielshaar
    danielshaar committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    557dca5 View commit details
    Browse the repository at this point in the history

  2. Add a test for the new root span GC behavior.

    @danielshaar
    danielshaar committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    fe586f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Add release note for unnecessary gc fix.

    @danielshaar
    danielshaar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7f36f27 View commit details
    Browse the repository at this point in the history

  2. Run black formatter.

    @danielshaar
    danielshaar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    618f2b8 View commit details
    Browse the repository at this point in the history

  3. Reduce comment line length.

    @danielshaar
    danielshaar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    51b74db View commit details
    Browse the repository at this point in the history

  4. Reformat test file again.

    @danielshaar
    danielshaar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d164265 View commit details
    Browse the repository at this point in the history

  5. Fix type hint to preserve old typing behavior.

    @danielshaar
    danielshaar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    cd66fc2 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'DataDog:main' into main

    @danielshaar
    danielshaar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    50dc60d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Make span gc test clearer.

    @danielshaar
    danielshaar committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4520ab8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'DataDog:main' into main

    @danielshaar
    danielshaar committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ae0737d View commit details
    Browse the repository at this point in the history

  3. Rename object to obj to avoid shadowing python builtin.

    @danielshaar
    danielshaar committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ba5e363 View commit details
    Browse the repository at this point in the history