Skip to content

Commit

Permalink
chore(ci): remove lib-init image tests from this repo in favor of ima…
Browse files Browse the repository at this point in the history
…ges built in system-tests [backport 2.12] (#10834)

Backport
9983895
from #10746 to 2.12.

This PR removes lib injection test images from this repo in favor of the
ones in `system-tests`. The images in this repository were not used
since the migration to `one-pipeline`. The transition from Github
actions to Gitlab for kubernetes lib injection tests mean none of the
injection tests in this repo ran.

With tests in both locations there is lots of potential for confusion.

To capture the changes that have been mistakenly applied to
`dd-trace-py` images, there is a sister PR in system-tests:
DataDog/system-tests#3089

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance

policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
# Conflicts:
#	.gitlab-ci.yml

## Checklist
- [ ] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
randomanderson committed Sep 26, 2024
1 parent 9e2f85d commit db5721c
Show file tree
Hide file tree
Showing 30 changed files with 9 additions and 760 deletions.
9 changes: 8 additions & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,14 @@ onboarding_tests_installer:
onboarding_tests_k8s_injection:
parallel:
matrix:
- WEBLOG_VARIANT: [dd-lib-python-init-test-django, dd-lib-python-init-test-django-gunicorn, dd-lib-python-init-test-django-uvicorn]
- WEBLOG_VARIANT:
- dd-lib-python-init-test-django
- dd-lib-python-init-test-django-gunicorn
- dd-lib-python-init-test-django-gunicorn-alpine
- dd-lib-python-init-test-django-preinstalled
- dd-lib-python-init-test-django-unsupported-package-force
- dd-lib-python-init-test-django-uvicorn
- dd-lib-python-init-test-protobuf-old

deploy_to_di_backend:manual:
stage: shared-pipeline
Expand Down
12 changes: 1 addition & 11 deletions tests/.suitespec.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,7 @@
"tests/subprocesstest.py",
"tests/wait-for-services.py",
"tests/webclient.py",
"tests/test_module/*",
"tests/lib-injection/dd-lib-python-init-test-django/*",
"tests/lib-injection/dd-lib-python-init-test-django-gunicorn/*",
"tests/lib-injection/dd-lib-python-init-test-django-gunicorn-alpine/*",
"tests/lib-injection/dd-lib-python-init-test-django-no-perms/*",
"tests/lib-injection/dd-lib-python-init-test-django-pre-installed/*",
"tests/lib-injection/dd-lib-python-init-test-django-unsupported-python/*",
"tests/lib-injection/dd-lib-python-init-test-django-unsupported-package/*",
"tests/lib-injection/dd-lib-python-init-test-django-unsupported-package-force/*",
"tests/lib-injection/dd-lib-python-init-test-django-uvicorn/*",
"tests/lib-injection/dd-lib-python-init-test-protobuf-old/*"
"tests/test_module/*"
],
"core": [
"ddtrace/internal/__init__.py",
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit db5721c

Please sign in to comment.