Skip to content

Commit

Permalink
Revert "chore(llmobs): add language tag to span events [backport 2.13…
Browse files Browse the repository at this point in the history
…]" (#10793)

Reverts #10704
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
sabrenner committed Sep 30, 2024
1 parent 0dc0ad9 commit a9d3d4d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion ddtrace/llmobs/_trace_processor.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ def _llmobs_tags(span: Span, ml_app: str, session_id: Optional[str] = None) -> L
"source": "integration",
"ml_app": ml_app,
"ddtrace.version": ddtrace.__version__,
"language": "python",
"error": span.error,
}
err_type = span.get_tag(ERROR_TYPE)
Expand Down
1 change: 0 additions & 1 deletion tests/llmobs/_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def _expected_llmobs_tags(span, error=None, tags=None, session_id=None):
"source:integration",
"ml_app:{}".format(tags.get("ml_app", "unnamed-ml-app")),
"ddtrace.version:{}".format(ddtrace.__version__),
"language:python",
]
if error:
expected_tags.append("error:1")
Expand Down

0 comments on commit a9d3d4d

Please sign in to comment.