Add support for `TRACE_HTTP_CLIENT_ERROR_STATUSES` #7694

mhlidd · 2024-09-30T14:55:01Z

What Does This Do

Add support to handle TRACE_HTTP_CLIENT_ERROR_STATUSES tag as well as the original HTTP_CLIENT_ERROR_STATUSES tag in efforts to be more consistent with the tags from other languages.

Motivation

Our goal is to make the implementation of configuration variables consistent for all languages as part of the config consistency effort listed in the following RFC.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-477

rebasing

pr-commenter · 2024-09-30T15:24:22Z

Benchmarks

Startup

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-09-30T19:01:45	2024-09-30T19:08:36
git_branch	master	mhlidd/client_error_statuses
git_commit_date	1727721344	1727722051
git_commit_sha	`1d51f78`	`a5a6a34`
release_version	1.41.0-SNAPSHOT~1d51f7863f	1.41.0-SNAPSHOT~a5a6a34968
start_time	2024-09-30T19:01:32	2024-09-30T19:08:23

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1727723662	1727723662
ci_job_id	656177611	656177611
ci_pipeline_id	45457094	45457094
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~a5a6a34968, baseline=1.41.0-SNAPSHOT~1d51f7863f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1323, 1362
.   : milestone, 1342,
appsec (1.719 ms) : 1695, 1743
.   : milestone, 1719,
appsec_no_iast (1.727 ms) : 1703, 1751
.   : milestone, 1727,
iast (1.468 ms) : 1445, 1491
.   : milestone, 1468,
profiling (1.489 ms) : 1463, 1514
.   : milestone, 1489,
tracing (1.459 ms) : 1435, 1484
.   : milestone, 1459,
section candidate
no_agent (1.335 ms) : 1316, 1354
.   : milestone, 1335,
appsec (1.703 ms) : 1678, 1727
.   : milestone, 1703,
appsec_no_iast (1.729 ms) : 1705, 1752
.   : milestone, 1729,
iast (1.482 ms) : 1460, 1505
.   : milestone, 1482,
profiling (1.488 ms) : 1463, 1513
.   : milestone, 1488,
tracing (1.483 ms) : 1459, 1507
.   : milestone, 1483,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.342 ms [1.323 ms, 1.362 ms]	-
appsec	1.719 ms [1.695 ms, 1.743 ms]	376.434 µs (28.0%)
appsec_no_iast	1.727 ms [1.703 ms, 1.751 ms]	384.519 µs (28.6%)
iast	1.468 ms [1.445 ms, 1.491 ms]	125.809 µs (9.4%)
profiling	1.489 ms [1.463 ms, 1.514 ms]	146.348 µs (10.9%)
tracing	1.459 ms [1.435 ms, 1.484 ms]	116.956 µs (8.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.335 ms [1.316 ms, 1.354 ms]	-
appsec	1.703 ms [1.678 ms, 1.727 ms]	367.974 µs (27.6%)
appsec_no_iast	1.729 ms [1.705 ms, 1.752 ms]	393.887 µs (29.5%)
iast	1.482 ms [1.46 ms, 1.505 ms]	147.751 µs (11.1%)
profiling	1.488 ms [1.463 ms, 1.513 ms]	153.216 µs (11.5%)
tracing	1.483 ms [1.459 ms, 1.507 ms]	148.158 µs (11.1%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~a5a6a34968, baseline=1.41.0-SNAPSHOT~1d51f7863f
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.335 µs) : 353, 392
.   : milestone, 372,
iast (486.345 µs) : 465, 508
.   : milestone, 486,
iast_FULL (554.947 µs) : 534, 576
.   : milestone, 555,
iast_GLOBAL (511.917 µs) : 490, 534
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (485.585 µs) : 464, 507
.   : milestone, 486,
iast_INACTIVE (445.423 µs) : 425, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (476.63 µs) : 455, 498
.   : milestone, 477,
tracing (454.467 µs) : 433, 476
.   : milestone, 454,
section candidate
no_agent (368.892 µs) : 349, 389
.   : milestone, 369,
iast (487.728 µs) : 467, 509
.   : milestone, 488,
iast_FULL (558.583 µs) : 538, 580
.   : milestone, 559,
iast_GLOBAL (509.193 µs) : 488, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (482.781 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (445.273 µs) : 425, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (475.676 µs) : 454, 497
.   : milestone, 476,
tracing (444.1 µs) : 423, 465
.   : milestone, 444,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.335 µs [353.085 µs, 391.585 µs]	-
iast	486.345 µs [464.505 µs, 508.185 µs]	114.01 µs (30.6%)
iast_FULL	554.947 µs [533.82 µs, 576.074 µs]	182.612 µs (49.0%)
iast_GLOBAL	511.917 µs [489.795 µs, 534.04 µs]	139.583 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED	485.585 µs [464.242 µs, 506.928 µs]	113.25 µs (30.4%)
iast_INACTIVE	445.423 µs [424.555 µs, 466.291 µs]	73.088 µs (19.6%)
iast_TELEMETRY_OFF	476.63 µs [455.483 µs, 497.777 µs]	104.296 µs (28.0%)
tracing	454.467 µs [432.728 µs, 476.206 µs]	82.132 µs (22.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	368.892 µs [348.903 µs, 388.881 µs]	-
iast	487.728 µs [466.515 µs, 508.94 µs]	118.836 µs (32.2%)
iast_FULL	558.583 µs [537.538 µs, 579.628 µs]	189.691 µs (51.4%)
iast_GLOBAL	509.193 µs [487.61 µs, 530.776 µs]	140.301 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED	482.781 µs [461.519 µs, 504.043 µs]	113.889 µs (30.9%)
iast_INACTIVE	445.273 µs [424.647 µs, 465.898 µs]	76.381 µs (20.7%)
iast_TELEMETRY_OFF	475.676 µs [454.46 µs, 496.891 µs]	106.784 µs (28.9%)
tracing	444.1 µs [422.987 µs, 465.214 µs]	75.208 µs (20.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/client_error_statuses
git_commit_date	1727721344	1727722051
git_commit_sha	`1d51f78`	`a5a6a34`
release_version	1.41.0-SNAPSHOT~1d51f7863f	1.41.0-SNAPSHOT~a5a6a34968

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1727724221	1727724221
ci_job_id	656177612	656177612
ci_pipeline_id	45457094	45457094
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~a5a6a34968, baseline=1.41.0-SNAPSHOT~1d51f7863f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.3 ms) : 2260, 2340
.   : milestone, 2300,
iast (2.062 ms) : 2010, 2113
.   : milestone, 2062,
iast_GLOBAL (2.104 ms) : 2052, 2156
.   : milestone, 2104,
profiling (1.928 ms) : 1886, 1970
.   : milestone, 1928,
tracing (1.901 ms) : 1862, 1940
.   : milestone, 1901,
section candidate
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.301 ms) : 2261, 2341
.   : milestone, 2301,
iast (2.056 ms) : 2006, 2107
.   : milestone, 2056,
iast_GLOBAL (2.108 ms) : 2056, 2159
.   : milestone, 2108,
profiling (1.929 ms) : 1887, 1971
.   : milestone, 1929,
tracing (1.893 ms) : 1855, 1932
.   : milestone, 1893,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.457 ms [1.446 ms, 1.469 ms]	-
appsec	2.3 ms [2.26 ms, 2.34 ms]	842.404 µs (57.8%)
iast	2.062 ms [2.01 ms, 2.113 ms]	604.381 µs (41.5%)
iast_GLOBAL	2.104 ms [2.052 ms, 2.156 ms]	646.455 µs (44.4%)
profiling	1.928 ms [1.886 ms, 1.97 ms]	470.608 µs (32.3%)
tracing	1.901 ms [1.862 ms, 1.94 ms]	443.946 µs (30.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.458 ms [1.446 ms, 1.469 ms]	-
appsec	2.301 ms [2.261 ms, 2.341 ms]	843.265 µs (57.8%)
iast	2.056 ms [2.006 ms, 2.107 ms]	598.708 µs (41.1%)
iast_GLOBAL	2.108 ms [2.056 ms, 2.159 ms]	650.018 µs (44.6%)
profiling	1.929 ms [1.887 ms, 1.971 ms]	471.433 µs (32.3%)
tracing	1.893 ms [1.855 ms, 1.932 ms]	435.301 µs (29.9%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~a5a6a34968, baseline=1.41.0-SNAPSHOT~1d51f7863f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.143 s) : 15143000, 15143000
.   : milestone, 15143000,
appsec (15.12 s) : 15120000, 15120000
.   : milestone, 15120000,
iast (18.675 s) : 18675000, 18675000
.   : milestone, 18675000,
iast_GLOBAL (18.056 s) : 18056000, 18056000
.   : milestone, 18056000,
profiling (14.92 s) : 14920000, 14920000
.   : milestone, 14920000,
tracing (15.29 s) : 15290000, 15290000
.   : milestone, 15290000,
section candidate
no_agent (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,
appsec (15.18 s) : 15180000, 15180000
.   : milestone, 15180000,
iast (18.772 s) : 18772000, 18772000
.   : milestone, 18772000,
iast_GLOBAL (18.133 s) : 18133000, 18133000
.   : milestone, 18133000,
profiling (15.164 s) : 15164000, 15164000
.   : milestone, 15164000,
tracing (15.368 s) : 15368000, 15368000
.   : milestone, 15368000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.143 s [15.143 s, 15.143 s]	-
appsec	15.12 s [15.12 s, 15.12 s]	-23.0 ms (-0.2%)
iast	18.675 s [18.675 s, 18.675 s]	3.532 s (23.3%)
iast_GLOBAL	18.056 s [18.056 s, 18.056 s]	2.913 s (19.2%)
profiling	14.92 s [14.92 s, 14.92 s]	-223.0 ms (-1.5%)
tracing	15.29 s [15.29 s, 15.29 s]	147.0 ms (1.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.094 s [15.094 s, 15.094 s]	-
appsec	15.18 s [15.18 s, 15.18 s]	86.0 ms (0.6%)
iast	18.772 s [18.772 s, 18.772 s]	3.678 s (24.4%)
iast_GLOBAL	18.133 s [18.133 s, 18.133 s]	3.039 s (20.1%)
profiling	15.164 s [15.164 s, 15.164 s]	70.0 ms (0.5%)
tracing	15.368 s [15.368 s, 15.368 s]	274.0 ms (1.8%)

mhlidd added type: enhancement comp: core Tracer core labels Sep 30, 2024

mhlidd added 2 commits September 30, 2024 11:02

adding implementation for TRACE_HTTP_CLIENT_ERROR_STATUSES

80b17e4

adding string for TRACE_HTTP_CLIENT_ERROR_STATUSES

c6b378c

rebasing

mhlidd force-pushed the mhlidd/client_error_statuses branch from d570568 to c6b378c Compare September 30, 2024 15:11

spotless cleanup

3a6c9d5

fixing unit test

a5a6a34

mhlidd marked this pull request as ready for review September 30, 2024 19:39

mhlidd requested a review from a team as a code owner September 30, 2024 19:39

mhlidd requested review from ygree and mtoffl01 September 30, 2024 19:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for `TRACE_HTTP_CLIENT_ERROR_STATUSES` #7694

Add support for `TRACE_HTTP_CLIENT_ERROR_STATUSES` #7694

mhlidd commented Sep 30, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Sep 30, 2024 •

edited

Loading

Add support for TRACE_HTTP_CLIENT_ERROR_STATUSES #7694

Are you sure you want to change the base?

Add support for TRACE_HTTP_CLIENT_ERROR_STATUSES #7694

Conversation

mhlidd commented Sep 30, 2024 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Sep 30, 2024 • edited Loading

Benchmarks

Startup

Load

Parameters

Summary

Dacapo

Parameters

Summary

Add support for `TRACE_HTTP_CLIENT_ERROR_STATUSES` #7694

Add support for `TRACE_HTTP_CLIENT_ERROR_STATUSES` #7694

mhlidd commented Sep 30, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Sep 30, 2024 •

edited

Loading