Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new telemetry crash data format #7675

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Add support for new telemetry crash data format #7675

merged 1 commit into from
Sep 26, 2024

Conversation

jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Sep 24, 2024 •
edited
Loading

What Does This Do

This adds support for the new telemetry crash upload format.

Motivation

Without the new telemetry format the data is not properly linked with the crash-tracking product.

Additional Notes

Currently we support only Hotspot crash file format.

Contributor Checklist

Jira ticket: PROF-10562

@jbachorik jbachorik added tag: no release notes Changes to exclude from release notes comp: crash tracking Crash tracking labels Sep 24, 2024
@jbachorik jbachorik requested review from a team as code owners September 24, 2024 13:00
@jbachorik jbachorik marked this pull request as draft September 24, 2024 13:00
@jbachorik jbachorik force-pushed the jb/crash_tracking_dto branch 2 times, most recently from 8dd0cb5 to 9a279e7 Compare September 24, 2024 13:11
@pr-commenter
Copy link

pr-commenter bot commented Sep 24, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/crash_tracking_dto
git_commit_date 1727189655 1727272947
git_commit_sha 043adb2 4933b3c
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~4933b3c399
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727275300 1727275300
ci_job_id 651281670 651281670
ci_pipeline_id 45118285 45118285
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 49 metrics, 12 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Telemetry worse
[+211.831µs; +363.332µs] or [+3.087%; +5.295%]		 7.149ms 6.862ms
scenario:startup:petclinic:iast:Telemetry worse
[+326.873µs; +653.829µs] or [+4.694%; +9.390%]		 7.453ms 6.963ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~4933b3c399, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068825
Total [baseline] (8.518 s) : 0, 8517735
Agent [candidate] (1.065 s) : 0, 1064673
Total [candidate] (8.561 s) : 0, 8560573
section iast
Agent [baseline] (1.198 s) : 0, 1197611
Total [baseline] (9.069 s) : 0, 9068888
Agent [candidate] (1.196 s) : 0, 1195712
Total [candidate] (9.007 s) : 0, 9007013
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1192373
Total [baseline] (8.953 s) : 0, 8952645
Agent [candidate] (1.189 s) : 0, 1189480
Total [candidate] (8.973 s) : 0, 8973447
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1184464
Total [baseline] (8.986 s) : 0, 8986050
Agent [candidate] (1.185 s) : 0, 1185321
Total [candidate] (9.011 s) : 0, 9010653
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.198 s 128.785 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 123.547 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.184 s 115.638 ms (10.8%)
Total tracing 8.518 s -
Total iast 9.069 s 551.153 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.953 s 434.91 ms (5.1%)
Total iast_TELEMETRY_OFF 8.986 s 468.314 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.196 s 131.039 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.189 s 124.807 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.185 s 120.647 ms (11.3%)
Total tracing 8.561 s -
Total iast 9.007 s 446.441 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.973 s 412.874 ms (4.8%)
Total iast_TELEMETRY_OFF 9.011 s 450.08 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~4933b3c399, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.514 ms) : 0, 682514
BytebuddyAgent [candidate] (679.215 ms) : 0, 679215
GlobalTracer [baseline] (310.651 ms) : 0, 310651
GlobalTracer [candidate] (310.117 ms) : 0, 310117
AppSec [baseline] (53.788 ms) : 0, 53788
AppSec [candidate] (53.559 ms) : 0, 53559
Remote Config [baseline] (665.029 µs) : 0, 665
Remote Config [candidate] (659.456 µs) : 0, 659
Telemetry [baseline] (7.586 ms) : 0, 7586
Telemetry [candidate] (7.512 ms) : 0, 7512
section iast
BytebuddyAgent [baseline] (797.604 ms) : 0, 797604
BytebuddyAgent [candidate] (796.444 ms) : 0, 796444
GlobalTracer [baseline] (299.762 ms) : 0, 299762
GlobalTracer [candidate] (299.74 ms) : 0, 299740
AppSec [baseline] (55.714 ms) : 0, 55714
AppSec [candidate] (55.326 ms) : 0, 55326
Remote Config [baseline] (629.292 µs) : 0, 629
Remote Config [candidate] (612.554 µs) : 0, 613
Telemetry [baseline] (7.116 ms) : 0, 7116
Telemetry [candidate] (7.286 ms) : 0, 7286
IAST [baseline] (23.097 ms) : 0, 23097
IAST [candidate] (22.614 ms) : 0, 22614
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.96 ms) : 0, 794960
BytebuddyAgent [candidate] (791.164 ms) : 0, 791164
GlobalTracer [baseline] (298.347 ms) : 0, 298347
GlobalTracer [candidate] (298.751 ms) : 0, 298751
AppSec [baseline] (54.421 ms) : 0, 54421
AppSec [candidate] (56.055 ms) : 0, 56055
Remote Config [baseline] (603.988 µs) : 0, 604
Remote Config [candidate] (602.49 µs) : 0, 602
Telemetry [baseline] (7.817 ms) : 0, 7817
Telemetry [candidate] (7.402 ms) : 0, 7402
IAST [baseline] (22.554 ms) : 0, 22554
IAST [candidate] (21.899 ms) : 0, 21899
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (787.001 ms) : 0, 787001
BytebuddyAgent [candidate] (787.735 ms) : 0, 787735
GlobalTracer [baseline] (298.497 ms) : 0, 298497
GlobalTracer [candidate] (298.674 ms) : 0, 298674
AppSec [baseline] (57.41 ms) : 0, 57410
AppSec [candidate] (55.408 ms) : 0, 55408
Remote Config [baseline] (601.161 µs) : 0, 601
Remote Config [candidate] (594.92 µs) : 0, 595
Telemetry [baseline] (6.862 ms) : 0, 6862
Telemetry [candidate] (7.149 ms) : 0, 7149
IAST [baseline] (20.489 ms) : 0, 20489
IAST [candidate] (22.123 ms) : 0, 22123
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~4933b3c399, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063073
Total [baseline] (10.325 s) : 0, 10325467
Agent [candidate] (1.062 s) : 0, 1061733
Total [candidate] (10.409 s) : 0, 10408989
section appsec
Agent [baseline] (1.202 s) : 0, 1201909
Total [baseline] (10.582 s) : 0, 10581557
Agent [candidate] (1.197 s) : 0, 1196891
Total [candidate] (10.679 s) : 0, 10679148
section iast
Agent [baseline] (1.189 s) : 0, 1189176
Total [baseline] (10.845 s) : 0, 10845282
Agent [candidate] (1.199 s) : 0, 1198807
Total [candidate] (10.855 s) : 0, 10855030
section profiling
Agent [baseline] (1.273 s) : 0, 1273467
Total [baseline] (10.607 s) : 0, 10607361
Agent [candidate] (1.271 s) : 0, 1271331
Total [candidate] (10.591 s) : 0, 10590999
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.202 s 138.836 ms (13.1%)
Agent iast 1.189 s 126.103 ms (11.9%)
Agent profiling 1.273 s 210.394 ms (19.8%)
Total tracing 10.325 s -
Total appsec 10.582 s 256.09 ms (2.5%)
Total iast 10.845 s 519.815 ms (5.0%)
Total profiling 10.607 s 281.894 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.197 s 135.158 ms (12.7%)
Agent iast 1.199 s 137.074 ms (12.9%)
Agent profiling 1.271 s 209.598 ms (19.7%)
Total tracing 10.409 s -
Total appsec 10.679 s 270.159 ms (2.6%)
Total iast 10.855 s 446.041 ms (4.3%)
Total profiling 10.591 s 182.01 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~4933b3c399, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.748 ms) : 0, 678748
BytebuddyAgent [candidate] (677.24 ms) : 0, 677240
GlobalTracer [baseline] (309.191 ms) : 0, 309191
GlobalTracer [candidate] (309.319 ms) : 0, 309319
AppSec [baseline] (53.362 ms) : 0, 53362
AppSec [candidate] (53.446 ms) : 0, 53446
Remote Config [baseline] (657.643 µs) : 0, 658
Remote Config [candidate] (658.024 µs) : 0, 658
Telemetry [baseline] (7.542 ms) : 0, 7542
Telemetry [candidate] (7.512 ms) : 0, 7512
section appsec
BytebuddyAgent [baseline] (702.155 ms) : 0, 702155
BytebuddyAgent [candidate] (700.304 ms) : 0, 700304
GlobalTracer [baseline] (303.641 ms) : 0, 303641
GlobalTracer [candidate] (302.237 ms) : 0, 302237
AppSec [baseline] (162.741 ms) : 0, 162741
AppSec [candidate] (161.361 ms) : 0, 161361
Remote Config [baseline] (644.632 µs) : 0, 645
Remote Config [candidate] (640.34 µs) : 0, 640
Telemetry [baseline] (8.428 ms) : 0, 8428
Telemetry [candidate] (9.538 ms) : 0, 9538
IAST [baseline] (21.362 ms) : 0, 21362
IAST [candidate] (18.531 ms) : 0, 18531
section iast
BytebuddyAgent [baseline] (791.903 ms) : 0, 791903
BytebuddyAgent [candidate] (798.416 ms) : 0, 798416
GlobalTracer [baseline] (298.394 ms) : 0, 298394
GlobalTracer [candidate] (300.323 ms) : 0, 300323
AppSec [baseline] (54.257 ms) : 0, 54257
AppSec [candidate] (55.169 ms) : 0, 55169
Remote Config [baseline] (583.498 µs) : 0, 583
Remote Config [candidate] (634.013 µs) : 0, 634
Telemetry [baseline] (6.963 ms) : 0, 6963
Telemetry [candidate] (7.453 ms) : 0, 7453
IAST [baseline] (23.436 ms) : 0, 23436
IAST [candidate] (23.127 ms) : 0, 23127
section profiling
BytebuddyAgent [baseline] (678.117 ms) : 0, 678117
BytebuddyAgent [candidate] (677.689 ms) : 0, 677689
GlobalTracer [baseline] (396.007 ms) : 0, 396007
GlobalTracer [candidate] (395.875 ms) : 0, 395875
AppSec [baseline] (55.075 ms) : 0, 55075
AppSec [candidate] (54.641 ms) : 0, 54641
Remote Config [baseline] (656.828 µs) : 0, 657
Remote Config [candidate] (674.221 µs) : 0, 674
Telemetry [baseline] (7.509 ms) : 0, 7509
Telemetry [candidate] (7.495 ms) : 0, 7495
ProfilingAgent [baseline] (97.326 ms) : 0, 97326
ProfilingAgent [candidate] (96.694 ms) : 0, 96694
Profiling [baseline] (97.351 ms) : 0, 97351
Profiling [candidate] (96.718 ms) : 0, 96718
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-25T14:14:33 2024-09-25T14:21:23
git_branch master jb/crash_tracking_dto
git_commit_date 1727189655 1727272947
git_commit_sha 043adb2 4933b3c
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~4933b3c399
start_time 2024-09-25T14:14:20 2024-09-25T14:21:10
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727274429 1727274429
ci_job_id 651281673 651281673
ci_pipeline_id 45118285 45118285
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~4933b3c399, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.295 µs) : 350, 389
.   : milestone, 369,
iast (487.421 µs) : 466, 509
.   : milestone, 487,
iast_FULL (550.685 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (505.036 µs) : 483, 527
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (482.293 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (448.768 µs) : 427, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (472.7 µs) : 450, 495
.   : milestone, 473,
tracing (443.705 µs) : 423, 464
.   : milestone, 444,
section candidate
no_agent (368.636 µs) : 349, 389
.   : milestone, 369,
iast (482.904 µs) : 461, 505
.   : milestone, 483,
iast_FULL (549.585 µs) : 528, 571
.   : milestone, 550,
iast_GLOBAL (509.639 µs) : 487, 532
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (482.947 µs) : 461, 504
.   : milestone, 483,
iast_INACTIVE (454.369 µs) : 432, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (475.796 µs) : 453, 499
.   : milestone, 476,
tracing (447.269 µs) : 425, 469
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.295 µs [349.992 µs, 388.598 µs] -
iast 487.421 µs [465.557 µs, 509.284 µs] 118.126 µs (32.0%)
iast_FULL 550.685 µs [529.669 µs, 571.7 µs] 181.39 µs (49.1%)
iast_GLOBAL 505.036 µs [483.327 µs, 526.744 µs] 135.741 µs (36.8%)
iast_HARDCODED_SECRET_DISABLED 482.293 µs [461.347 µs, 503.239 µs] 112.998 µs (30.6%)
iast_INACTIVE 448.768 µs [427.479 µs, 470.056 µs] 79.473 µs (21.5%)
iast_TELEMETRY_OFF 472.7 µs [450.277 µs, 495.122 µs] 103.405 µs (28.0%)
tracing 443.705 µs [422.971 µs, 464.438 µs] 74.41 µs (20.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.636 µs [348.662 µs, 388.61 µs] -
iast 482.904 µs [461.264 µs, 504.544 µs] 114.268 µs (31.0%)
iast_FULL 549.585 µs [528.291 µs, 570.878 µs] 180.948 µs (49.1%)
iast_GLOBAL 509.639 µs [487.276 µs, 532.002 µs] 141.003 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED 482.947 µs [461.489 µs, 504.406 µs] 114.311 µs (31.0%)
iast_INACTIVE 454.369 µs [432.333 µs, 476.405 µs] 85.733 µs (23.3%)
iast_TELEMETRY_OFF 475.796 µs [453.009 µs, 498.583 µs] 107.16 µs (29.1%)
tracing 447.269 µs [425.228 µs, 469.31 µs] 78.633 µs (21.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~4933b3c399, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.34 ms) : 1321, 1359
.   : milestone, 1340,
appsec (1.727 ms) : 1702, 1751
.   : milestone, 1727,
appsec_no_iast (1.736 ms) : 1712, 1759
.   : milestone, 1736,
iast (1.461 ms) : 1439, 1484
.   : milestone, 1461,
profiling (1.5 ms) : 1474, 1525
.   : milestone, 1500,
tracing (1.468 ms) : 1444, 1492
.   : milestone, 1468,
section candidate
no_agent (1.34 ms) : 1320, 1360
.   : milestone, 1340,
appsec (1.716 ms) : 1692, 1739
.   : milestone, 1716,
appsec_no_iast (1.722 ms) : 1697, 1747
.   : milestone, 1722,
iast (1.471 ms) : 1449, 1494
.   : milestone, 1471,
profiling (1.472 ms) : 1450, 1495
.   : milestone, 1472,
tracing (1.467 ms) : 1443, 1491
.   : milestone, 1467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.321 ms, 1.359 ms] -
appsec 1.727 ms [1.702 ms, 1.751 ms] 386.188 µs (28.8%)
appsec_no_iast 1.736 ms [1.712 ms, 1.759 ms] 395.494 µs (29.5%)
iast 1.461 ms [1.439 ms, 1.484 ms] 120.947 µs (9.0%)
profiling 1.5 ms [1.474 ms, 1.525 ms] 159.233 µs (11.9%)
tracing 1.468 ms [1.444 ms, 1.492 ms] 127.626 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.32 ms, 1.36 ms] -
appsec 1.716 ms [1.692 ms, 1.739 ms] 375.52 µs (28.0%)
appsec_no_iast 1.722 ms [1.697 ms, 1.747 ms] 381.517 µs (28.5%)
iast 1.471 ms [1.449 ms, 1.494 ms] 130.879 µs (9.8%)
profiling 1.472 ms [1.45 ms, 1.495 ms] 132.012 µs (9.8%)
tracing 1.467 ms [1.443 ms, 1.491 ms] 126.359 µs (9.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/crash_tracking_dto
git_commit_date 1727189655 1727272947
git_commit_sha 043adb2 4933b3c
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~4933b3c399
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727274816 1727274816
ci_job_id 651281674 651281674
ci_pipeline_id 45118285 45118285
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~4933b3c399, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.983 s) : 14983000, 14983000
.   : milestone, 14983000,
appsec (15.135 s) : 15135000, 15135000
.   : milestone, 15135000,
iast (18.618 s) : 18618000, 18618000
.   : milestone, 18618000,
iast_GLOBAL (18.053 s) : 18053000, 18053000
.   : milestone, 18053000,
profiling (15.38 s) : 15380000, 15380000
.   : milestone, 15380000,
tracing (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
section candidate
no_agent (15.8 s) : 15800000, 15800000
.   : milestone, 15800000,
appsec (15.274 s) : 15274000, 15274000
.   : milestone, 15274000,
iast (18.877 s) : 18877000, 18877000
.   : milestone, 18877000,
iast_GLOBAL (17.797 s) : 17797000, 17797000
.   : milestone, 17797000,
profiling (15.814 s) : 15814000, 15814000
.   : milestone, 15814000,
tracing (14.946 s) : 14946000, 14946000
.   : milestone, 14946000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.983 s [14.983 s, 14.983 s] -
appsec 15.135 s [15.135 s, 15.135 s] 152.0 ms (1.0%)
iast 18.618 s [18.618 s, 18.618 s] 3.635 s (24.3%)
iast_GLOBAL 18.053 s [18.053 s, 18.053 s] 3.07 s (20.5%)
profiling 15.38 s [15.38 s, 15.38 s] 397.0 ms (2.6%)
tracing 15.022 s [15.022 s, 15.022 s] 39.0 ms (0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.8 s [15.8 s, 15.8 s] -
appsec 15.274 s [15.274 s, 15.274 s] -526.0 ms (-3.3%)
iast 18.877 s [18.877 s, 18.877 s] 3.077 s (19.5%)
iast_GLOBAL 17.797 s [17.797 s, 17.797 s] 1.997 s (12.6%)
profiling 15.814 s [15.814 s, 15.814 s] 14.0 ms (0.1%)
tracing 14.946 s [14.946 s, 14.946 s] -854.0 ms (-5.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~4933b3c399, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.334 ms) : 2292, 2375
.   : milestone, 2334,
iast (2.077 ms) : 2026, 2129
.   : milestone, 2077,
iast_GLOBAL (2.11 ms) : 2059, 2162
.   : milestone, 2110,
profiling (1.943 ms) : 1903, 1984
.   : milestone, 1943,
tracing (1.91 ms) : 1872, 1948
.   : milestone, 1910,
section candidate
no_agent (1.475 ms) : 1463, 1487
.   : milestone, 1475,
appsec (2.323 ms) : 2283, 2364
.   : milestone, 2323,
iast (2.071 ms) : 2021, 2122
.   : milestone, 2071,
iast_GLOBAL (2.117 ms) : 2065, 2168
.   : milestone, 2117,
profiling (1.936 ms) : 1896, 1976
.   : milestone, 1936,
tracing (1.909 ms) : 1870, 1947
.   : milestone, 1909,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.334 ms [2.292 ms, 2.375 ms] 865.137 µs (58.9%)
iast 2.077 ms [2.026 ms, 2.129 ms] 609.058 µs (41.5%)
iast_GLOBAL 2.11 ms [2.059 ms, 2.162 ms] 641.935 µs (43.7%)
profiling 1.943 ms [1.903 ms, 1.984 ms] 475.054 µs (32.4%)
tracing 1.91 ms [1.872 ms, 1.948 ms] 441.298 µs (30.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.487 ms] -
appsec 2.323 ms [2.283 ms, 2.364 ms] 848.536 µs (57.5%)
iast 2.071 ms [2.021 ms, 2.122 ms] 596.235 µs (40.4%)
iast_GLOBAL 2.117 ms [2.065 ms, 2.168 ms] 641.564 µs (43.5%)
profiling 1.936 ms [1.896 ms, 1.976 ms] 460.814 µs (31.2%)
tracing 1.909 ms [1.87 ms, 1.947 ms] 433.695 µs (29.4%)

datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 bot reviewed Sep 24, 2024
View reviewed changes
dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/dto/Metadata.java Outdated Show resolved Hide resolved
dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/dto/ProcInfo.java Outdated Show resolved Hide resolved
dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/dto/StackFrame.java Outdated Show resolved Hide resolved
dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/dto/Metadata.java Outdated Show resolved Hide resolved
dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/dto/StackTrace.java Outdated Show resolved Hide resolved
...a-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/dto/SemanticVersion.java Outdated Show resolved Hide resolved
dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/dto/ProcInfo.java Outdated Show resolved Hide resolved
dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/dto/OSInfo.java Outdated Show resolved Hide resolved
dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/dto/OSInfo.java Outdated Show resolved Hide resolved
dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/dto/StackFrame.java Outdated Show resolved Hide resolved
@jbachorik jbachorik force-pushed the jb/crash_tracking_dto branch 3 times, most recently from bd9008c to f7c0c06 Compare September 25, 2024 08:38
@jbachorik jbachorik force-pushed the jb/crash_tracking_dto branch 3 times, most recently from 00acca5 to af565a2 Compare September 25, 2024 13:46
@jbachorik jbachorik marked this pull request as ready for review September 25, 2024 16:32
@jbachorik jbachorik merged commit 8ee4a5d into master Sep 26, 2024
102 checks passed
@jbachorik jbachorik deleted the jb/crash_tracking_dto branch September 26, 2024 08:47
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 Datadog - DataDog prod us1 Datadog - DataDog prod us1 left review comments

@MattAlp MattAlp MattAlp approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: crash tracking Crash tracking tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbachorik @MattAlp