Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CPU count tag to Test Visibility events #7659

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add CPU count tag to Test Visibility events #7659

merged 1 commit into from
Sep 24, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Sep 20, 2024 •
edited by jira bot
Loading

What Does This Do

Adds new _dd.host.vcpu_count tag with the count of available CPUs to all Test Visibility events: tests, suites, modules, sessions.

Motivation

This is needed by Datadog backend for evaluating CI costs.

Contributor Checklist

Jira ticket: SDTEST-867

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Sep 20, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review September 20, 2024 15:42
@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/cpu-count
git_commit_date 1726843314 1726844514
git_commit_sha f681000 d5c5484
release_version 1.40.0-SNAPSHOT~f6810002f7 1.40.0-SNAPSHOT~d5c5484cdb
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726847063 1726847063
ci_job_id 646642451 646642451
ci_pipeline_id 44802265 44802265
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~d5c5484cdb, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075140
Total [baseline] (10.443 s) : 0, 10442994
Agent [candidate] (1.079 s) : 0, 1079254
Total [candidate] (10.405 s) : 0, 10405459
section appsec
Agent [baseline] (1.213 s) : 0, 1212928
Total [baseline] (10.719 s) : 0, 10719357
Agent [candidate] (1.207 s) : 0, 1206690
Total [candidate] (10.708 s) : 0, 10707869
section iast
Agent [baseline] (1.194 s) : 0, 1194234
Total [baseline] (10.887 s) : 0, 10886904
Agent [candidate] (1.208 s) : 0, 1208416
Total [candidate] (10.893 s) : 0, 10893265
section profiling
Agent [baseline] (1.277 s) : 0, 1276859
Total [baseline] (10.627 s) : 0, 10627287
Agent [candidate] (1.272 s) : 0, 1271657
Total [candidate] (10.624 s) : 0, 10624026
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.213 s 137.788 ms (12.8%)
Agent iast 1.194 s 119.094 ms (11.1%)
Agent profiling 1.277 s 201.719 ms (18.8%)
Total tracing 10.443 s -
Total appsec 10.719 s 276.364 ms (2.6%)
Total iast 10.887 s 443.91 ms (4.3%)
Total profiling 10.627 s 184.293 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.207 s 127.437 ms (11.8%)
Agent iast 1.208 s 129.162 ms (12.0%)
Agent profiling 1.272 s 192.403 ms (17.8%)
Total tracing 10.405 s -
Total appsec 10.708 s 302.41 ms (2.9%)
Total iast 10.893 s 487.806 ms (4.7%)
Total profiling 10.624 s 218.567 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~d5c5484cdb, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.796 ms) : 0, 684796
BytebuddyAgent [candidate] (689.639 ms) : 0, 689639
GlobalTracer [baseline] (313.618 ms) : 0, 313618
GlobalTracer [candidate] (313.077 ms) : 0, 313077
AppSec [baseline] (54.472 ms) : 0, 54472
AppSec [candidate] (54.266 ms) : 0, 54266
Remote Config [baseline] (679.27 µs) : 0, 679
Remote Config [candidate] (668.334 µs) : 0, 668
Telemetry [baseline] (7.706 ms) : 0, 7706
Telemetry [candidate] (7.685 ms) : 0, 7685
section appsec
BytebuddyAgent [baseline] (708.087 ms) : 0, 708087
BytebuddyAgent [candidate] (705.252 ms) : 0, 705252
GlobalTracer [baseline] (306.341 ms) : 0, 306341
GlobalTracer [candidate] (305.332 ms) : 0, 305332
AppSec [baseline] (164.425 ms) : 0, 164425
AppSec [candidate] (163.827 ms) : 0, 163827
Remote Config [baseline] (648.546 µs) : 0, 649
Remote Config [candidate] (645.168 µs) : 0, 645
Telemetry [baseline] (9.599 ms) : 0, 9599
Telemetry [candidate] (8.212 ms) : 0, 8212
IAST [baseline] (20.022 ms) : 0, 20022
IAST [candidate] (19.314 ms) : 0, 19314
section iast
BytebuddyAgent [baseline] (793.625 ms) : 0, 793625
BytebuddyAgent [candidate] (804.741 ms) : 0, 804741
GlobalTracer [baseline] (300.21 ms) : 0, 300210
GlobalTracer [candidate] (302.35 ms) : 0, 302350
AppSec [baseline] (55.574 ms) : 0, 55574
AppSec [candidate] (54.459 ms) : 0, 54459
Remote Config [baseline] (619.851 µs) : 0, 620
Remote Config [candidate] (654.045 µs) : 0, 654
Telemetry [baseline] (8.207 ms) : 0, 8207
Telemetry [candidate] (7.505 ms) : 0, 7505
IAST [baseline] (22.199 ms) : 0, 22199
IAST [candidate] (24.741 ms) : 0, 24741
section profiling
BytebuddyAgent [baseline] (679.561 ms) : 0, 679561
BytebuddyAgent [candidate] (675.78 ms) : 0, 675780
GlobalTracer [baseline] (398.817 ms) : 0, 398817
GlobalTracer [candidate] (396.81 ms) : 0, 396810
AppSec [baseline] (54.979 ms) : 0, 54979
AppSec [candidate] (54.964 ms) : 0, 54964
Remote Config [baseline] (660.879 µs) : 0, 661
Remote Config [candidate] (655.847 µs) : 0, 656
Telemetry [baseline] (7.532 ms) : 0, 7532
Telemetry [candidate] (7.47 ms) : 0, 7470
ProfilingAgent [baseline] (96.829 ms) : 0, 96829
ProfilingAgent [candidate] (97.617 ms) : 0, 97617
Profiling [baseline] (96.853 ms) : 0, 96853
Profiling [candidate] (97.641 ms) : 0, 97641
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~d5c5484cdb, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1077288
Total [baseline] (8.572 s) : 0, 8572484
Agent [candidate] (1.065 s) : 0, 1065267
Total [candidate] (8.568 s) : 0, 8568210
section iast
Agent [baseline] (1.195 s) : 0, 1195394
Total [baseline] (9.014 s) : 0, 9014400
Agent [candidate] (1.193 s) : 0, 1193150
Total [candidate] (9.029 s) : 0, 9029151
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.194 s) : 0, 1194350
Total [baseline] (9.004 s) : 0, 9004200
Agent [candidate] (1.212 s) : 0, 1212207
Total [candidate] (9.017 s) : 0, 9017190
section iast_TELEMETRY_OFF
Agent [baseline] (1.192 s) : 0, 1192203
Total [baseline] (9.024 s) : 0, 9024056
Agent [candidate] (1.191 s) : 0, 1191244
Total [candidate] (9.048 s) : 0, 9047933
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.195 s 118.106 ms (11.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.194 s 117.062 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.192 s 114.915 ms (10.7%)
Total tracing 8.572 s -
Total iast 9.014 s 441.916 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.004 s 431.716 ms (5.0%)
Total iast_TELEMETRY_OFF 9.024 s 451.572 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.193 s 127.883 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.212 s 146.94 ms (13.8%)
Agent iast_TELEMETRY_OFF 1.191 s 125.977 ms (11.8%)
Total tracing 8.568 s -
Total iast 9.029 s 460.941 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.017 s 448.979 ms (5.2%)
Total iast_TELEMETRY_OFF 9.048 s 479.722 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~d5c5484cdb, baseline=1.40.0-SNAPSHOT~f6810002f7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.132 ms) : 0, 687132
BytebuddyAgent [candidate] (678.753 ms) : 0, 678753
GlobalTracer [baseline] (313.795 ms) : 0, 313795
GlobalTracer [candidate] (310.789 ms) : 0, 310789
AppSec [baseline] (54.158 ms) : 0, 54158
AppSec [candidate] (53.635 ms) : 0, 53635
Remote Config [baseline] (677.269 µs) : 0, 677
Remote Config [candidate] (663.63 µs) : 0, 664
Telemetry [baseline] (7.659 ms) : 0, 7659
Telemetry [candidate] (7.708 ms) : 0, 7708
section iast
BytebuddyAgent [baseline] (794.625 ms) : 0, 794625
BytebuddyAgent [candidate] (793.067 ms) : 0, 793067
GlobalTracer [baseline] (299.97 ms) : 0, 299970
GlobalTracer [candidate] (299.724 ms) : 0, 299724
AppSec [baseline] (54.324 ms) : 0, 54324
AppSec [candidate] (55.959 ms) : 0, 55959
IAST [baseline] (24.564 ms) : 0, 24564
IAST [candidate] (22.642 ms) : 0, 22642
Remote Config [baseline] (635.277 µs) : 0, 635
Remote Config [candidate] (618.58 µs) : 0, 619
Telemetry [baseline] (7.421 ms) : 0, 7421
Telemetry [candidate] (7.355 ms) : 0, 7355
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.569 ms) : 0, 793569
BytebuddyAgent [candidate] (805.883 ms) : 0, 805883
GlobalTracer [baseline] (300.464 ms) : 0, 300464
GlobalTracer [candidate] (304.506 ms) : 0, 304506
AppSec [baseline] (53.231 ms) : 0, 53231
AppSec [candidate] (54.016 ms) : 0, 54016
IAST [baseline] (25.305 ms) : 0, 25305
IAST [candidate] (25.63 ms) : 0, 25630
Remote Config [baseline] (617.117 µs) : 0, 617
Remote Config [candidate] (614.97 µs) : 0, 615
Telemetry [baseline] (7.356 ms) : 0, 7356
Telemetry [candidate] (7.572 ms) : 0, 7572
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.212 ms) : 0, 791212
BytebuddyAgent [candidate] (790.103 ms) : 0, 790103
GlobalTracer [baseline] (300.923 ms) : 0, 300923
GlobalTracer [candidate] (300.729 ms) : 0, 300729
AppSec [baseline] (56.063 ms) : 0, 56063
AppSec [candidate] (56.037 ms) : 0, 56037
IAST [baseline] (22.346 ms) : 0, 22346
IAST [candidate] (21.82 ms) : 0, 21820
Remote Config [baseline] (607.017 µs) : 0, 607
Remote Config [candidate] (1.412 ms) : 0, 1412
Telemetry [baseline] (7.246 ms) : 0, 7246
Telemetry [candidate] (7.351 ms) : 0, 7351
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-20T15:14:54 2024-09-20T15:21:44
git_branch master nikita-tkachenko/cpu-count
git_commit_date 1726843314 1726844514
git_commit_sha f681000 d5c5484
release_version 1.40.0-SNAPSHOT~f6810002f7 1.40.0-SNAPSHOT~d5c5484cdb
start_time 2024-09-20T15:14:41 2024-09-20T15:21:31
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726846049 1726846049
ci_job_id 646642452 646642452
ci_pipeline_id 44802265 44802265
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~d5c5484cdb, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.336 ms) : 1316, 1357
.   : milestone, 1336,
appsec (1.733 ms) : 1710, 1756
.   : milestone, 1733,
appsec_no_iast (1.704 ms) : 1678, 1729
.   : milestone, 1704,
iast (1.469 ms) : 1446, 1492
.   : milestone, 1469,
profiling (1.49 ms) : 1466, 1515
.   : milestone, 1490,
tracing (1.456 ms) : 1432, 1480
.   : milestone, 1456,
section candidate
no_agent (1.34 ms) : 1321, 1360
.   : milestone, 1340,
appsec (1.728 ms) : 1705, 1751
.   : milestone, 1728,
appsec_no_iast (1.719 ms) : 1695, 1743
.   : milestone, 1719,
iast (1.479 ms) : 1456, 1502
.   : milestone, 1479,
profiling (1.477 ms) : 1453, 1500
.   : milestone, 1477,
tracing (1.478 ms) : 1453, 1502
.   : milestone, 1478,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.316 ms, 1.357 ms] -
appsec 1.733 ms [1.71 ms, 1.756 ms] 396.905 µs (29.7%)
appsec_no_iast 1.704 ms [1.678 ms, 1.729 ms] 367.43 µs (27.5%)
iast 1.469 ms [1.446 ms, 1.492 ms] 132.508 µs (9.9%)
profiling 1.49 ms [1.466 ms, 1.515 ms] 153.9 µs (11.5%)
tracing 1.456 ms [1.432 ms, 1.48 ms] 119.381 µs (8.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.321 ms, 1.36 ms] -
appsec 1.728 ms [1.705 ms, 1.751 ms] 387.904 µs (28.9%)
appsec_no_iast 1.719 ms [1.695 ms, 1.743 ms] 378.565 µs (28.2%)
iast 1.479 ms [1.456 ms, 1.502 ms] 138.851 µs (10.4%)
profiling 1.477 ms [1.453 ms, 1.5 ms] 136.332 µs (10.2%)
tracing 1.478 ms [1.453 ms, 1.502 ms] 137.371 µs (10.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~d5c5484cdb, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (380.772 µs) : 361, 401
.   : milestone, 381,
iast (481.67 µs) : 461, 503
.   : milestone, 482,
iast_FULL (555.518 µs) : 534, 577
.   : milestone, 556,
iast_GLOBAL (504.225 µs) : 483, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (480.328 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (446.343 µs) : 426, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (474.85 µs) : 453, 497
.   : milestone, 475,
tracing (445.226 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (369.35 µs) : 349, 389
.   : milestone, 369,
iast (483.393 µs) : 462, 505
.   : milestone, 483,
iast_FULL (551.181 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (506.721 µs) : 485, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (482.012 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (447.452 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (474.167 µs) : 451, 497
.   : milestone, 474,
tracing (441.186 µs) : 421, 461
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.772 µs [360.787 µs, 400.758 µs] -
iast 481.67 µs [460.646 µs, 502.693 µs] 100.897 µs (26.5%)
iast_FULL 555.518 µs [533.985 µs, 577.051 µs] 174.746 µs (45.9%)
iast_GLOBAL 504.225 µs [482.92 µs, 525.531 µs] 123.453 µs (32.4%)
iast_HARDCODED_SECRET_DISABLED 480.328 µs [459.307 µs, 501.35 µs] 99.556 µs (26.1%)
iast_INACTIVE 446.343 µs [425.52 µs, 467.166 µs] 65.57 µs (17.2%)
iast_TELEMETRY_OFF 474.85 µs [452.546 µs, 497.154 µs] 94.078 µs (24.7%)
tracing 445.226 µs [424.422 µs, 466.03 µs] 64.454 µs (16.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.35 µs [349.468 µs, 389.231 µs] -
iast 483.393 µs [462.239 µs, 504.547 µs] 114.043 µs (30.9%)
iast_FULL 551.181 µs [530.158 µs, 572.203 µs] 181.831 µs (49.2%)
iast_GLOBAL 506.721 µs [485.422 µs, 528.021 µs] 137.371 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 482.012 µs [460.704 µs, 503.321 µs] 112.663 µs (30.5%)
iast_INACTIVE 447.452 µs [426.469 µs, 468.434 µs] 78.102 µs (21.1%)
iast_TELEMETRY_OFF 474.167 µs [451.262 µs, 497.071 µs] 104.817 µs (28.4%)
tracing 441.186 µs [420.936 µs, 461.436 µs] 71.836 µs (19.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/cpu-count
git_commit_date 1726843314 1726844514
git_commit_sha f681000 d5c5484
release_version 1.40.0-SNAPSHOT~f6810002f7 1.40.0-SNAPSHOT~d5c5484cdb
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726846576 1726846576
ci_job_id 646642453 646642453
ci_pipeline_id 44802265 44802265
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~d5c5484cdb, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.317 ms) : 2276, 2358
.   : milestone, 2317,
iast (2.041 ms) : 1992, 2091
.   : milestone, 2041,
iast_GLOBAL (2.088 ms) : 2038, 2138
.   : milestone, 2088,
profiling (1.931 ms) : 1891, 1971
.   : milestone, 1931,
tracing (1.901 ms) : 1863, 1939
.   : milestone, 1901,
section candidate
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.32 ms) : 2280, 2361
.   : milestone, 2320,
iast (2.062 ms) : 2011, 2112
.   : milestone, 2062,
iast_GLOBAL (2.09 ms) : 2040, 2140
.   : milestone, 2090,
profiling (1.91 ms) : 1870, 1949
.   : milestone, 1910,
tracing (1.901 ms) : 1863, 1939
.   : milestone, 1901,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.459 ms, 1.482 ms] -
appsec 2.317 ms [2.276 ms, 2.358 ms] 846.856 µs (57.6%)
iast 2.041 ms [1.992 ms, 2.091 ms] 571.269 µs (38.9%)
iast_GLOBAL 2.088 ms [2.038 ms, 2.138 ms] 617.641 µs (42.0%)
profiling 1.931 ms [1.891 ms, 1.971 ms] 460.765 µs (31.3%)
tracing 1.901 ms [1.863 ms, 1.939 ms] 430.832 µs (29.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.32 ms [2.28 ms, 2.361 ms] 860.939 µs (59.0%)
iast 2.062 ms [2.011 ms, 2.112 ms] 602.412 µs (41.3%)
iast_GLOBAL 2.09 ms [2.04 ms, 2.14 ms] 630.887 µs (43.2%)
profiling 1.91 ms [1.87 ms, 1.949 ms] 450.426 µs (30.9%)
tracing 1.901 ms [1.863 ms, 1.939 ms] 441.831 µs (30.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~d5c5484cdb, baseline=1.40.0-SNAPSHOT~f6810002f7
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.252 s) : 15252000, 15252000
.   : milestone, 15252000,
appsec (15.271 s) : 15271000, 15271000
.   : milestone, 15271000,
iast (19.082 s) : 19082000, 19082000
.   : milestone, 19082000,
iast_GLOBAL (18.197 s) : 18197000, 18197000
.   : milestone, 18197000,
profiling (15.609 s) : 15609000, 15609000
.   : milestone, 15609000,
tracing (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
section candidate
no_agent (15.097 s) : 15097000, 15097000
.   : milestone, 15097000,
appsec (15.457 s) : 15457000, 15457000
.   : milestone, 15457000,
iast (18.755 s) : 18755000, 18755000
.   : milestone, 18755000,
iast_GLOBAL (17.944 s) : 17944000, 17944000
.   : milestone, 17944000,
profiling (15.498 s) : 15498000, 15498000
.   : milestone, 15498000,
tracing (15.414 s) : 15414000, 15414000
.   : milestone, 15414000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.252 s [15.252 s, 15.252 s] -
appsec 15.271 s [15.271 s, 15.271 s] 19.0 ms (0.1%)
iast 19.082 s [19.082 s, 19.082 s] 3.83 s (25.1%)
iast_GLOBAL 18.197 s [18.197 s, 18.197 s] 2.945 s (19.3%)
profiling 15.609 s [15.609 s, 15.609 s] 357.0 ms (2.3%)
tracing 14.948 s [14.948 s, 14.948 s] -304.0 ms (-2.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.097 s [15.097 s, 15.097 s] -
appsec 15.457 s [15.457 s, 15.457 s] 360.0 ms (2.4%)
iast 18.755 s [18.755 s, 18.755 s] 3.658 s (24.2%)
iast_GLOBAL 17.944 s [17.944 s, 17.944 s] 2.847 s (18.9%)
profiling 15.498 s [15.498 s, 15.498 s] 401.0 ms (2.7%)
tracing 15.414 s [15.414 s, 15.414 s] 317.0 ms (2.1%)

PerfectSlayer
PerfectSlayer approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but does the different behavior between Java versions will be an issue here?

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 043adb2 into master Sep 24, 2024
104 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/cpu-count branch September 24, 2024 14:54
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 24, 2024
shatzi pushed a commit that referenced this pull request Sep 25, 2024
@nikita-tkachenko-datadog @shatzi
Add CPU count tag to Test Visibility events (#7659)
c75a2c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@romainkomorndatadog romainkomorndatadog Awaiting requested review from romainkomorndatadog romainkomorndatadog is a code owner automatically assigned from DataDog/ci-app-libraries-java

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: enhancement
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nikita-tkachenko-datadog @smola @PerfectSlayer