Kafka-clients 3.8 support #7626
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (this == o) return true; | |
| if (this == o) {return true}; |
single if statement should be wrapped in a brace (...read more)
Omitting braces {} is valid in multiple statements, such as, for loops, if statements, and while loops. However, enforcing the use of control braces throughout your codebase will make the code more consistent and can make it easier to add statements in the future.
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (o == null || getClass() != o.getClass()) return false; | |
| if (o == null || getClass() != o.getClass()) {return false}; |
single if statement should be wrapped in a brace (...read more)
Omitting braces {} is valid in multiple statements, such as, for loops, if statements, and while loops. However, enforcing the use of control braces throughout your codebase will make the code more consistent and can make it easier to add statements in the future.
Comment on lines
81
to
85
| protected KafkaDecorator(String spanKind, CharSequence spanType, String serviceName) { | ||
| this.spanKind = spanKind; | ||
| this.spanType = spanType; | ||
| this.serviceName = serviceName; | ||
| } |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider adding super() or this() to your constructor (...read more)
In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.
See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~855401d49c, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067863
Total [baseline] (8.581 s) : 0, 8581371
Agent [candidate] (1.068 s) : 0, 1067891
Total [candidate] (8.581 s) : 0, 8580748
section iast
Agent [baseline] (1.189 s) : 0, 1188723
Total [baseline] (9.005 s) : 0, 9004990
Agent [candidate] (1.194 s) : 0, 1194246
Total [candidate] (9.031 s) : 0, 9031500
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.191 s) : 0, 1191454
Total [baseline] (9.008 s) : 0, 9007611
Agent [candidate] (1.195 s) : 0, 1194824
Total [candidate] (9.062 s) : 0, 9062214
section iast_TELEMETRY_OFF
Agent [baseline] (1.188 s) : 0, 1188470
Total [baseline] (9.051 s) : 0, 9050591
Agent [candidate] (1.194 s) : 0, 1194081
Total [candidate] (9.035 s) : 0, 9034628
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~855401d49c, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.978 ms) : 0, 680978
BytebuddyAgent [candidate] (681.299 ms) : 0, 681299
GlobalTracer [baseline] (311.001 ms) : 0, 311001
GlobalTracer [candidate] (310.831 ms) : 0, 310831
AppSec [baseline] (53.88 ms) : 0, 53880
AppSec [candidate] (53.848 ms) : 0, 53848
Remote Config [baseline] (660.437 µs) : 0, 660
Remote Config [candidate] (666.595 µs) : 0, 667
Telemetry [baseline] (7.634 ms) : 0, 7634
Telemetry [candidate] (7.546 ms) : 0, 7546
section iast
BytebuddyAgent [baseline] (790.158 ms) : 0, 790158
BytebuddyAgent [candidate] (794.65 ms) : 0, 794650
GlobalTracer [baseline] (298.882 ms) : 0, 298882
GlobalTracer [candidate] (299.751 ms) : 0, 299751
AppSec [baseline] (56.482 ms) : 0, 56482
AppSec [candidate] (54.522 ms) : 0, 54522
IAST [baseline] (21.869 ms) : 0, 21869
IAST [candidate] (23.888 ms) : 0, 23888
Remote Config [baseline] (607.882 µs) : 0, 608
Remote Config [candidate] (608.048 µs) : 0, 608
Telemetry [baseline] (6.975 ms) : 0, 6975
Telemetry [candidate] (7.081 ms) : 0, 7081
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (792.397 ms) : 0, 792397
BytebuddyAgent [candidate] (794.273 ms) : 0, 794273
GlobalTracer [baseline] (299.734 ms) : 0, 299734
GlobalTracer [candidate] (300.729 ms) : 0, 300729
AppSec [baseline] (53.832 ms) : 0, 53832
AppSec [candidate] (52.362 ms) : 0, 52362
IAST [baseline] (23.932 ms) : 0, 23932
IAST [candidate] (25.034 ms) : 0, 25034
Remote Config [baseline] (645.405 µs) : 0, 645
Remote Config [candidate] (617.606 µs) : 0, 618
Telemetry [baseline] (7.123 ms) : 0, 7123
Telemetry [candidate] (7.996 ms) : 0, 7996
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (788.908 ms) : 0, 788908
BytebuddyAgent [candidate] (793.322 ms) : 0, 793322
GlobalTracer [baseline] (300.511 ms) : 0, 300511
GlobalTracer [candidate] (301.403 ms) : 0, 301403
AppSec [baseline] (55.095 ms) : 0, 55095
AppSec [candidate] (55.567 ms) : 0, 55567
IAST [baseline] (21.77 ms) : 0, 21770
IAST [candidate] (22.454 ms) : 0, 22454
Remote Config [baseline] (1.369 ms) : 0, 1369
Remote Config [candidate] (598.075 µs) : 0, 598
Telemetry [baseline] (7.033 ms) : 0, 7033
Telemetry [candidate] (6.896 ms) : 0, 6896
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~855401d49c, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065030
Total [baseline] (10.477 s) : 0, 10476869
Agent [candidate] (1.075 s) : 0, 1074922
Total [candidate] (10.339 s) : 0, 10339471
section appsec
Agent [baseline] (1.205 s) : 0, 1205012
Total [baseline] (10.66 s) : 0, 10659842
Agent [candidate] (1.214 s) : 0, 1213843
Total [candidate] (10.701 s) : 0, 10700906
section iast
Agent [baseline] (1.192 s) : 0, 1191925
Total [baseline] (10.837 s) : 0, 10837123
Agent [candidate] (1.196 s) : 0, 1196054
Total [candidate] (10.812 s) : 0, 10812303
section profiling
Agent [baseline] (1.27 s) : 0, 1270020
Total [baseline] (10.646 s) : 0, 10646119
Agent [candidate] (1.28 s) : 0, 1279881
Total [candidate] (10.642 s) : 0, 10642456
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~855401d49c, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.768 ms) : 0, 678768
BytebuddyAgent [candidate] (685.811 ms) : 0, 685811
GlobalTracer [baseline] (310.396 ms) : 0, 310396
GlobalTracer [candidate] (312.792 ms) : 0, 312792
AppSec [baseline] (53.831 ms) : 0, 53831
AppSec [candidate] (54.26 ms) : 0, 54260
Remote Config [baseline] (668.932 µs) : 0, 669
Remote Config [candidate] (679.011 µs) : 0, 679
Telemetry [baseline] (7.712 ms) : 0, 7712
Telemetry [candidate] (7.587 ms) : 0, 7587
section appsec
BytebuddyAgent [baseline] (703.922 ms) : 0, 703922
BytebuddyAgent [candidate] (710.433 ms) : 0, 710433
GlobalTracer [baseline] (304.929 ms) : 0, 304929
GlobalTracer [candidate] (306.047 ms) : 0, 306047
AppSec [baseline] (162.973 ms) : 0, 162973
AppSec [candidate] (163.109 ms) : 0, 163109
Remote Config [baseline] (638.338 µs) : 0, 638
Remote Config [candidate] (655.385 µs) : 0, 655
Telemetry [baseline] (8.88 ms) : 0, 8880
Telemetry [candidate] (9.253 ms) : 0, 9253
IAST [baseline] (19.83 ms) : 0, 19830
IAST [candidate] (20.99 ms) : 0, 20990
section iast
BytebuddyAgent [baseline] (792.863 ms) : 0, 792863
BytebuddyAgent [candidate] (795.625 ms) : 0, 795625
GlobalTracer [baseline] (299.797 ms) : 0, 299797
GlobalTracer [candidate] (300.7 ms) : 0, 300700
AppSec [baseline] (54.386 ms) : 0, 54386
AppSec [candidate] (55.696 ms) : 0, 55696
Remote Config [baseline] (589.235 µs) : 0, 589
Remote Config [candidate] (589.468 µs) : 0, 589
Telemetry [baseline] (6.972 ms) : 0, 6972
Telemetry [candidate] (6.976 ms) : 0, 6976
IAST [baseline] (23.585 ms) : 0, 23585
IAST [candidate] (22.69 ms) : 0, 22690
section profiling
ProfilingAgent [baseline] (96.767 ms) : 0, 96767
ProfilingAgent [candidate] (97.763 ms) : 0, 97763
BytebuddyAgent [baseline] (675.35 ms) : 0, 675350
BytebuddyAgent [candidate] (681.393 ms) : 0, 681393
GlobalTracer [baseline] (396.322 ms) : 0, 396322
GlobalTracer [candidate] (398.449 ms) : 0, 398449
AppSec [baseline] (54.588 ms) : 0, 54588
AppSec [candidate] (54.948 ms) : 0, 54948
Remote Config [baseline] (643.491 µs) : 0, 643
Remote Config [candidate] (659.243 µs) : 0, 659
Telemetry [baseline] (7.511 ms) : 0, 7511
Telemetry [candidate] (7.573 ms) : 0, 7573
Profiling [baseline] (96.79 ms) : 0, 96790
Profiling [candidate] (97.787 ms) : 0, 97787
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~855401d49c, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section baseline
no_agent (376.29 µs) : 355, 397
. : milestone, 376,
iast (483.887 µs) : 462, 505
. : milestone, 484,
iast_FULL (551.662 µs) : 531, 573
. : milestone, 552,
iast_GLOBAL (517.519 µs) : 496, 540
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (492.019 µs) : 471, 513
. : milestone, 492,
iast_INACTIVE (446.863 µs) : 426, 468
. : milestone, 447,
iast_TELEMETRY_OFF (477.14 µs) : 454, 500
. : milestone, 477,
tracing (443.884 µs) : 423, 465
. : milestone, 444,
section candidate
no_agent (373.451 µs) : 354, 393
. : milestone, 373,
iast (488.917 µs) : 467, 511
. : milestone, 489,
iast_FULL (556.856 µs) : 536, 578
. : milestone, 557,
iast_GLOBAL (513.96 µs) : 491, 536
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (482.124 µs) : 461, 503
. : milestone, 482,
iast_INACTIVE (449.961 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (477.682 µs) : 455, 500
. : milestone, 478,
tracing (457.091 µs) : 435, 479
. : milestone, 457,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~855401d49c, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section baseline
no_agent (1.328 ms) : 1309, 1348
. : milestone, 1328,
appsec (1.724 ms) : 1701, 1748
. : milestone, 1724,
appsec_no_iast (1.725 ms) : 1701, 1749
. : milestone, 1725,
iast (1.466 ms) : 1443, 1488
. : milestone, 1466,
profiling (1.533 ms) : 1507, 1558
. : milestone, 1533,
tracing (1.464 ms) : 1440, 1487
. : milestone, 1464,
section candidate
no_agent (1.339 ms) : 1319, 1358
. : milestone, 1339,
appsec (1.739 ms) : 1715, 1762
. : milestone, 1739,
appsec_no_iast (1.732 ms) : 1708, 1755
. : milestone, 1732,
iast (1.481 ms) : 1458, 1503
. : milestone, 1481,
profiling (1.48 ms) : 1456, 1505
. : milestone, 1480,
tracing (1.466 ms) : 1442, 1490
. : milestone, 1466,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~855401d49c, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section baseline
no_agent (1.463 ms) : 1451, 1474
. : milestone, 1463,
appsec (2.328 ms) : 2287, 2369
. : milestone, 2328,
iast (2.051 ms) : 2000, 2102
. : milestone, 2051,
iast_GLOBAL (2.102 ms) : 2051, 2153
. : milestone, 2102,
profiling (1.934 ms) : 1892, 1976
. : milestone, 1934,
tracing (1.908 ms) : 1869, 1946
. : milestone, 1908,
section candidate
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.323 ms) : 2282, 2364
. : milestone, 2323,
iast (2.054 ms) : 2004, 2105
. : milestone, 2054,
iast_GLOBAL (2.11 ms) : 2058, 2161
. : milestone, 2110,
profiling (1.938 ms) : 1896, 1980
. : milestone, 1938,
tracing (1.9 ms) : 1861, 1938
. : milestone, 1900,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~855401d49c, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section baseline
no_agent (15.193 s) : 15193000, 15193000
. : milestone, 15193000,
appsec (15.201 s) : 15201000, 15201000
. : milestone, 15201000,
iast (18.917 s) : 18917000, 18917000
. : milestone, 18917000,
iast_GLOBAL (18.07 s) : 18070000, 18070000
. : milestone, 18070000,
profiling (15.776 s) : 15776000, 15776000
. : milestone, 15776000,
tracing (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
section candidate
no_agent (15.039 s) : 15039000, 15039000
. : milestone, 15039000,
appsec (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
iast (18.85 s) : 18850000, 18850000
. : milestone, 18850000,
iast_GLOBAL (18.109 s) : 18109000, 18109000
. : milestone, 18109000,
profiling (15.184 s) : 15184000, 15184000
. : milestone, 15184000,
tracing (15.229 s) : 15229000, 15229000
. : milestone, 15229000,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (this == o) return true; | |
| if (this == o) {return true}; |
single if statement should be wrapped in a brace (...read more)
Omitting braces {} is valid in multiple statements, such as, for loops, if statements, and while loops. However, enforcing the use of control braces throughout your codebase will make the code more consistent and can make it easier to add statements in the future.
Comment on lines
81
to
85
| protected KafkaDecorator(String spanKind, CharSequence spanType, String serviceName) { | ||
| this.spanKind = spanKind; | ||
| this.spanType = spanType; | ||
| this.serviceName = serviceName; | ||
| } |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider adding super() or this() to your constructor (...read more)
In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (o == null || getClass() != o.getClass()) return false; | |
| if (o == null || getClass() != o.getClass()) {return false}; |
single if statement should be wrapped in a brace (...read more)
Omitting braces {} is valid in multiple statements, such as, for loops, if statements, and while loops. However, enforcing the use of control braces throughout your codebase will make the code more consistent and can make it easier to add statements in the future.
Comment on lines
+81
to
+85
| protected KafkaDecorator(String spanKind, CharSequence spanType, String serviceName) { | ||
| this.spanKind = spanKind; | ||
| this.spanType = spanType; | ||
| this.serviceName = serviceName; | ||
| } |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider adding super() or this() to your constructor (...read more)
In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (this == o) return true; | |
| if (this == o) {return true}; |
single if statement should be wrapped in a brace (...read more)
Omitting braces {} is valid in multiple statements, such as, for loops, if statements, and while loops. However, enforcing the use of control braces throughout your codebase will make the code more consistent and can make it easier to add statements in the future.
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (o == null || getClass() != o.getClass()) return false; | |
| if (o == null || getClass() != o.getClass()) {return false}; |
single if statement should be wrapped in a brace (...read more)
Omitting braces {} is valid in multiple statements, such as, for loops, if statements, and while loops. However, enforcing the use of control braces throughout your codebase will make the code more consistent and can make it easier to add statements in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]