Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency with thread locals in jersey IAST instrumentation #7619

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Remove dependency with thread locals in jersey IAST instrumentation #7619

merged 2 commits into from
Sep 17, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Sep 13, 2024 •
edited
Loading

What Does This Do

Removes thread locals from the IAST jersey instrumentation, it also introduces unit tests which where missing from this particular instrumentations.

Motivation

Some of the jersey tests started to flake in CI due to the randomness introduced by the thread local.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: refactoring comp: asm iast Application Security Management (IAST) labels Sep 13, 2024
@Mariovido
Copy link
Contributor

LGTM

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-improve-jersey-instrumentation branch from af8a07e to a311e59 Compare September 13, 2024 12:14
@pr-commenter
Copy link

pr-commenter bot commented Sep 13, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-improve-jersey-instrumentation
git_commit_date 1726504555 1726559410
git_commit_sha a369f7b 2758d2b
release_version 1.40.0-SNAPSHOT~a369f7b401 1.40.0-SNAPSHOT~2758d2bd99
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726561807 1726561807
ci_job_id 641666268 641666268
ci_pipeline_id 44478434 44478434
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 48 metrics, 14 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:AppSec worse
[+1.827ms; +6.381ms] or [+3.435%; +12.000%]		 57.280ms 53.176ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~2758d2bd99, baseline=1.40.0-SNAPSHOT~a369f7b401

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066723
Total [baseline] (8.57 s) : 0, 8569578
Agent [candidate] (1.065 s) : 0, 1064826
Total [candidate] (8.552 s) : 0, 8551560
section iast
Agent [baseline] (1.201 s) : 0, 1201263
Total [baseline] (9.057 s) : 0, 9056873
Agent [candidate] (1.192 s) : 0, 1192050
Total [candidate] (9.045 s) : 0, 9045183
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.196 s) : 0, 1195894
Total [baseline] (9.001 s) : 0, 9001188
Agent [candidate] (1.193 s) : 0, 1192694
Total [candidate] (8.987 s) : 0, 8987486
section iast_TELEMETRY_OFF
Agent [baseline] (1.192 s) : 0, 1192098
Total [baseline] (9.009 s) : 0, 9008957
Agent [candidate] (1.201 s) : 0, 1200538
Total [candidate] (9.026 s) : 0, 9025888
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.201 s 134.54 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.196 s 129.17 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.192 s 125.374 ms (11.8%)
Total tracing 8.57 s -
Total iast 9.057 s 487.295 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.001 s 431.61 ms (5.0%)
Total iast_TELEMETRY_OFF 9.009 s 439.379 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.192 s 127.225 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.193 s 127.868 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.201 s 135.712 ms (12.7%)
Total tracing 8.552 s -
Total iast 9.045 s 493.624 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.987 s 435.926 ms (5.1%)
Total iast_TELEMETRY_OFF 9.026 s 474.328 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~2758d2bd99, baseline=1.40.0-SNAPSHOT~a369f7b401

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.912 ms) : 0, 679912
BytebuddyAgent [candidate] (679.818 ms) : 0, 679818
GlobalTracer [baseline] (312.085 ms) : 0, 312085
GlobalTracer [candidate] (310.719 ms) : 0, 310719
AppSec [baseline] (52.832 ms) : 0, 52832
AppSec [candidate] (52.429 ms) : 0, 52429
Remote Config [baseline] (674.044 µs) : 0, 674
Remote Config [candidate] (669.182 µs) : 0, 669
Telemetry [baseline] (7.513 ms) : 0, 7513
Telemetry [candidate] (7.495 ms) : 0, 7495
section iast
BytebuddyAgent [baseline] (799.62 ms) : 0, 799620
BytebuddyAgent [candidate] (793.103 ms) : 0, 793103
GlobalTracer [baseline] (301.005 ms) : 0, 301005
GlobalTracer [candidate] (299.3 ms) : 0, 299300
AppSec [baseline] (51.352 ms) : 0, 51352
AppSec [candidate] (53.134 ms) : 0, 53134
IAST [baseline] (27.382 ms) : 0, 27382
IAST [candidate] (23.841 ms) : 0, 23841
Remote Config [baseline] (618.942 µs) : 0, 619
Remote Config [candidate] (628.04 µs) : 0, 628
Telemetry [baseline] (7.428 ms) : 0, 7428
Telemetry [candidate] (8.269 ms) : 0, 8269
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.959 ms) : 0, 795959
BytebuddyAgent [candidate] (794.103 ms) : 0, 794103
GlobalTracer [baseline] (300.103 ms) : 0, 300103
GlobalTracer [candidate] (299.327 ms) : 0, 299327
AppSec [baseline] (53.176 ms) : 0, 53176
AppSec [candidate] (57.28 ms) : 0, 57280
IAST [baseline] (24.731 ms) : 0, 24731
IAST [candidate] (20.254 ms) : 0, 20254
Remote Config [baseline] (651.718 µs) : 0, 652
Remote Config [candidate] (610.366 µs) : 0, 610
Telemetry [baseline] (7.446 ms) : 0, 7446
Telemetry [candidate] (7.387 ms) : 0, 7387
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.415 ms) : 0, 791415
BytebuddyAgent [candidate] (797.531 ms) : 0, 797531
GlobalTracer [baseline] (301.768 ms) : 0, 301768
GlobalTracer [candidate] (302.611 ms) : 0, 302611
AppSec [baseline] (54.872 ms) : 0, 54872
AppSec [candidate] (55.592 ms) : 0, 55592
IAST [baseline] (22.464 ms) : 0, 22464
IAST [candidate] (22.869 ms) : 0, 22869
Remote Config [baseline] (619.048 µs) : 0, 619
Remote Config [candidate] (628.895 µs) : 0, 629
Telemetry [baseline] (7.199 ms) : 0, 7199
Telemetry [candidate] (7.432 ms) : 0, 7432
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~2758d2bd99, baseline=1.40.0-SNAPSHOT~a369f7b401

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074706
Total [baseline] (10.372 s) : 0, 10372219
Agent [candidate] (1.074 s) : 0, 1074088
Total [candidate] (10.384 s) : 0, 10384299
section appsec
Agent [baseline] (1.208 s) : 0, 1207556
Total [baseline] (10.675 s) : 0, 10675119
Agent [candidate] (1.209 s) : 0, 1209444
Total [candidate] (10.674 s) : 0, 10674417
section iast
Agent [baseline] (1.201 s) : 0, 1200854
Total [baseline] (10.854 s) : 0, 10854421
Agent [candidate] (1.194 s) : 0, 1194472
Total [candidate] (10.852 s) : 0, 10851682
section profiling
Agent [baseline] (1.265 s) : 0, 1264750
Total [baseline] (10.638 s) : 0, 10637865
Agent [candidate] (1.265 s) : 0, 1264889
Total [candidate] (10.62 s) : 0, 10619758
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.208 s 132.85 ms (12.4%)
Agent iast 1.201 s 126.148 ms (11.7%)
Agent profiling 1.265 s 190.045 ms (17.7%)
Total tracing 10.372 s -
Total appsec 10.675 s 302.9 ms (2.9%)
Total iast 10.854 s 482.201 ms (4.6%)
Total profiling 10.638 s 265.646 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent appsec 1.209 s 135.356 ms (12.6%)
Agent iast 1.194 s 120.384 ms (11.2%)
Agent profiling 1.265 s 190.8 ms (17.8%)
Total tracing 10.384 s -
Total appsec 10.674 s 290.117 ms (2.8%)
Total iast 10.852 s 467.382 ms (4.5%)
Total profiling 10.62 s 235.458 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~2758d2bd99, baseline=1.40.0-SNAPSHOT~a369f7b401

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.748 ms) : 0, 685748
BytebuddyAgent [candidate] (685.671 ms) : 0, 685671
GlobalTracer [baseline] (313.745 ms) : 0, 313745
GlobalTracer [candidate] (312.96 ms) : 0, 312960
AppSec [baseline] (53.201 ms) : 0, 53201
AppSec [candidate] (53.317 ms) : 0, 53317
Remote Config [baseline] (669.336 µs) : 0, 669
Remote Config [candidate] (684.363 µs) : 0, 684
Telemetry [baseline] (7.559 ms) : 0, 7559
Telemetry [candidate] (7.63 ms) : 0, 7630
section appsec
BytebuddyAgent [baseline] (706.256 ms) : 0, 706256
BytebuddyAgent [candidate] (708.273 ms) : 0, 708273
GlobalTracer [baseline] (305.463 ms) : 0, 305463
GlobalTracer [candidate] (305.919 ms) : 0, 305919
AppSec [baseline] (161.978 ms) : 0, 161978
AppSec [candidate] (161.623 ms) : 0, 161623
Remote Config [baseline] (660.626 µs) : 0, 661
Remote Config [candidate] (979.894 µs) : 0, 980
Telemetry [baseline] (8.385 ms) : 0, 8385
Telemetry [candidate] (9.195 ms) : 0, 9195
IAST [baseline] (22.198 ms) : 0, 22198
IAST [candidate] (19.366 ms) : 0, 19366
section iast
BytebuddyAgent [baseline] (800.187 ms) : 0, 800187
BytebuddyAgent [candidate] (795.067 ms) : 0, 795067
GlobalTracer [baseline] (301.351 ms) : 0, 301351
GlobalTracer [candidate] (299.976 ms) : 0, 299976
AppSec [baseline] (55.317 ms) : 0, 55317
AppSec [candidate] (54.79 ms) : 0, 54790
Remote Config [baseline] (643.117 µs) : 0, 643
Remote Config [candidate] (614.625 µs) : 0, 615
Telemetry [baseline] (7.396 ms) : 0, 7396
Telemetry [candidate] (7.386 ms) : 0, 7386
IAST [baseline] (22.142 ms) : 0, 22142
IAST [candidate] (22.92 ms) : 0, 22920
section profiling
BytebuddyAgent [baseline] (674.321 ms) : 0, 674321
BytebuddyAgent [candidate] (673.679 ms) : 0, 673679
GlobalTracer [baseline] (393.982 ms) : 0, 393982
GlobalTracer [candidate] (394.458 ms) : 0, 394458
AppSec [baseline] (53.352 ms) : 0, 53352
AppSec [candidate] (53.252 ms) : 0, 53252
Remote Config [baseline] (665.872 µs) : 0, 666
Remote Config [candidate] (682.382 µs) : 0, 682
Telemetry [baseline] (7.499 ms) : 0, 7499
Telemetry [candidate] (7.419 ms) : 0, 7419
ProfilingAgent [baseline] (96.798 ms) : 0, 96798
ProfilingAgent [candidate] (97.186 ms) : 0, 97186
Profiling [baseline] (96.822 ms) : 0, 96822
Profiling [candidate] (97.21 ms) : 0, 97210
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-17T08:02:56 2024-09-17T08:09:48
git_branch master malvarez/iast-improve-jersey-instrumentation
git_commit_date 1726504555 1726559410
git_commit_sha a369f7b 2758d2b
release_version 1.40.0-SNAPSHOT~a369f7b401 1.40.0-SNAPSHOT~2758d2bd99
start_time 2024-09-17T08:02:42 2024-09-17T08:09:35
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726560935 1726560935
ci_job_id 641666269 641666269
ci_pipeline_id 44478434 44478434
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~2758d2bd99, baseline=1.40.0-SNAPSHOT~a369f7b401
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.524 µs) : 351, 394
.   : milestone, 373,
iast (486.197 µs) : 465, 507
.   : milestone, 486,
iast_FULL (551.176 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (511.95 µs) : 489, 535
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (482.096 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (450.362 µs) : 429, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (480.236 µs) : 457, 503
.   : milestone, 480,
tracing (442.806 µs) : 422, 463
.   : milestone, 443,
section candidate
no_agent (370.683 µs) : 351, 390
.   : milestone, 371,
iast (479.474 µs) : 458, 501
.   : milestone, 479,
iast_FULL (551.274 µs) : 530, 573
.   : milestone, 551,
iast_GLOBAL (503.748 µs) : 483, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (480.136 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (446.936 µs) : 426, 467
.   : milestone, 447,
iast_TELEMETRY_OFF (478.664 µs) : 456, 502
.   : milestone, 479,
tracing (447.241 µs) : 426, 468
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.524 µs [351.296 µs, 393.751 µs] -
iast 486.197 µs [465.385 µs, 507.009 µs] 113.674 µs (30.5%)
iast_FULL 551.176 µs [529.97 µs, 572.382 µs] 178.653 µs (48.0%)
iast_GLOBAL 511.95 µs [489.042 µs, 534.858 µs] 139.426 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED 482.096 µs [461.092 µs, 503.1 µs] 109.573 µs (29.4%)
iast_INACTIVE 450.362 µs [428.648 µs, 472.075 µs] 77.838 µs (20.9%)
iast_TELEMETRY_OFF 480.236 µs [457.336 µs, 503.136 µs] 107.712 µs (28.9%)
tracing 442.806 µs [422.356 µs, 463.255 µs] 70.282 µs (18.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.683 µs [351.012 µs, 390.354 µs] -
iast 479.474 µs [458.084 µs, 500.864 µs] 108.791 µs (29.3%)
iast_FULL 551.274 µs [529.756 µs, 572.793 µs] 180.591 µs (48.7%)
iast_GLOBAL 503.748 µs [482.734 µs, 524.762 µs] 133.065 µs (35.9%)
iast_HARDCODED_SECRET_DISABLED 480.136 µs [459.242 µs, 501.03 µs] 109.453 µs (29.5%)
iast_INACTIVE 446.936 µs [426.419 µs, 467.453 µs] 76.253 µs (20.6%)
iast_TELEMETRY_OFF 478.664 µs [455.607 µs, 501.721 µs] 107.981 µs (29.1%)
tracing 447.241 µs [426.44 µs, 468.043 µs] 76.558 µs (20.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~2758d2bd99, baseline=1.40.0-SNAPSHOT~a369f7b401
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1329, 1370
.   : milestone, 1350,
appsec (1.729 ms) : 1705, 1753
.   : milestone, 1729,
appsec_no_iast (1.713 ms) : 1689, 1737
.   : milestone, 1713,
iast (1.476 ms) : 1453, 1500
.   : milestone, 1476,
profiling (1.516 ms) : 1492, 1541
.   : milestone, 1516,
tracing (1.453 ms) : 1429, 1477
.   : milestone, 1453,
section candidate
no_agent (1.336 ms) : 1316, 1355
.   : milestone, 1336,
appsec (1.726 ms) : 1702, 1750
.   : milestone, 1726,
appsec_no_iast (1.696 ms) : 1671, 1721
.   : milestone, 1696,
iast (1.466 ms) : 1444, 1489
.   : milestone, 1466,
profiling (1.516 ms) : 1492, 1540
.   : milestone, 1516,
tracing (1.477 ms) : 1453, 1502
.   : milestone, 1477,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.329 ms, 1.37 ms] -
appsec 1.729 ms [1.705 ms, 1.753 ms] 379.896 µs (28.2%)
appsec_no_iast 1.713 ms [1.689 ms, 1.737 ms] 363.369 µs (26.9%)
iast 1.476 ms [1.453 ms, 1.5 ms] 126.981 µs (9.4%)
profiling 1.516 ms [1.492 ms, 1.541 ms] 166.852 µs (12.4%)
tracing 1.453 ms [1.429 ms, 1.477 ms] 103.397 µs (7.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.316 ms, 1.355 ms] -
appsec 1.726 ms [1.702 ms, 1.75 ms] 390.592 µs (29.2%)
appsec_no_iast 1.696 ms [1.671 ms, 1.721 ms] 360.204 µs (27.0%)
iast 1.466 ms [1.444 ms, 1.489 ms] 130.373 µs (9.8%)
profiling 1.516 ms [1.492 ms, 1.54 ms] 180.154 µs (13.5%)
tracing 1.477 ms [1.453 ms, 1.502 ms] 141.59 µs (10.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-improve-jersey-instrumentation
git_commit_date 1726504555 1726559410
git_commit_sha a369f7b 2758d2b
release_version 1.40.0-SNAPSHOT~a369f7b401 1.40.0-SNAPSHOT~2758d2bd99
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726561468 1726561468
ci_job_id 641666270 641666270
ci_pipeline_id 44478434 44478434
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~2758d2bd99, baseline=1.40.0-SNAPSHOT~a369f7b401
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.289 ms) : 2248, 2330
.   : milestone, 2289,
iast (2.049 ms) : 1998, 2099
.   : milestone, 2049,
iast_GLOBAL (2.087 ms) : 2037, 2138
.   : milestone, 2087,
profiling (1.913 ms) : 1872, 1953
.   : milestone, 1913,
tracing (1.896 ms) : 1858, 1934
.   : milestone, 1896,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.281 ms) : 2240, 2322
.   : milestone, 2281,
iast (2.051 ms) : 2000, 2102
.   : milestone, 2051,
iast_GLOBAL (2.09 ms) : 2039, 2141
.   : milestone, 2090,
profiling (1.919 ms) : 1879, 1959
.   : milestone, 1919,
tracing (1.888 ms) : 1850, 1925
.   : milestone, 1888,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.289 ms [2.248 ms, 2.33 ms] 822.665 µs (56.1%)
iast 2.049 ms [1.998 ms, 2.099 ms] 582.605 µs (39.7%)
iast_GLOBAL 2.087 ms [2.037 ms, 2.138 ms] 621.276 µs (42.4%)
profiling 1.913 ms [1.872 ms, 1.953 ms] 446.494 µs (30.5%)
tracing 1.896 ms [1.858 ms, 1.934 ms] 429.728 µs (29.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.281 ms [2.24 ms, 2.322 ms] 814.769 µs (55.6%)
iast 2.051 ms [2.0 ms, 2.102 ms] 584.548 µs (39.9%)
iast_GLOBAL 2.09 ms [2.039 ms, 2.141 ms] 623.402 µs (42.5%)
profiling 1.919 ms [1.879 ms, 1.959 ms] 452.854 µs (30.9%)
tracing 1.888 ms [1.85 ms, 1.925 ms] 421.413 µs (28.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~2758d2bd99, baseline=1.40.0-SNAPSHOT~a369f7b401
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.289 s) : 15289000, 15289000
.   : milestone, 15289000,
appsec (14.985 s) : 14985000, 14985000
.   : milestone, 14985000,
iast (19.119 s) : 19119000, 19119000
.   : milestone, 19119000,
iast_GLOBAL (18.075 s) : 18075000, 18075000
.   : milestone, 18075000,
profiling (15.575 s) : 15575000, 15575000
.   : milestone, 15575000,
tracing (15.225 s) : 15225000, 15225000
.   : milestone, 15225000,
section candidate
no_agent (15.092 s) : 15092000, 15092000
.   : milestone, 15092000,
appsec (15.127 s) : 15127000, 15127000
.   : milestone, 15127000,
iast (18.957 s) : 18957000, 18957000
.   : milestone, 18957000,
iast_GLOBAL (17.831 s) : 17831000, 17831000
.   : milestone, 17831000,
profiling (15.992 s) : 15992000, 15992000
.   : milestone, 15992000,
tracing (15.082 s) : 15082000, 15082000
.   : milestone, 15082000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.289 s [15.289 s, 15.289 s] -
appsec 14.985 s [14.985 s, 14.985 s] -304.0 ms (-2.0%)
iast 19.119 s [19.119 s, 19.119 s] 3.83 s (25.1%)
iast_GLOBAL 18.075 s [18.075 s, 18.075 s] 2.786 s (18.2%)
profiling 15.575 s [15.575 s, 15.575 s] 286.0 ms (1.9%)
tracing 15.225 s [15.225 s, 15.225 s] -64.0 ms (-0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.092 s [15.092 s, 15.092 s] -
appsec 15.127 s [15.127 s, 15.127 s] 35.0 ms (0.2%)
iast 18.957 s [18.957 s, 18.957 s] 3.865 s (25.6%)
iast_GLOBAL 17.831 s [17.831 s, 17.831 s] 2.739 s (18.1%)
profiling 15.992 s [15.992 s, 15.992 s] 900.0 ms (6.0%)
tracing 15.082 s [15.082 s, 15.082 s] -10.0 ms (-0.1%)

@amarziali
Copy link
Collaborator

On of the jersey related system test seems failing. Is it due to the change of behviour introduced by this PR?

@manuel-alvarez-alvarez
Copy link
Member Author

On of the jersey related system test seems failing. Is it due to the change of behviour introduced by this PR?

Yes, most likely is due to this PR, I'm currently having a look, thanks for pointing it out 😄

@manuel-alvarez-alvarez
Copy link
Member Author

On of the jersey related system test seems failing. Is it due to the change of behviour introduced by this PR?

It's fixed with the last commit 😄

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-improve-jersey-instrumentation branch from ecde2b8 to 3512017 Compare September 16, 2024 07:28
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-improve-jersey-instrumentation branch from 3512017 to 2758d2b Compare September 17, 2024 07:50
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 51ac6c4 into master Sep 17, 2024
102 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-improve-jersey-instrumentation branch September 17, 2024 08:35
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@amarziali amarziali amarziali approved these changes

@Mariovido Mariovido Mariovido approved these changes

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) type: refactoring
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manuel-alvarez-alvarez @Mariovido @amarziali @smola