Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve BUILDING documentation, and fix typo in setup script #7618

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Improve BUILDING documentation, and fix typo in setup script #7618

merged 3 commits into from
Sep 27, 2024

Conversation

jordan-wong
Copy link
Contributor

@jordan-wong jordan-wong commented Sep 13, 2024 •
edited
Loading

What Does This Do

Small improvements to setup script and building documentation

Motivation

Development quick check

Showing quick check ./setup.sh first can be confusing

  • First part of quick check assumes that you have cloned the repo already to run ./setup.sh
  • so people will try to clone the repo after seeing this part first
  • but then you find out that you cloned the repo wrong by not doing --recurse-submodules

However I do like the fact that by showing the output first, we are giving a short summary in the beginning for readers, so I thought not to change order of showing setup.sh first, but instead change wording

Building troubleshooting

  • based on my issues with build I thought it might be useful have a reference to skip tests on local build just in case for flaky tests. Not sure if this is necessary or wording is right

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jordan-wong jordan-wong requested a review from a team as a code owner September 13, 2024 11:35
@pr-commenter
Copy link

pr-commenter bot commented Sep 13, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master documentation_improvements
git_commit_date 1727189655 1727269609
git_commit_sha 043adb2 72f50e2
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~72f50e28d6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727272097 1727272097
ci_job_id 651167415 651167415
ci_pipeline_id 45110752 45110752
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~72f50e28d6, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063532
Total [baseline] (10.413 s) : 0, 10413436
Agent [candidate] (1.071 s) : 0, 1071129
Total [candidate] (10.357 s) : 0, 10357398
section appsec
Agent [baseline] (1.198 s) : 0, 1197535
Total [baseline] (10.615 s) : 0, 10614909
Agent [candidate] (1.198 s) : 0, 1198350
Total [candidate] (10.597 s) : 0, 10596636
section iast
Agent [baseline] (1.189 s) : 0, 1189485
Total [baseline] (10.839 s) : 0, 10839379
Agent [candidate] (1.192 s) : 0, 1191514
Total [candidate] (10.794 s) : 0, 10794262
section profiling
Agent [baseline] (1.265 s) : 0, 1264788
Total [baseline] (10.603 s) : 0, 10602811
Agent [candidate] (1.272 s) : 0, 1272038
Total [candidate] (10.605 s) : 0, 10604925
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.198 s 134.003 ms (12.6%)
Agent iast 1.189 s 125.953 ms (11.8%)
Agent profiling 1.265 s 201.256 ms (18.9%)
Total tracing 10.413 s -
Total appsec 10.615 s 201.473 ms (1.9%)
Total iast 10.839 s 425.943 ms (4.1%)
Total profiling 10.603 s 189.375 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.198 s 127.221 ms (11.9%)
Agent iast 1.192 s 120.385 ms (11.2%)
Agent profiling 1.272 s 200.908 ms (18.8%)
Total tracing 10.357 s -
Total appsec 10.597 s 239.238 ms (2.3%)
Total iast 10.794 s 436.864 ms (4.2%)
Total profiling 10.605 s 247.527 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~72f50e28d6, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.211 ms) : 0, 679211
BytebuddyAgent [candidate] (684.004 ms) : 0, 684004
GlobalTracer [baseline] (308.952 ms) : 0, 308952
GlobalTracer [candidate] (311.158 ms) : 0, 311158
AppSec [baseline] (53.558 ms) : 0, 53558
AppSec [candidate] (54.007 ms) : 0, 54007
Remote Config [baseline] (659.051 µs) : 0, 659
Remote Config [candidate] (659.748 µs) : 0, 660
Telemetry [baseline] (7.614 ms) : 0, 7614
Telemetry [candidate] (7.65 ms) : 0, 7650
section appsec
BytebuddyAgent [baseline] (700.212 ms) : 0, 700212
BytebuddyAgent [candidate] (700.207 ms) : 0, 700207
GlobalTracer [baseline] (302.492 ms) : 0, 302492
GlobalTracer [candidate] (301.99 ms) : 0, 301990
AppSec [baseline] (163.022 ms) : 0, 163022
AppSec [candidate] (162.967 ms) : 0, 162967
Remote Config [baseline] (644.711 µs) : 0, 645
Remote Config [candidate] (643.447 µs) : 0, 643
Telemetry [baseline] (7.79 ms) : 0, 7790
Telemetry [candidate] (8.775 ms) : 0, 8775
IAST [baseline] (19.619 ms) : 0, 19619
IAST [candidate] (20.412 ms) : 0, 20412
section iast
BytebuddyAgent [baseline] (791.602 ms) : 0, 791602
BytebuddyAgent [candidate] (792.878 ms) : 0, 792878
GlobalTracer [baseline] (298.254 ms) : 0, 298254
GlobalTracer [candidate] (298.802 ms) : 0, 298802
AppSec [baseline] (52.327 ms) : 0, 52327
AppSec [candidate] (53.907 ms) : 0, 53907
Remote Config [baseline] (613.363 µs) : 0, 613
Remote Config [candidate] (607.521 µs) : 0, 608
Telemetry [baseline] (6.988 ms) : 0, 6988
Telemetry [candidate] (7.82 ms) : 0, 7820
IAST [baseline] (26.078 ms) : 0, 26078
IAST [candidate] (23.852 ms) : 0, 23852
section profiling
BytebuddyAgent [baseline] (674.403 ms) : 0, 674403
BytebuddyAgent [candidate] (678.054 ms) : 0, 678054
GlobalTracer [baseline] (392.999 ms) : 0, 392999
GlobalTracer [candidate] (395.616 ms) : 0, 395616
AppSec [baseline] (54.625 ms) : 0, 54625
AppSec [candidate] (54.748 ms) : 0, 54748
Remote Config [baseline] (651.386 µs) : 0, 651
Remote Config [candidate] (655.837 µs) : 0, 656
Telemetry [baseline] (7.423 ms) : 0, 7423
Telemetry [candidate] (7.478 ms) : 0, 7478
ProfilingAgent [baseline] (96.185 ms) : 0, 96185
ProfilingAgent [candidate] (96.759 ms) : 0, 96759
Profiling [baseline] (96.209 ms) : 0, 96209
Profiling [candidate] (96.782 ms) : 0, 96782
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~72f50e28d6, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067534
Total [baseline] (8.527 s) : 0, 8527140
Agent [candidate] (1.065 s) : 0, 1064735
Total [candidate] (8.551 s) : 0, 8551047
section iast
Agent [baseline] (1.198 s) : 0, 1197996
Total [baseline] (9.022 s) : 0, 9021602
Agent [candidate] (1.186 s) : 0, 1185510
Total [candidate] (8.98 s) : 0, 8980189
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184655
Total [baseline] (8.943 s) : 0, 8943404
Agent [candidate] (1.188 s) : 0, 1188203
Total [candidate] (8.993 s) : 0, 8992504
section iast_TELEMETRY_OFF
Agent [baseline] (1.187 s) : 0, 1186969
Total [baseline] (8.973 s) : 0, 8972676
Agent [candidate] (1.186 s) : 0, 1186304
Total [candidate] (8.98 s) : 0, 8979663
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent iast 1.198 s 130.462 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 117.121 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.187 s 119.435 ms (11.2%)
Total tracing 8.527 s -
Total iast 9.022 s 494.462 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.943 s 416.264 ms (4.9%)
Total iast_TELEMETRY_OFF 8.973 s 445.536 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.186 s 120.775 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.188 s 123.468 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.186 s 121.569 ms (11.4%)
Total tracing 8.551 s -
Total iast 8.98 s 429.142 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.993 s 441.457 ms (5.2%)
Total iast_TELEMETRY_OFF 8.98 s 428.616 ms (5.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~72f50e28d6, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.815 ms) : 0, 680815
BytebuddyAgent [candidate] (679.759 ms) : 0, 679759
GlobalTracer [baseline] (310.929 ms) : 0, 310929
GlobalTracer [candidate] (309.316 ms) : 0, 309316
AppSec [baseline] (53.986 ms) : 0, 53986
AppSec [candidate] (53.731 ms) : 0, 53731
Remote Config [baseline] (657.008 µs) : 0, 657
Remote Config [candidate] (671.885 µs) : 0, 672
Telemetry [baseline] (7.56 ms) : 0, 7560
Telemetry [candidate] (7.637 ms) : 0, 7637
section iast
BytebuddyAgent [baseline] (798.788 ms) : 0, 798788
BytebuddyAgent [candidate] (788.957 ms) : 0, 788957
GlobalTracer [baseline] (300.604 ms) : 0, 300604
GlobalTracer [candidate] (297.278 ms) : 0, 297278
AppSec [baseline] (53.714 ms) : 0, 53714
AppSec [candidate] (53.737 ms) : 0, 53737
IAST [baseline] (23.608 ms) : 0, 23608
IAST [candidate] (24.347 ms) : 0, 24347
Remote Config [baseline] (588.614 µs) : 0, 589
Remote Config [candidate] (633.234 µs) : 0, 633
Telemetry [baseline] (6.956 ms) : 0, 6956
Telemetry [candidate] (6.958 ms) : 0, 6958
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.969 ms) : 0, 788969
BytebuddyAgent [candidate] (790.794 ms) : 0, 790794
GlobalTracer [baseline] (296.95 ms) : 0, 296950
GlobalTracer [candidate] (298.065 ms) : 0, 298065
AppSec [baseline] (55.671 ms) : 0, 55671
AppSec [candidate] (54.501 ms) : 0, 54501
IAST [baseline] (21.856 ms) : 0, 21856
IAST [candidate] (22.8 ms) : 0, 22800
Remote Config [baseline] (608.971 µs) : 0, 609
Remote Config [candidate] (612.755 µs) : 0, 613
Telemetry [baseline] (7.028 ms) : 0, 7028
Telemetry [candidate] (7.808 ms) : 0, 7808
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (788.852 ms) : 0, 788852
BytebuddyAgent [candidate] (788.405 ms) : 0, 788405
GlobalTracer [baseline] (298.73 ms) : 0, 298730
GlobalTracer [candidate] (298.971 ms) : 0, 298971
AppSec [baseline] (53.62 ms) : 0, 53620
AppSec [candidate] (56.433 ms) : 0, 56433
IAST [baseline] (23.102 ms) : 0, 23102
IAST [candidate] (21.397 ms) : 0, 21397
Remote Config [baseline] (2.13 ms) : 0, 2130
Remote Config [candidate] (605.043 µs) : 0, 605
Telemetry [baseline] (6.9 ms) : 0, 6900
Telemetry [candidate] (6.825 ms) : 0, 6825
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-25T13:18:57 2024-09-25T13:25:53
git_branch master documentation_improvements
git_commit_date 1727189655 1727269609
git_commit_sha 043adb2 72f50e2
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~72f50e28d6
start_time 2024-09-25T13:18:44 2024-09-25T13:25:39
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727271102 1727271102
ci_job_id 651167416 651167416
ci_pipeline_id 45110752 45110752
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~72f50e28d6, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.613 µs) : 358, 401
.   : milestone, 380,
iast (490.177 µs) : 469, 512
.   : milestone, 490,
iast_FULL (558.621 µs) : 537, 580
.   : milestone, 559,
iast_GLOBAL (508.484 µs) : 487, 530
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (499.283 µs) : 478, 521
.   : milestone, 499,
iast_INACTIVE (454.842 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (481.708 µs) : 459, 505
.   : milestone, 482,
tracing (453.433 µs) : 431, 476
.   : milestone, 453,
section candidate
no_agent (382.539 µs) : 363, 402
.   : milestone, 383,
iast (501.978 µs) : 481, 523
.   : milestone, 502,
iast_FULL (559.801 µs) : 539, 581
.   : milestone, 560,
iast_GLOBAL (516.722 µs) : 495, 539
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (495.006 µs) : 473, 517
.   : milestone, 495,
iast_INACTIVE (451.174 µs) : 431, 471
.   : milestone, 451,
iast_TELEMETRY_OFF (481.081 µs) : 458, 504
.   : milestone, 481,
tracing (450.963 µs) : 430, 472
.   : milestone, 451,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.613 µs [358.294 µs, 400.932 µs] -
iast 490.177 µs [468.675 µs, 511.678 µs] 110.564 µs (29.1%)
iast_FULL 558.621 µs [537.047 µs, 580.195 µs] 179.008 µs (47.2%)
iast_GLOBAL 508.484 µs [487.349 µs, 529.619 µs] 128.871 µs (33.9%)
iast_HARDCODED_SECRET_DISABLED 499.283 µs [477.717 µs, 520.849 µs] 119.671 µs (31.5%)
iast_INACTIVE 454.842 µs [433.891 µs, 475.794 µs] 75.23 µs (19.8%)
iast_TELEMETRY_OFF 481.708 µs [458.827 µs, 504.59 µs] 102.096 µs (26.9%)
tracing 453.433 µs [431.018 µs, 475.847 µs] 73.82 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.539 µs [363.11 µs, 401.968 µs] -
iast 501.978 µs [480.541 µs, 523.415 µs] 119.439 µs (31.2%)
iast_FULL 559.801 µs [538.593 µs, 581.009 µs] 177.262 µs (46.3%)
iast_GLOBAL 516.722 µs [494.913 µs, 538.531 µs] 134.183 µs (35.1%)
iast_HARDCODED_SECRET_DISABLED 495.006 µs [473.463 µs, 516.55 µs] 112.467 µs (29.4%)
iast_INACTIVE 451.174 µs [430.904 µs, 471.444 µs] 68.635 µs (17.9%)
iast_TELEMETRY_OFF 481.081 µs [458.368 µs, 503.793 µs] 98.541 µs (25.8%)
tracing 450.963 µs [429.822 µs, 472.103 µs] 68.423 µs (17.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~72f50e28d6, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1336, 1375
.   : milestone, 1355,
appsec (1.734 ms) : 1711, 1756
.   : milestone, 1734,
appsec_no_iast (1.74 ms) : 1716, 1764
.   : milestone, 1740,
iast (1.471 ms) : 1448, 1493
.   : milestone, 1471,
profiling (1.49 ms) : 1466, 1515
.   : milestone, 1490,
tracing (1.496 ms) : 1472, 1520
.   : milestone, 1496,
section candidate
no_agent (1.36 ms) : 1340, 1380
.   : milestone, 1360,
appsec (1.731 ms) : 1707, 1755
.   : milestone, 1731,
appsec_no_iast (1.732 ms) : 1708, 1756
.   : milestone, 1732,
iast (1.48 ms) : 1457, 1503
.   : milestone, 1480,
profiling (1.507 ms) : 1482, 1533
.   : milestone, 1507,
tracing (1.498 ms) : 1474, 1521
.   : milestone, 1498,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.375 ms] -
appsec 1.734 ms [1.711 ms, 1.756 ms] 378.052 µs (27.9%)
appsec_no_iast 1.74 ms [1.716 ms, 1.764 ms] 384.936 µs (28.4%)
iast 1.471 ms [1.448 ms, 1.493 ms] 115.022 µs (8.5%)
profiling 1.49 ms [1.466 ms, 1.515 ms] 134.743 µs (9.9%)
tracing 1.496 ms [1.472 ms, 1.52 ms] 140.222 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.38 ms] -
appsec 1.731 ms [1.707 ms, 1.755 ms] 370.808 µs (27.3%)
appsec_no_iast 1.732 ms [1.708 ms, 1.756 ms] 371.97 µs (27.4%)
iast 1.48 ms [1.457 ms, 1.503 ms] 119.994 µs (8.8%)
profiling 1.507 ms [1.482 ms, 1.533 ms] 147.468 µs (10.8%)
tracing 1.498 ms [1.474 ms, 1.521 ms] 137.676 µs (10.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master documentation_improvements
git_commit_date 1727189655 1727269609
git_commit_sha 043adb2 72f50e2
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~72f50e28d6
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727271498 1727271498
ci_job_id 651167417 651167417
ci_pipeline_id 45110752 45110752
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~72f50e28d6, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.784 s) : 14784000, 14784000
.   : milestone, 14784000,
appsec (15.281 s) : 15281000, 15281000
.   : milestone, 15281000,
iast (19.161 s) : 19161000, 19161000
.   : milestone, 19161000,
iast_GLOBAL (18.189 s) : 18189000, 18189000
.   : milestone, 18189000,
profiling (15.306 s) : 15306000, 15306000
.   : milestone, 15306000,
tracing (15.2 s) : 15200000, 15200000
.   : milestone, 15200000,
section candidate
no_agent (15.641 s) : 15641000, 15641000
.   : milestone, 15641000,
appsec (15.187 s) : 15187000, 15187000
.   : milestone, 15187000,
iast (18.875 s) : 18875000, 18875000
.   : milestone, 18875000,
iast_GLOBAL (18.275 s) : 18275000, 18275000
.   : milestone, 18275000,
profiling (15.536 s) : 15536000, 15536000
.   : milestone, 15536000,
tracing (15.463 s) : 15463000, 15463000
.   : milestone, 15463000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.784 s [14.784 s, 14.784 s] -
appsec 15.281 s [15.281 s, 15.281 s] 497.0 ms (3.4%)
iast 19.161 s [19.161 s, 19.161 s] 4.377 s (29.6%)
iast_GLOBAL 18.189 s [18.189 s, 18.189 s] 3.405 s (23.0%)
profiling 15.306 s [15.306 s, 15.306 s] 522.0 ms (3.5%)
tracing 15.2 s [15.2 s, 15.2 s] 416.0 ms (2.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.641 s [15.641 s, 15.641 s] -
appsec 15.187 s [15.187 s, 15.187 s] -454.0 ms (-2.9%)
iast 18.875 s [18.875 s, 18.875 s] 3.234 s (20.7%)
iast_GLOBAL 18.275 s [18.275 s, 18.275 s] 2.634 s (16.8%)
profiling 15.536 s [15.536 s, 15.536 s] -105.0 ms (-0.7%)
tracing 15.463 s [15.463 s, 15.463 s] -178.0 ms (-1.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~72f50e28d6, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.326 ms) : 2285, 2367
.   : milestone, 2326,
iast (2.061 ms) : 2010, 2112
.   : milestone, 2061,
iast_GLOBAL (2.1 ms) : 2048, 2151
.   : milestone, 2100,
profiling (1.933 ms) : 1893, 1974
.   : milestone, 1933,
tracing (1.908 ms) : 1869, 1947
.   : milestone, 1908,
section candidate
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.336 ms) : 2295, 2378
.   : milestone, 2336,
iast (2.059 ms) : 2008, 2111
.   : milestone, 2059,
iast_GLOBAL (2.111 ms) : 2059, 2162
.   : milestone, 2111,
profiling (1.944 ms) : 1902, 1986
.   : milestone, 1944,
tracing (1.903 ms) : 1864, 1942
.   : milestone, 1903,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.326 ms [2.285 ms, 2.367 ms] 859.641 µs (58.6%)
iast 2.061 ms [2.01 ms, 2.112 ms] 594.917 µs (40.6%)
iast_GLOBAL 2.1 ms [2.048 ms, 2.151 ms] 633.479 µs (43.2%)
profiling 1.933 ms [1.893 ms, 1.974 ms] 467.225 µs (31.9%)
tracing 1.908 ms [1.869 ms, 1.947 ms] 442.081 µs (30.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.476 ms] -
appsec 2.336 ms [2.295 ms, 2.378 ms] 871.928 µs (59.5%)
iast 2.059 ms [2.008 ms, 2.111 ms] 595.032 µs (40.6%)
iast_GLOBAL 2.111 ms [2.059 ms, 2.162 ms] 646.149 µs (44.1%)
profiling 1.944 ms [1.902 ms, 1.986 ms] 479.783 µs (32.8%)
tracing 1.903 ms [1.864 ms, 1.942 ms] 438.937 µs (30.0%)

PerfectSlayer
PerfectSlayer reviewed Sep 13, 2024
View reviewed changes
BUILDING.md Outdated Show resolved Hide resolved
@PerfectSlayer PerfectSlayer mentioned this pull request Sep 23, 2024
Open
5 tasks
PerfectSlayer
PerfectSlayer approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback and taking part into improving our doc 👍

@PerfectSlayer PerfectSlayer changed the title Add and modify BUILDING documentation, and fix typo in setup script Improve BUILDING documentation, and fix typo in setup script Sep 25, 2024
@PerfectSlayer PerfectSlayer added type: enhancement tag: no release notes Changes to exclude from release notes and removed type: enhancement labels Sep 25, 2024
@jordan-wong jordan-wong merged commit aa1e54c into master Sep 27, 2024
97 of 101 checks passed
@jordan-wong jordan-wong deleted the documentation_improvements branch September 27, 2024 13:56
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola left review comments

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal

Assignees
No one assigned
Labels
tag: no release notes Changes to exclude from release notes type: documentation
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jordan-wong @smola @PerfectSlayer