-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix freemarker test with newer versions #7616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix 👍
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~19239bf814, baseline=1.40.0-SNAPSHOT~fcd206e7d7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063789
Total [baseline] (8.503 s) : 0, 8503124
Agent [candidate] (1.075 s) : 0, 1075385
Total [candidate] (8.511 s) : 0, 8511453
section iast
Agent [baseline] (1.19 s) : 0, 1189708
Total [baseline] (8.975 s) : 0, 8975257
Agent [candidate] (1.187 s) : 0, 1186906
Total [candidate] (8.972 s) : 0, 8971594
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1186453
Total [baseline] (8.939 s) : 0, 8938524
Agent [candidate] (1.185 s) : 0, 1185199
Total [candidate] (8.934 s) : 0, 8934203
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1183942
Total [baseline] (8.978 s) : 0, 8977534
Agent [candidate] (1.186 s) : 0, 1185535
Total [candidate] (8.975 s) : 0, 8974542
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~19239bf814, baseline=1.40.0-SNAPSHOT~fcd206e7d7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.89 ms) : 0, 679890
BytebuddyAgent [candidate] (687.513 ms) : 0, 687513
GlobalTracer [baseline] (310.228 ms) : 0, 310228
GlobalTracer [candidate] (313.585 ms) : 0, 313585
AppSec [baseline] (51.796 ms) : 0, 51796
AppSec [candidate] (52.221 ms) : 0, 52221
Remote Config [baseline] (724.52 µs) : 0, 725
Remote Config [candidate] (720.034 µs) : 0, 720
Telemetry [baseline] (7.561 ms) : 0, 7561
Telemetry [candidate] (7.603 ms) : 0, 7603
section iast
BytebuddyAgent [baseline] (792.37 ms) : 0, 792370
BytebuddyAgent [candidate] (790.512 ms) : 0, 790512
GlobalTracer [baseline] (299.327 ms) : 0, 299327
GlobalTracer [candidate] (298.536 ms) : 0, 298536
AppSec [baseline] (53.791 ms) : 0, 53791
AppSec [candidate] (53.513 ms) : 0, 53513
IAST [baseline] (22.541 ms) : 0, 22541
IAST [candidate] (22.663 ms) : 0, 22663
Remote Config [baseline] (638.264 µs) : 0, 638
Remote Config [candidate] (638.541 µs) : 0, 639
Telemetry [baseline] (7.346 ms) : 0, 7346
Telemetry [candidate] (7.428 ms) : 0, 7428
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (789.484 ms) : 0, 789484
BytebuddyAgent [candidate] (788.736 ms) : 0, 788736
GlobalTracer [baseline] (298.578 ms) : 0, 298578
GlobalTracer [candidate] (298.642 ms) : 0, 298642
AppSec [baseline] (53.134 ms) : 0, 53134
AppSec [candidate] (51.812 ms) : 0, 51812
IAST [baseline] (23.667 ms) : 0, 23667
IAST [candidate] (23.635 ms) : 0, 23635
Remote Config [baseline] (619.666 µs) : 0, 620
Remote Config [candidate] (606.423 µs) : 0, 606
Telemetry [baseline] (7.388 ms) : 0, 7388
Telemetry [candidate] (8.137 ms) : 0, 8137
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (788.042 ms) : 0, 788042
BytebuddyAgent [candidate] (788.111 ms) : 0, 788111
GlobalTracer [baseline] (298.746 ms) : 0, 298746
GlobalTracer [candidate] (298.956 ms) : 0, 298956
AppSec [baseline] (52.359 ms) : 0, 52359
AppSec [candidate] (51.041 ms) : 0, 51041
IAST [baseline] (23.247 ms) : 0, 23247
IAST [candidate] (25.125 ms) : 0, 25125
Remote Config [baseline] (610.957 µs) : 0, 611
Remote Config [candidate] (604.907 µs) : 0, 605
Telemetry [baseline] (7.304 ms) : 0, 7304
Telemetry [candidate] (8.032 ms) : 0, 8032
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~19239bf814, baseline=1.40.0-SNAPSHOT~fcd206e7d7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063119
Total [baseline] (10.34 s) : 0, 10339577
Agent [candidate] (1.077 s) : 0, 1077053
Total [candidate] (10.382 s) : 0, 10382493
section appsec
Agent [baseline] (1.196 s) : 0, 1196130
Total [baseline] (10.566 s) : 0, 10566354
Agent [candidate] (1.197 s) : 0, 1197155
Total [candidate] (10.544 s) : 0, 10544343
section iast
Agent [baseline] (1.191 s) : 0, 1190900
Total [baseline] (10.828 s) : 0, 10827838
Agent [candidate] (1.196 s) : 0, 1196214
Total [candidate] (10.837 s) : 0, 10837063
section profiling
Agent [baseline] (1.261 s) : 0, 1261349
Total [baseline] (10.604 s) : 0, 10603750
Agent [candidate] (1.259 s) : 0, 1258941
Total [candidate] (10.586 s) : 0, 10586324
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~19239bf814, baseline=1.40.0-SNAPSHOT~fcd206e7d7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.189 ms) : 0, 679189
BytebuddyAgent [candidate] (688.82 ms) : 0, 688820
GlobalTracer [baseline] (310.448 ms) : 0, 310448
GlobalTracer [candidate] (313.863 ms) : 0, 313863
AppSec [baseline] (51.654 ms) : 0, 51654
AppSec [candidate] (52.168 ms) : 0, 52168
Remote Config [baseline] (723.604 µs) : 0, 724
Remote Config [candidate] (727.752 µs) : 0, 728
Telemetry [baseline] (7.495 ms) : 0, 7495
Telemetry [candidate] (7.648 ms) : 0, 7648
section appsec
BytebuddyAgent [baseline] (699.874 ms) : 0, 699874
BytebuddyAgent [candidate] (700.186 ms) : 0, 700186
GlobalTracer [baseline] (303.37 ms) : 0, 303370
GlobalTracer [candidate] (303.481 ms) : 0, 303481
AppSec [baseline] (161.069 ms) : 0, 161069
AppSec [candidate] (161.304 ms) : 0, 161304
Remote Config [baseline] (645.714 µs) : 0, 646
Remote Config [candidate] (648.621 µs) : 0, 649
Telemetry [baseline] (7.985 ms) : 0, 7985
Telemetry [candidate] (8.315 ms) : 0, 8315
IAST [baseline] (19.168 ms) : 0, 19168
IAST [candidate] (19.139 ms) : 0, 19139
section iast
BytebuddyAgent [baseline] (793.53 ms) : 0, 793530
BytebuddyAgent [candidate] (797.388 ms) : 0, 797388
GlobalTracer [baseline] (299.185 ms) : 0, 299185
GlobalTracer [candidate] (300.589 ms) : 0, 300589
AppSec [baseline] (54.885 ms) : 0, 54885
AppSec [candidate] (52.696 ms) : 0, 52696
Remote Config [baseline] (630.831 µs) : 0, 631
Remote Config [candidate] (671.766 µs) : 0, 672
Telemetry [baseline] (7.303 ms) : 0, 7303
Telemetry [candidate] (7.379 ms) : 0, 7379
IAST [baseline] (21.749 ms) : 0, 21749
IAST [candidate] (23.77 ms) : 0, 23770
section profiling
ProfilingAgent [baseline] (95.985 ms) : 0, 95985
ProfilingAgent [candidate] (95.305 ms) : 0, 95305
BytebuddyAgent [baseline] (673.593 ms) : 0, 673593
BytebuddyAgent [candidate] (672.359 ms) : 0, 672359
GlobalTracer [baseline] (393.44 ms) : 0, 393440
GlobalTracer [candidate] (392.989 ms) : 0, 392989
AppSec [baseline] (52.192 ms) : 0, 52192
AppSec [candidate] (52.228 ms) : 0, 52228
Remote Config [baseline] (717.943 µs) : 0, 718
Remote Config [candidate] (704.231 µs) : 0, 704
Telemetry [baseline] (7.431 ms) : 0, 7431
Telemetry [candidate] (7.398 ms) : 0, 7398
Profiling [baseline] (96.009 ms) : 0, 96009
Profiling [candidate] (95.329 ms) : 0, 95329
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~19239bf814, baseline=1.40.0-SNAPSHOT~e11c39e1b4
dateFormat X
axisFormat %s
section baseline
no_agent (374.386 µs) : 355, 394
. : milestone, 374,
iast (488.148 µs) : 466, 510
. : milestone, 488,
iast_FULL (555.98 µs) : 535, 577
. : milestone, 556,
iast_GLOBAL (505.842 µs) : 485, 527
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (482.385 µs) : 461, 504
. : milestone, 482,
iast_INACTIVE (447.811 µs) : 427, 468
. : milestone, 448,
iast_TELEMETRY_OFF (479.808 µs) : 457, 502
. : milestone, 480,
tracing (440.257 µs) : 420, 461
. : milestone, 440,
section candidate
no_agent (377.843 µs) : 358, 398
. : milestone, 378,
iast (493.494 µs) : 471, 516
. : milestone, 493,
iast_FULL (555.218 µs) : 534, 576
. : milestone, 555,
iast_GLOBAL (500.901 µs) : 480, 522
. : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (491.123 µs) : 468, 514
. : milestone, 491,
iast_INACTIVE (448.621 µs) : 428, 469
. : milestone, 449,
iast_TELEMETRY_OFF (473.773 µs) : 452, 496
. : milestone, 474,
tracing (443.298 µs) : 423, 463
. : milestone, 443,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~19239bf814, baseline=1.40.0-SNAPSHOT~e11c39e1b4
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1330, 1368
. : milestone, 1349,
appsec (1.716 ms) : 1692, 1741
. : milestone, 1716,
appsec_no_iast (1.718 ms) : 1694, 1742
. : milestone, 1718,
iast (1.472 ms) : 1450, 1495
. : milestone, 1472,
profiling (1.474 ms) : 1451, 1498
. : milestone, 1474,
tracing (1.457 ms) : 1433, 1482
. : milestone, 1457,
section candidate
no_agent (1.322 ms) : 1303, 1341
. : milestone, 1322,
appsec (1.733 ms) : 1710, 1757
. : milestone, 1733,
appsec_no_iast (1.702 ms) : 1679, 1726
. : milestone, 1702,
iast (1.477 ms) : 1454, 1500
. : milestone, 1477,
profiling (1.488 ms) : 1463, 1513
. : milestone, 1488,
tracing (1.473 ms) : 1449, 1497
. : milestone, 1473,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~19239bf814, baseline=1.40.0-SNAPSHOT~e11c39e1b4
dateFormat X
axisFormat %s
section baseline
no_agent (15.38 s) : 15380000, 15380000
. : milestone, 15380000,
appsec (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
iast (18.832 s) : 18832000, 18832000
. : milestone, 18832000,
iast_GLOBAL (18.246 s) : 18246000, 18246000
. : milestone, 18246000,
profiling (15.463 s) : 15463000, 15463000
. : milestone, 15463000,
tracing (15.243 s) : 15243000, 15243000
. : milestone, 15243000,
section candidate
no_agent (15.086 s) : 15086000, 15086000
. : milestone, 15086000,
appsec (15.141 s) : 15141000, 15141000
. : milestone, 15141000,
iast (18.998 s) : 18998000, 18998000
. : milestone, 18998000,
iast_GLOBAL (18.146 s) : 18146000, 18146000
. : milestone, 18146000,
profiling (15.107 s) : 15107000, 15107000
. : milestone, 15107000,
tracing (15.16 s) : 15160000, 15160000
. : milestone, 15160000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~19239bf814, baseline=1.40.0-SNAPSHOT~e11c39e1b4
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
. : milestone, 1465,
appsec (2.292 ms) : 2251, 2332
. : milestone, 2292,
iast (2.056 ms) : 2007, 2104
. : milestone, 2056,
iast_GLOBAL (2.091 ms) : 2041, 2140
. : milestone, 2091,
profiling (1.925 ms) : 1885, 1966
. : milestone, 1925,
tracing (1.902 ms) : 1865, 1940
. : milestone, 1902,
section candidate
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.303 ms) : 2262, 2344
. : milestone, 2303,
iast (2.043 ms) : 1995, 2091
. : milestone, 2043,
iast_GLOBAL (2.096 ms) : 2046, 2147
. : milestone, 2096,
profiling (1.921 ms) : 1881, 1960
. : milestone, 1921,
tracing (1.914 ms) : 1876, 1953
. : milestone, 1914,
|
What Does This Do
Fix the test with newer versions of freemarker
Motivation
This is motivated by an upgrade of the freemarker latest version that was showing error in the specific test
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]