-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Single Step Instrumentation Guardrails #7568
Open
PerfectSlayer
wants to merge
1
commit into
master
Choose a base branch
from
bbujon/ssi-guardrails
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+624
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectSlayer
changed the title
Bbujon/ssi guardrails
Enable Single Step Instrumentation Guardrails
Sep 5, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~8d9ff5908d, baseline=1.40.0-SNAPSHOT~efa3824d5d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065987
Total [baseline] (10.438 s) : 0, 10437867
Agent [candidate] (1.064 s) : 0, 1063954
Total [candidate] (10.391 s) : 0, 10390892
section appsec
Agent [baseline] (1.208 s) : 0, 1207642
Total [baseline] (10.587 s) : 0, 10586741
Agent [candidate] (1.203 s) : 0, 1203204
Total [candidate] (10.66 s) : 0, 10660211
section iast
Agent [baseline] (1.19 s) : 0, 1189982
Total [baseline] (10.789 s) : 0, 10788729
Agent [candidate] (1.198 s) : 0, 1197784
Total [candidate] (10.933 s) : 0, 10933493
section profiling
Agent [baseline] (1.268 s) : 0, 1268008
Total [baseline] (10.58 s) : 0, 10579735
Agent [candidate] (1.262 s) : 0, 1261600
Total [candidate] (10.576 s) : 0, 10575681
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~8d9ff5908d, baseline=1.40.0-SNAPSHOT~efa3824d5d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.205 ms) : 0, 679205
BytebuddyAgent [candidate] (678.716 ms) : 0, 678716
GlobalTracer [baseline] (311.181 ms) : 0, 311181
GlobalTracer [candidate] (311.026 ms) : 0, 311026
AppSec [baseline] (53.766 ms) : 0, 53766
AppSec [candidate] (52.407 ms) : 0, 52407
Remote Config [baseline] (658.354 µs) : 0, 658
Remote Config [candidate] (667.746 µs) : 0, 668
Telemetry [baseline] (7.576 ms) : 0, 7576
Telemetry [candidate] (7.504 ms) : 0, 7504
section appsec
BytebuddyAgent [baseline] (701.543 ms) : 0, 701543
BytebuddyAgent [candidate] (703.501 ms) : 0, 703501
GlobalTracer [baseline] (309.295 ms) : 0, 309295
GlobalTracer [candidate] (304.536 ms) : 0, 304536
AppSec [baseline] (164.44 ms) : 0, 164440
AppSec [candidate] (163.346 ms) : 0, 163346
Remote Config [baseline] (638.912 µs) : 0, 639
Remote Config [candidate] (629.925 µs) : 0, 630
Telemetry [baseline] (7.833 ms) : 0, 7833
Telemetry [candidate] (7.982 ms) : 0, 7982
IAST [baseline] (20.379 ms) : 0, 20379
IAST [candidate] (19.063 ms) : 0, 19063
section iast
BytebuddyAgent [baseline] (791.734 ms) : 0, 791734
BytebuddyAgent [candidate] (797.421 ms) : 0, 797421
GlobalTracer [baseline] (299.034 ms) : 0, 299034
GlobalTracer [candidate] (300.989 ms) : 0, 300989
AppSec [baseline] (52.895 ms) : 0, 52895
AppSec [candidate] (54.721 ms) : 0, 54721
Remote Config [baseline] (593.974 µs) : 0, 594
Remote Config [candidate] (626.429 µs) : 0, 626
Telemetry [baseline] (6.953 ms) : 0, 6953
Telemetry [candidate] (7.335 ms) : 0, 7335
IAST [baseline] (25.133 ms) : 0, 25133
IAST [candidate] (22.941 ms) : 0, 22941
section profiling
BytebuddyAgent [baseline] (676.608 ms) : 0, 676608
BytebuddyAgent [candidate] (672.586 ms) : 0, 672586
GlobalTracer [baseline] (394.604 ms) : 0, 394604
GlobalTracer [candidate] (394.028 ms) : 0, 394028
AppSec [baseline] (54.288 ms) : 0, 54288
AppSec [candidate] (53.0 ms) : 0, 53000
Remote Config [baseline] (658.475 µs) : 0, 658
Remote Config [candidate] (661.093 µs) : 0, 661
Telemetry [baseline] (7.537 ms) : 0, 7537
Telemetry [candidate] (7.364 ms) : 0, 7364
ProfilingAgent [baseline] (95.499 ms) : 0, 95499
ProfilingAgent [candidate] (95.998 ms) : 0, 95998
Profiling [baseline] (95.524 ms) : 0, 95524
Profiling [candidate] (96.022 ms) : 0, 96022
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~8d9ff5908d, baseline=1.40.0-SNAPSHOT~efa3824d5d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069751
Total [baseline] (8.556 s) : 0, 8555587
Agent [candidate] (1.064 s) : 0, 1064205
Total [candidate] (8.517 s) : 0, 8517158
section iast
Agent [baseline] (1.19 s) : 0, 1190494
Total [baseline] (9.017 s) : 0, 9017291
Agent [candidate] (1.191 s) : 0, 1191127
Total [candidate] (8.997 s) : 0, 8997351
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.19 s) : 0, 1190075
Total [baseline] (8.997 s) : 0, 8996991
Agent [candidate] (1.189 s) : 0, 1188824
Total [candidate] (8.966 s) : 0, 8966115
section iast_TELEMETRY_OFF
Agent [baseline] (1.189 s) : 0, 1189489
Total [baseline] (9.044 s) : 0, 9044418
Agent [candidate] (1.204 s) : 0, 1204424
Total [candidate] (9.073 s) : 0, 9073484
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~8d9ff5908d, baseline=1.40.0-SNAPSHOT~efa3824d5d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.58 ms) : 0, 682580
BytebuddyAgent [candidate] (679.038 ms) : 0, 679038
GlobalTracer [baseline] (311.621 ms) : 0, 311621
GlobalTracer [candidate] (311.052 ms) : 0, 311052
AppSec [baseline] (53.585 ms) : 0, 53585
AppSec [candidate] (52.424 ms) : 0, 52424
Remote Config [baseline] (667.797 µs) : 0, 668
Remote Config [candidate] (653.453 µs) : 0, 653
Telemetry [baseline] (7.589 ms) : 0, 7589
Telemetry [candidate] (7.421 ms) : 0, 7421
section iast
BytebuddyAgent [baseline] (792.25 ms) : 0, 792250
BytebuddyAgent [candidate] (792.649 ms) : 0, 792649
GlobalTracer [baseline] (299.353 ms) : 0, 299353
GlobalTracer [candidate] (299.65 ms) : 0, 299650
AppSec [baseline] (52.546 ms) : 0, 52546
AppSec [candidate] (52.915 ms) : 0, 52915
Remote Config [baseline] (624.238 µs) : 0, 624
Remote Config [candidate] (593.055 µs) : 0, 593
Telemetry [baseline] (6.954 ms) : 0, 6954
Telemetry [candidate] (7.256 ms) : 0, 7256
IAST [baseline] (25.14 ms) : 0, 25140
IAST [candidate] (24.367 ms) : 0, 24367
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (791.845 ms) : 0, 791845
BytebuddyAgent [candidate] (791.112 ms) : 0, 791112
GlobalTracer [baseline] (299.976 ms) : 0, 299976
GlobalTracer [candidate] (299.296 ms) : 0, 299296
AppSec [baseline] (52.401 ms) : 0, 52401
AppSec [candidate] (53.945 ms) : 0, 53945
Remote Config [baseline] (636.07 µs) : 0, 636
Remote Config [candidate] (632.435 µs) : 0, 632
Telemetry [baseline] (7.029 ms) : 0, 7029
Telemetry [candidate] (7.392 ms) : 0, 7392
IAST [baseline] (24.515 ms) : 0, 24515
IAST [candidate] (22.783 ms) : 0, 22783
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.672 ms) : 0, 789672
BytebuddyAgent [candidate] (800.966 ms) : 0, 800966
GlobalTracer [baseline] (300.152 ms) : 0, 300152
GlobalTracer [candidate] (303.705 ms) : 0, 303705
AppSec [baseline] (54.263 ms) : 0, 54263
AppSec [candidate] (55.381 ms) : 0, 55381
Remote Config [baseline] (653.696 µs) : 0, 654
Remote Config [candidate] (602.388 µs) : 0, 602
Telemetry [baseline] (6.913 ms) : 0, 6913
Telemetry [candidate] (7.307 ms) : 0, 7307
IAST [baseline] (24.165 ms) : 0, 24165
IAST [candidate] (22.592 ms) : 0, 22592
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~8d9ff5908d, baseline=1.40.0-SNAPSHOT~efa3824d5d
dateFormat X
axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
. : milestone, 1343,
appsec (1.712 ms) : 1687, 1737
. : milestone, 1712,
appsec_no_iast (1.726 ms) : 1702, 1750
. : milestone, 1726,
iast (1.484 ms) : 1461, 1506
. : milestone, 1484,
profiling (1.466 ms) : 1443, 1489
. : milestone, 1466,
tracing (1.458 ms) : 1433, 1483
. : milestone, 1458,
section candidate
no_agent (1.335 ms) : 1316, 1354
. : milestone, 1335,
appsec (1.731 ms) : 1707, 1755
. : milestone, 1731,
appsec_no_iast (1.741 ms) : 1716, 1765
. : milestone, 1741,
iast (1.492 ms) : 1469, 1515
. : milestone, 1492,
profiling (1.476 ms) : 1452, 1499
. : milestone, 1476,
tracing (1.465 ms) : 1440, 1490
. : milestone, 1465,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~8d9ff5908d, baseline=1.40.0-SNAPSHOT~efa3824d5d
dateFormat X
axisFormat %s
section baseline
no_agent (375.132 µs) : 355, 395
. : milestone, 375,
iast (482.401 µs) : 461, 504
. : milestone, 482,
iast_FULL (552.84 µs) : 532, 574
. : milestone, 553,
iast_GLOBAL (514.14 µs) : 492, 536
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (488.937 µs) : 467, 511
. : milestone, 489,
iast_INACTIVE (451.209 µs) : 430, 472
. : milestone, 451,
iast_TELEMETRY_OFF (480.228 µs) : 458, 502
. : milestone, 480,
tracing (455.046 µs) : 433, 477
. : milestone, 455,
section candidate
no_agent (375.089 µs) : 355, 396
. : milestone, 375,
iast (481.389 µs) : 460, 503
. : milestone, 481,
iast_FULL (554.027 µs) : 533, 575
. : milestone, 554,
iast_GLOBAL (511.507 µs) : 490, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (488.81 µs) : 467, 510
. : milestone, 489,
iast_INACTIVE (455.953 µs) : 434, 477
. : milestone, 456,
iast_TELEMETRY_OFF (477.051 µs) : 455, 500
. : milestone, 477,
tracing (447.21 µs) : 426, 469
. : milestone, 447,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~8d9ff5908d, baseline=1.40.0-SNAPSHOT~efa3824d5d
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.313 ms) : 2273, 2353
. : milestone, 2313,
iast (2.067 ms) : 2016, 2118
. : milestone, 2067,
iast_GLOBAL (2.109 ms) : 2057, 2160
. : milestone, 2109,
profiling (1.949 ms) : 1907, 1990
. : milestone, 1949,
tracing (1.909 ms) : 1871, 1947
. : milestone, 1909,
section candidate
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (2.3 ms) : 2260, 2341
. : milestone, 2300,
iast (2.066 ms) : 2015, 2116
. : milestone, 2066,
iast_GLOBAL (2.104 ms) : 2053, 2154
. : milestone, 2104,
profiling (1.93 ms) : 1889, 1970
. : milestone, 1930,
tracing (1.907 ms) : 1869, 1945
. : milestone, 1907,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~8d9ff5908d, baseline=1.40.0-SNAPSHOT~efa3824d5d
dateFormat X
axisFormat %s
section baseline
no_agent (15.413 s) : 15413000, 15413000
. : milestone, 15413000,
appsec (15.09 s) : 15090000, 15090000
. : milestone, 15090000,
iast (18.681 s) : 18681000, 18681000
. : milestone, 18681000,
iast_GLOBAL (17.816 s) : 17816000, 17816000
. : milestone, 17816000,
profiling (15.065 s) : 15065000, 15065000
. : milestone, 15065000,
tracing (15.187 s) : 15187000, 15187000
. : milestone, 15187000,
section candidate
no_agent (15.088 s) : 15088000, 15088000
. : milestone, 15088000,
appsec (15.212 s) : 15212000, 15212000
. : milestone, 15212000,
iast (18.849 s) : 18849000, 18849000
. : milestone, 18849000,
iast_GLOBAL (18.015 s) : 18015000, 18015000
. : milestone, 18015000,
profiling (15.274 s) : 15274000, 15274000
. : milestone, 15274000,
tracing (15.223 s) : 15223000, 15223000
. : milestone, 15223000,
|
PerfectSlayer
force-pushed
the
bbujon/ssi-guardrails
branch
from
September 5, 2024 14:45
f38928c
to
99cb49a
Compare
PerfectSlayer
force-pushed
the
bbujon/ssi-guardrails
branch
3 times, most recently
from
September 18, 2024 09:18
1303caa
to
017a398
Compare
PerfectSlayer
force-pushed
the
bbujon/ssi-guardrails
branch
2 times, most recently
from
September 30, 2024 08:34
bc26afd
to
655eb7a
Compare
PerfectSlayer
force-pushed
the
bbujon/ssi-guardrails
branch
from
September 30, 2024 08:45
655eb7a
to
8d9ff59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR enables SSI guardrails.
Motivation
When SSI will be enabled by default, guardrails will make sure injection does not apply every time, skipping known incompatible configurations.
Additional Notes
Additional blocking mechanism is added on injector repository: https://github.com/DataDog/auto_inject/pull/436
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMLP-100