Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Payload Tagging #7312

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

AWS Payload Tagging #7312

wants to merge 22 commits into from
+1,845 −9

Conversation

ygree
Copy link
Contributor

@ygree ygree commented Jul 12, 2024 •
edited
Loading

What Does This Do

Adds functionality to capture AWS Json response/request payload and convert it to span tags while applying expansion and redaction defined rules.

Motivation

Having the ability to see data that was passed into an HTTPS payload from one service to the other.
Help customers (especially those who are using serverless architecture) reproduce and resolve bugs in their serverless compute code or configuration.

Additional Notes

Jira ticket: AIDM-174

NodeJS: DataDog/dd-trace-js#4309

@ygree ygree added tag: do not merge Do not merge changes inst: aws sdk AWS SDK instrumentation labels Jul 12, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 12, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/aws-payload-tagging
git_commit_date 1727466491 1727472012
git_commit_sha 201bcbe 8f59128
release_version 1.40.0-SNAPSHOT~201bcbe8ed 1.40.0-SNAPSHOT~8f5912837c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727474531 1727474531
ci_job_id 654629948 654629948
ci_pipeline_id 45345952 45345952
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~8f5912837c, baseline=1.40.0-SNAPSHOT~201bcbe8ed

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071641
Total [baseline] (8.612 s) : 0, 8612453
Agent [candidate] (1.065 s) : 0, 1065032
Total [candidate] (8.511 s) : 0, 8511058
section iast
Agent [baseline] (1.197 s) : 0, 1197348
Total [baseline] (9.004 s) : 0, 9004118
Agent [candidate] (1.187 s) : 0, 1186505
Total [candidate] (8.992 s) : 0, 8991856
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1188748
Total [baseline] (9.07 s) : 0, 9069529
Agent [candidate] (1.192 s) : 0, 1192386
Total [candidate] (9.048 s) : 0, 9048188
section iast_TELEMETRY_OFF
Agent [baseline] (1.191 s) : 0, 1190888
Total [baseline] (8.98 s) : 0, 8979540
Agent [candidate] (1.196 s) : 0, 1196454
Total [candidate] (9.014 s) : 0, 9013886
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent iast 1.197 s 125.707 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.189 s 117.107 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.191 s 119.247 ms (11.1%)
Total tracing 8.612 s -
Total iast 9.004 s 391.666 ms (4.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.07 s 457.077 ms (5.3%)
Total iast_TELEMETRY_OFF 8.98 s 367.087 ms (4.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.187 s 121.474 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 127.355 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.196 s 131.422 ms (12.3%)
Total tracing 8.511 s -
Total iast 8.992 s 480.798 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.048 s 537.13 ms (6.3%)
Total iast_TELEMETRY_OFF 9.014 s 502.828 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~8f5912837c, baseline=1.40.0-SNAPSHOT~201bcbe8ed

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.374 ms) : 0, 685374
BytebuddyAgent [candidate] (679.389 ms) : 0, 679389
GlobalTracer [baseline] (310.466 ms) : 0, 310466
GlobalTracer [candidate] (310.127 ms) : 0, 310127
AppSec [baseline] (53.812 ms) : 0, 53812
AppSec [candidate] (53.721 ms) : 0, 53721
Remote Config [baseline] (663.654 µs) : 0, 664
Remote Config [candidate] (655.379 µs) : 0, 655
Telemetry [baseline] (7.583 ms) : 0, 7583
Telemetry [candidate] (7.541 ms) : 0, 7541
section iast
BytebuddyAgent [baseline] (797.303 ms) : 0, 797303
BytebuddyAgent [candidate] (789.978 ms) : 0, 789978
GlobalTracer [baseline] (300.048 ms) : 0, 300048
GlobalTracer [candidate] (298.006 ms) : 0, 298006
AppSec [baseline] (54.276 ms) : 0, 54276
AppSec [candidate] (52.83 ms) : 0, 52830
IAST [baseline] (24.343 ms) : 0, 24343
IAST [candidate] (24.389 ms) : 0, 24389
Remote Config [baseline] (610.22 µs) : 0, 610
Remote Config [candidate] (626.92 µs) : 0, 627
Telemetry [baseline] (7.013 ms) : 0, 7013
Telemetry [candidate] (7.018 ms) : 0, 7018
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (791.033 ms) : 0, 791033
BytebuddyAgent [candidate] (792.959 ms) : 0, 792959
GlobalTracer [baseline] (297.7 ms) : 0, 297700
GlobalTracer [candidate] (299.831 ms) : 0, 299831
AppSec [baseline] (53.845 ms) : 0, 53845
AppSec [candidate] (52.535 ms) : 0, 52535
IAST [baseline] (24.691 ms) : 0, 24691
IAST [candidate] (25.596 ms) : 0, 25596
Remote Config [baseline] (643.052 µs) : 0, 643
Remote Config [candidate] (628.967 µs) : 0, 629
Telemetry [baseline] (7.184 ms) : 0, 7184
Telemetry [candidate] (7.132 ms) : 0, 7132
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.692 ms) : 0, 791692
BytebuddyAgent [candidate] (795.277 ms) : 0, 795277
GlobalTracer [baseline] (299.754 ms) : 0, 299754
GlobalTracer [candidate] (301.614 ms) : 0, 301614
AppSec [baseline] (54.204 ms) : 0, 54204
AppSec [candidate] (56.905 ms) : 0, 56905
IAST [baseline] (24.038 ms) : 0, 24038
IAST [candidate] (21.379 ms) : 0, 21379
Remote Config [baseline] (604.599 µs) : 0, 605
Remote Config [candidate] (637.363 µs) : 0, 637
Telemetry [baseline] (6.896 ms) : 0, 6896
Telemetry [candidate] (6.876 ms) : 0, 6876
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~8f5912837c, baseline=1.40.0-SNAPSHOT~201bcbe8ed

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071236
Total [baseline] (10.343 s) : 0, 10342811
Agent [candidate] (1.071 s) : 0, 1071413
Total [candidate] (10.357 s) : 0, 10356564
section appsec
Agent [baseline] (1.203 s) : 0, 1202848
Total [baseline] (10.588 s) : 0, 10588180
Agent [candidate] (1.203 s) : 0, 1203084
Total [candidate] (10.597 s) : 0, 10596765
section iast
Agent [baseline] (1.212 s) : 0, 1211924
Total [baseline] (10.874 s) : 0, 10873687
Agent [candidate] (1.2 s) : 0, 1199665
Total [candidate] (10.876 s) : 0, 10876381
section profiling
Agent [baseline] (1.273 s) : 0, 1273110
Total [baseline] (10.655 s) : 0, 10655341
Agent [candidate] (1.277 s) : 0, 1277325
Total [candidate] (10.568 s) : 0, 10567721
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.203 s 131.612 ms (12.3%)
Agent iast 1.212 s 140.688 ms (13.1%)
Agent profiling 1.273 s 201.874 ms (18.8%)
Total tracing 10.343 s -
Total appsec 10.588 s 245.369 ms (2.4%)
Total iast 10.874 s 530.876 ms (5.1%)
Total profiling 10.655 s 312.53 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.203 s 131.672 ms (12.3%)
Agent iast 1.2 s 128.252 ms (12.0%)
Agent profiling 1.277 s 205.912 ms (19.2%)
Total tracing 10.357 s -
Total appsec 10.597 s 240.201 ms (2.3%)
Total iast 10.876 s 519.818 ms (5.0%)
Total profiling 10.568 s 211.158 ms (2.0%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~8f5912837c, baseline=1.40.0-SNAPSHOT~201bcbe8ed

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.064 ms) : 0, 684064
BytebuddyAgent [candidate] (683.915 ms) : 0, 683915
GlobalTracer [baseline] (311.224 ms) : 0, 311224
GlobalTracer [candidate] (311.504 ms) : 0, 311504
AppSec [baseline] (53.886 ms) : 0, 53886
AppSec [candidate] (53.99 ms) : 0, 53990
Remote Config [baseline] (663.167 µs) : 0, 663
Remote Config [candidate] (668.784 µs) : 0, 669
Telemetry [baseline] (7.756 ms) : 0, 7756
Telemetry [candidate] (7.672 ms) : 0, 7672
section appsec
BytebuddyAgent [baseline] (703.56 ms) : 0, 703560
BytebuddyAgent [candidate] (702.926 ms) : 0, 702926
GlobalTracer [baseline] (303.836 ms) : 0, 303836
GlobalTracer [candidate] (304.45 ms) : 0, 304450
AppSec [baseline] (162.739 ms) : 0, 162739
AppSec [candidate] (162.544 ms) : 0, 162544
Remote Config [baseline] (641.979 µs) : 0, 642
Remote Config [candidate] (636.241 µs) : 0, 636
Telemetry [baseline] (8.543 ms) : 0, 8543
Telemetry [candidate] (8.539 ms) : 0, 8539
IAST [baseline] (19.777 ms) : 0, 19777
IAST [candidate] (20.686 ms) : 0, 20686
section iast
BytebuddyAgent [baseline] (808.321 ms) : 0, 808321
BytebuddyAgent [candidate] (798.586 ms) : 0, 798586
GlobalTracer [baseline] (303.308 ms) : 0, 303308
GlobalTracer [candidate] (301.179 ms) : 0, 301179
AppSec [baseline] (54.878 ms) : 0, 54878
AppSec [candidate] (53.82 ms) : 0, 53820
Remote Config [baseline] (640.036 µs) : 0, 640
Remote Config [candidate] (628.69 µs) : 0, 629
Telemetry [baseline] (7.12 ms) : 0, 7120
Telemetry [candidate] (7.09 ms) : 0, 7090
IAST [baseline] (23.742 ms) : 0, 23742
IAST [candidate] (24.635 ms) : 0, 24635
section profiling
BytebuddyAgent [baseline] (676.961 ms) : 0, 676961
BytebuddyAgent [candidate] (681.86 ms) : 0, 681860
GlobalTracer [baseline] (395.662 ms) : 0, 395662
GlobalTracer [candidate] (396.388 ms) : 0, 396388
AppSec [baseline] (55.084 ms) : 0, 55084
AppSec [candidate] (55.024 ms) : 0, 55024
Remote Config [baseline] (660.396 µs) : 0, 660
Remote Config [candidate] (656.402 µs) : 0, 656
Telemetry [baseline] (7.529 ms) : 0, 7529
Telemetry [candidate] (7.483 ms) : 0, 7483
ProfilingAgent [baseline] (98.402 ms) : 0, 98402
ProfilingAgent [candidate] (96.844 ms) : 0, 96844
Profiling [baseline] (98.426 ms) : 0, 98426
Profiling [candidate] (96.868 ms) : 0, 96868
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-27T21:32:50 2024-09-27T21:39:40
git_branch master ygree/aws-payload-tagging
git_commit_date 1727466491 1727472012
git_commit_sha 201bcbe 8f59128
release_version 1.40.0-SNAPSHOT~201bcbe8ed 1.40.0-SNAPSHOT~8f5912837c
start_time 2024-09-27T21:32:37 2024-09-27T21:39:26
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727473525 1727473525
ci_job_id 654629949 654629949
ci_pipeline_id 45345952 45345952
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~8f5912837c, baseline=1.40.0-SNAPSHOT~201bcbe8ed
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.34 ms) : 1320, 1359
.   : milestone, 1340,
appsec (1.705 ms) : 1681, 1728
.   : milestone, 1705,
appsec_no_iast (1.714 ms) : 1691, 1737
.   : milestone, 1714,
iast (1.467 ms) : 1445, 1489
.   : milestone, 1467,
profiling (1.503 ms) : 1477, 1528
.   : milestone, 1503,
tracing (1.445 ms) : 1420, 1470
.   : milestone, 1445,
section candidate
no_agent (1.33 ms) : 1310, 1349
.   : milestone, 1330,
appsec (1.706 ms) : 1681, 1730
.   : milestone, 1706,
appsec_no_iast (1.716 ms) : 1692, 1740
.   : milestone, 1716,
iast (1.456 ms) : 1433, 1479
.   : milestone, 1456,
profiling (1.52 ms) : 1496, 1545
.   : milestone, 1520,
tracing (1.463 ms) : 1438, 1488
.   : milestone, 1463,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.32 ms, 1.359 ms] -
appsec 1.705 ms [1.681 ms, 1.728 ms] 364.722 µs (27.2%)
appsec_no_iast 1.714 ms [1.691 ms, 1.737 ms] 374.296 µs (27.9%)
iast 1.467 ms [1.445 ms, 1.489 ms] 127.367 µs (9.5%)
profiling 1.503 ms [1.477 ms, 1.528 ms] 162.981 µs (12.2%)
tracing 1.445 ms [1.42 ms, 1.47 ms] 105.102 µs (7.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.33 ms [1.31 ms, 1.349 ms] -
appsec 1.706 ms [1.681 ms, 1.73 ms] 375.627 µs (28.2%)
appsec_no_iast 1.716 ms [1.692 ms, 1.74 ms] 385.813 µs (29.0%)
iast 1.456 ms [1.433 ms, 1.479 ms] 126.375 µs (9.5%)
profiling 1.52 ms [1.496 ms, 1.545 ms] 190.509 µs (14.3%)
tracing 1.463 ms [1.438 ms, 1.488 ms] 133.003 µs (10.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~8f5912837c, baseline=1.40.0-SNAPSHOT~201bcbe8ed
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.143 µs) : 349, 391
.   : milestone, 370,
iast (487.194 µs) : 465, 509
.   : milestone, 487,
iast_FULL (548.65 µs) : 527, 570
.   : milestone, 549,
iast_GLOBAL (506.032 µs) : 485, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (476.175 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (442.694 µs) : 422, 463
.   : milestone, 443,
iast_TELEMETRY_OFF (466.314 µs) : 444, 489
.   : milestone, 466,
tracing (443.217 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (369.912 µs) : 351, 389
.   : milestone, 370,
iast (489.063 µs) : 467, 511
.   : milestone, 489,
iast_FULL (548.591 µs) : 527, 570
.   : milestone, 549,
iast_GLOBAL (500.121 µs) : 479, 521
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (477.863 µs) : 457, 499
.   : milestone, 478,
iast_INACTIVE (452.764 µs) : 431, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (472.713 µs) : 451, 494
.   : milestone, 473,
tracing (455.752 µs) : 435, 477
.   : milestone, 456,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.143 µs [349.32 µs, 390.966 µs] -
iast 487.194 µs [465.378 µs, 509.01 µs] 117.051 µs (31.6%)
iast_FULL 548.65 µs [527.244 µs, 570.057 µs] 178.507 µs (48.2%)
iast_GLOBAL 506.032 µs [484.543 µs, 527.521 µs] 135.889 µs (36.7%)
iast_HARDCODED_SECRET_DISABLED 476.175 µs [455.43 µs, 496.92 µs] 106.032 µs (28.6%)
iast_INACTIVE 442.694 µs [422.297 µs, 463.092 µs] 72.551 µs (19.6%)
iast_TELEMETRY_OFF 466.314 µs [443.657 µs, 488.972 µs] 96.171 µs (26.0%)
tracing 443.217 µs [422.222 µs, 464.212 µs] 73.074 µs (19.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.912 µs [350.662 µs, 389.161 µs] -
iast 489.063 µs [467.356 µs, 510.77 µs] 119.151 µs (32.2%)
iast_FULL 548.591 µs [527.269 µs, 569.913 µs] 178.679 µs (48.3%)
iast_GLOBAL 500.121 µs [479.013 µs, 521.228 µs] 130.209 µs (35.2%)
iast_HARDCODED_SECRET_DISABLED 477.863 µs [456.699 µs, 499.028 µs] 107.951 µs (29.2%)
iast_INACTIVE 452.764 µs [431.415 µs, 474.112 µs] 82.852 µs (22.4%)
iast_TELEMETRY_OFF 472.713 µs [451.383 µs, 494.043 µs] 102.801 µs (27.8%)
tracing 455.752 µs [434.629 µs, 476.874 µs] 85.84 µs (23.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ygree/aws-payload-tagging
git_commit_date 1727466491 1727472012
git_commit_sha 201bcbe 8f59128
release_version 1.40.0-SNAPSHOT~201bcbe8ed 1.40.0-SNAPSHOT~8f5912837c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727473971 1727473971
ci_job_id 654629950 654629950
ci_pipeline_id 45345952 45345952
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~8f5912837c, baseline=1.40.0-SNAPSHOT~201bcbe8ed
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.737 s) : 15737000, 15737000
.   : milestone, 15737000,
appsec (15.151 s) : 15151000, 15151000
.   : milestone, 15151000,
iast (18.713 s) : 18713000, 18713000
.   : milestone, 18713000,
iast_GLOBAL (18.058 s) : 18058000, 18058000
.   : milestone, 18058000,
profiling (15.152 s) : 15152000, 15152000
.   : milestone, 15152000,
tracing (15.096 s) : 15096000, 15096000
.   : milestone, 15096000,
section candidate
no_agent (15.105 s) : 15105000, 15105000
.   : milestone, 15105000,
appsec (15.095 s) : 15095000, 15095000
.   : milestone, 15095000,
iast (19.213 s) : 19213000, 19213000
.   : milestone, 19213000,
iast_GLOBAL (18.356 s) : 18356000, 18356000
.   : milestone, 18356000,
profiling (15.773 s) : 15773000, 15773000
.   : milestone, 15773000,
tracing (15.283 s) : 15283000, 15283000
.   : milestone, 15283000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.737 s [15.737 s, 15.737 s] -
appsec 15.151 s [15.151 s, 15.151 s] -586.0 ms (-3.7%)
iast 18.713 s [18.713 s, 18.713 s] 2.976 s (18.9%)
iast_GLOBAL 18.058 s [18.058 s, 18.058 s] 2.321 s (14.7%)
profiling 15.152 s [15.152 s, 15.152 s] -585.0 ms (-3.7%)
tracing 15.096 s [15.096 s, 15.096 s] -641.0 ms (-4.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.105 s [15.105 s, 15.105 s] -
appsec 15.095 s [15.095 s, 15.095 s] -10.0 ms (-0.1%)
iast 19.213 s [19.213 s, 19.213 s] 4.108 s (27.2%)
iast_GLOBAL 18.356 s [18.356 s, 18.356 s] 3.251 s (21.5%)
profiling 15.773 s [15.773 s, 15.773 s] 668.0 ms (4.4%)
tracing 15.283 s [15.283 s, 15.283 s] 178.0 ms (1.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~8f5912837c, baseline=1.40.0-SNAPSHOT~201bcbe8ed
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.325 ms) : 2284, 2366
.   : milestone, 2325,
iast (2.065 ms) : 2015, 2115
.   : milestone, 2065,
iast_GLOBAL (2.109 ms) : 2059, 2160
.   : milestone, 2109,
profiling (1.924 ms) : 1883, 1964
.   : milestone, 1924,
tracing (1.902 ms) : 1863, 1940
.   : milestone, 1902,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.33 ms) : 2289, 2370
.   : milestone, 2330,
iast (2.083 ms) : 2032, 2134
.   : milestone, 2083,
iast_GLOBAL (2.111 ms) : 2060, 2162
.   : milestone, 2111,
profiling (1.933 ms) : 1892, 1974
.   : milestone, 1933,
tracing (1.908 ms) : 1870, 1946
.   : milestone, 1908,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.325 ms [2.284 ms, 2.366 ms] 850.744 µs (57.7%)
iast 2.065 ms [2.015 ms, 2.115 ms] 590.436 µs (40.0%)
iast_GLOBAL 2.109 ms [2.059 ms, 2.16 ms] 635.004 µs (43.1%)
profiling 1.924 ms [1.883 ms, 1.964 ms] 449.262 µs (30.5%)
tracing 1.902 ms [1.863 ms, 1.94 ms] 427.174 µs (29.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.33 ms [2.289 ms, 2.37 ms] 863.061 µs (58.8%)
iast 2.083 ms [2.032 ms, 2.134 ms] 616.547 µs (42.0%)
iast_GLOBAL 2.111 ms [2.06 ms, 2.162 ms] 644.818 µs (44.0%)
profiling 1.933 ms [1.892 ms, 1.974 ms] 466.837 µs (31.8%)
tracing 1.908 ms [1.87 ms, 1.946 ms] 441.213 µs (30.1%)

@ygree ygree force-pushed the ygree/aws-payload-tagging branch from c9a799d to 1e180f3 Compare July 12, 2024 19:09
vandonr
vandonr reviewed Aug 22, 2024
View reviewed changes
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@ygree ygree force-pushed the ygree/aws-payload-tagging branch 6 times, most recently from 83f1bef to 7252b43 Compare September 11, 2024 04:50
@ygree ygree force-pushed the ygree/aws-payload-tagging branch 2 times, most recently from 37eed2b to bdb7eaf Compare September 12, 2024 00:36
@ygree ygree changed the title [PoC] AWS Payload observability AWS Payload Observability Sep 24, 2024
@ygree
AWS Payload observability PoC
5e19b41
@ygree
Exclude json-smart transitive dependency by implementing JsonProvider…
ff8cdc7 
… via Moshi
@ygree
Pass tagPrefix as a param
c74f6df
@ygree
Fix code quality violations
87e8ced
@ygree
Exclude jsonpath's transitive dependency to avoid conflicts with the …
61840ca 
…slf4j-api dependency in the agent
@ygree
Exclude MoshiMappingProvider from coverage check
60bb6d8
@ygree
Fix native image build for excluded net.minidev
cea1c4a
@ygree
Reduce unnecessary String allocation while traversing JSON for tag ex…
1a0a8a6 
…traction
@ygree
Introduce TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING & TRACE_CLOUD_RESPONSE_…
1301ada 
…PAYLOAD_TAGGING config settings
@ygree
Remove JsonPath defaults that didn't fix native build issue
6cb69c6
@ygree
Replace Json Tag Extraction implementation. Migrate from jayway.jsonp…
8acaf53 
…ath to jsurfer-core
@ygree ygree marked this pull request as ready for review September 27, 2024 23:21
@ygree ygree requested review from a team as code owners September 27, 2024 23:21
@ygree ygree changed the title AWS Payload Observability AWS Payload Tagging Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 Datadog - DataDog prod us1 Datadog - DataDog prod us1 left review comments

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/apm-java

@vandonr vandonr Awaiting requested review from vandonr

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
inst: aws sdk AWS SDK instrumentation tag: do not merge Do not merge changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ygree @vandonr