[Dynamic Instrumentation] DEBUG-2913 Fix runtime reflection exceptions when getting field value #6078

dudikeleti · 2024-09-25T11:51:45Z

Summary of changes

This PR aims to fix various kind of runtime exceptions while trying the get field value by reflection

datadog-ddstaging · 2024-09-25T12:13:54Z

Datadog Report

Branch report: dudik/get-field-value-error
Commit report: 5ab9cfa
Test service: dd-trace-dotnet

✅ 0 Failed, 370898 Passed, 2730 Skipped, 26h 7m 29.09s Total Time

andrewlock · 2024-09-25T12:23:00Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6078) - mean (71ms)  : 68, 75
     .   : milestone, 71,
    master - mean (71ms)  : 68, 74
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6078) - mean (1,109ms)  : 1087, 1131
     .   : milestone, 1109,
    master - mean (1,105ms)  : 1085, 1126
     .   : milestone, 1105,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6078) - mean (111ms)  : 107, 115
     .   : milestone, 111,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6078) - mean (778ms)  : 763, 792
     .   : milestone, 778,
    master - mean (775ms)  : 754, 796
     .   : milestone, 775,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6078) - mean (94ms)  : 90, 97
     .   : milestone, 94,
    master - mean (93ms)  : 89, 98
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6078) - mean (737ms)  : 718, 756
     .   : milestone, 737,
    master - mean (731ms)  : 714, 749
     .   : milestone, 731,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6078) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (193ms)  : 187, 199
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6078) - mean (1,202ms)  : 1179, 1225
     .   : milestone, 1202,
    master - mean (1,203ms)  : 1179, 1227
     .   : milestone, 1203,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6078) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (278ms)  : 271, 285
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6078) - mean (946ms)  : 928, 964
     .   : milestone, 946,
    master - mean (946ms)  : 926, 966
     .   : milestone, 946,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6078) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (266ms)  : 260, 272
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6078) - mean (933ms)  : 914, 951
     .   : milestone, 933,
    master - mean (928ms)  : 905, 951
     .   : milestone, 928,

andrewlock · 2024-09-25T13:13:14Z

Benchmarks Report for tracer 🐌

Benchmarks for #6078 compared to master:

2 benchmarks are faster, with geometric mean 1.311
3 benchmarks are slower, with geometric mean 1.148
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.74μs	43.6ns	315ns	0.0143	0.00716	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.89μs	55ns	348ns	0.0193	0.00965	0	5.63 KB
master	`StartStopWithChild`	net472	16μs	39.4ns	153ns	1.04	0.329	0.0939	6.07 KB
#6078	`StartStopWithChild`	net6.0	7.64μs	37.3ns	183ns	0.0158	0.00791	0	5.43 KB
#6078	`StartStopWithChild`	netcoreapp3.1	9.9μs	56ns	372ns	0.0154	0.00513	0	5.62 KB
#6078	`StartStopWithChild`	net472	16.1μs	44.4ns	172ns	1.02	0.305	0.0962	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	465μs	204ns	789ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	648μs	356ns	1.38μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	823μs	425ns	1.59μs	0.411	3.3 KB
#6078	`WriteAndFlushEnrichedTraces`	net6.0	479μs	216ns	836ns	0	2.7 KB
#6078	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	481ns	1.86μs	0	2.7 KB
#6078	`WriteAndFlushEnrichedTraces`	net472	834μs	454ns	1.76μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	197μs	1.13μs	8.8μs	0.197	18.45 KB
master	`SendRequest`	netcoreapp3.1	222μs	1.19μs	8.36μs	0.217	20.61 KB
master	`SendRequest`	net472	0.00161ns	0.000764ns	0.00286ns	0	0 b
#6078	`SendRequest`	net6.0	195μs	1.08μs	6.68μs	0.201	18.45 KB
#6078	`SendRequest`	netcoreapp3.1	215μs	1.1μs	6.49μs	0.211	20.61 KB
#6078	`SendRequest`	net472	0.00171ns	0.000797ns	0.00309ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	569μs	2.49μs	9.66μs	0.576	0	0	41.56 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	688μs	3.33μs	13.7μs	0.334	0	0	41.94 KB
master	`WriteAndFlushEnrichedTraces`	net472	893μs	3.69μs	14.3μs	8.19	2.59	0.431	53.28 KB
#6078	`WriteAndFlushEnrichedTraces`	net6.0	585μs	2.88μs	11.9μs	0.563	0	0	41.68 KB
#6078	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	688μs	3.21μs	12.4μs	0.332	0	0	41.87 KB
#6078	`WriteAndFlushEnrichedTraces`	net472	836μs	2.18μs	7.86μs	8.08	2.55	0.425	53.26 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.18μs	0.8ns	3ns	0.0141	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	1.49ns	5.78ns	0.0133	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	3.78ns	14.6ns	0.156	987 B
#6078	`ExecuteNonQuery`	net6.0	1.28μs	0.673ns	2.52ns	0.0141	1.02 KB
#6078	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	1.32ns	5.1ns	0.0138	1.02 KB
#6078	`ExecuteNonQuery`	net472	2.03μs	1.84ns	6.64ns	0.157	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.24μs	0.686ns	2.66ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.54μs	1.33ns	5.15ns	0.0131	976 B
master	`CallElasticsearch`	net472	2.5μs	2ns	7.75ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.26μs	1.14ns	4.43ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.71μs	0.829ns	3.21ns	0.0136	1.02 KB
master	`CallElasticsearchAsync`	net472	2.61μs	1.58ns	6.11ns	0.166	1.05 KB
#6078	`CallElasticsearch`	net6.0	1.19μs	0.929ns	3.6ns	0.0137	976 B
#6078	`CallElasticsearch`	netcoreapp3.1	1.59μs	0.751ns	2.91ns	0.0127	976 B
#6078	`CallElasticsearch`	net472	2.52μs	1.33ns	5.15ns	0.157	995 B
#6078	`CallElasticsearchAsync`	net6.0	1.24μs	0.531ns	2.06ns	0.0137	952 B
#6078	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	3.39ns	12.7ns	0.0138	1.02 KB
#6078	`CallElasticsearchAsync`	net472	2.63μs	1.35ns	5.06ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.3μs	1.1ns	4.24ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.56μs	0.731ns	2.63ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.79μs	0.497ns	1.86ns	0.145	915 B
#6078	`ExecuteAsync`	net6.0	1.38μs	0.589ns	2.2ns	0.0132	952 B
#6078	`ExecuteAsync`	netcoreapp3.1	1.61μs	1.29ns	4.82ns	0.0128	952 B
#6078	`ExecuteAsync`	net472	1.76μs	0.425ns	1.65ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.19μs	1.95ns	7.31ns	0.031	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.12μs	2.45ns	9.49ns	0.0359	2.76 KB
master	`SendAsync`	net472	7.83μs	3.56ns	13.8ns	0.496	3.15 KB
#6078	`SendAsync`	net6.0	4.22μs	0.924ns	3.46ns	0.0317	2.22 KB
#6078	`SendAsync`	netcoreapp3.1	5.05μs	2.06ns	7.13ns	0.0378	2.76 KB
#6078	`SendAsync`	net472	7.63μs	2.82ns	10.9ns	0.496	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.44μs	0.707ns	2.74ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.22μs	1.06ns	3.98ns	0.0223	1.64 KB
master	`EnrichedLog`	net472	2.6μs	0.868ns	3.25ns	0.249	1.57 KB
#6078	`EnrichedLog`	net6.0	1.41μs	0.861ns	3.22ns	0.0227	1.64 KB
#6078	`EnrichedLog`	netcoreapp3.1	2.23μs	1.62ns	6.27ns	0.0222	1.64 KB
#6078	`EnrichedLog`	net472	2.6μs	1.04ns	4.03ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	112μs	218ns	846ns	0.0569	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	115ns	414ns	0	0	4.28 KB
master	`EnrichedLog`	net472	147μs	145ns	542ns	0.657	0.219	4.46 KB
#6078	`EnrichedLog`	net6.0	114μs	273ns	1.06μs	0.0571	0	4.28 KB
#6078	`EnrichedLog`	netcoreapp3.1	118μs	158ns	611ns	0	0	4.28 KB
#6078	`EnrichedLog`	net472	146μs	160ns	618ns	0.66	0.22	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.05μs	1.25ns	4.5ns	0.0304	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.24μs	1.77ns	6.87ns	0.0276	2.2 KB
master	`EnrichedLog`	net472	4.81μs	1.24ns	4.79ns	0.32	2.02 KB
#6078	`EnrichedLog`	net6.0	3.03μs	0.944ns	3.66ns	0.0304	2.2 KB
#6078	`EnrichedLog`	netcoreapp3.1	4.37μs	1.67ns	6.47ns	0.0283	2.2 KB
#6078	`EnrichedLog`	net472	4.87μs	1.42ns	5.5ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.32μs	0.909ns	3.4ns	0.0158	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.76μs	2.53ns	9.47ns	0.0156	0	1.14 KB
master	`SendReceive`	net472	2.16μs	0.733ns	2.74ns	0.183	0.00108	1.16 KB
#6078	`SendReceive`	net6.0	1.38μs	0.474ns	1.77ns	0.0159	0	1.14 KB
#6078	`SendReceive`	netcoreapp3.1	1.9μs	2.62ns	10.1ns	0.0151	0	1.14 KB
#6078	`SendReceive`	net472	2.18μs	0.772ns	2.99ns	0.184	0.00109	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.81μs	1.17ns	4.54ns	0.0225	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.96μs	2.26ns	8.75ns	0.0217	1.65 KB
master	`EnrichedLog`	net472	4.42μs	3.35ns	13ns	0.324	2.04 KB
#6078	`EnrichedLog`	net6.0	2.77μs	0.915ns	3.42ns	0.0222	1.6 KB
#6078	`EnrichedLog`	netcoreapp3.1	3.81μs	1.68ns	6.5ns	0.0212	1.65 KB
#6078	`EnrichedLog`	net472	4.3μs	2.22ns	8.58ns	0.324	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6078

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.157	552.75	639.73

Faster 🎉 in #6078

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.317	628.27	477.15
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.306	741.28	567.78

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	398ns	0.208ns	0.807ns	0.00802	576 B
master	`StartFinishSpan`	netcoreapp3.1	552ns	0.47ns	1.82ns	0.00774	576 B
master	`StartFinishSpan`	net472	741ns	0.825ns	3.19ns	0.0917	578 B
master	`StartFinishScope`	net6.0	629ns	1.26ns	4.9ns	0.00983	696 B
master	`StartFinishScope`	netcoreapp3.1	717ns	0.555ns	2.15ns	0.00936	696 B
master	`StartFinishScope`	net472	855ns	0.634ns	2.46ns	0.105	658 B
#6078	`StartFinishSpan`	net6.0	418ns	0.474ns	1.83ns	0.00807	576 B
#6078	`StartFinishSpan`	netcoreapp3.1	640ns	0.943ns	3.53ns	0.00796	576 B
#6078	`StartFinishSpan`	net472	568ns	0.624ns	2.42ns	0.0916	578 B
#6078	`StartFinishScope`	net6.0	477ns	0.422ns	1.64ns	0.00977	696 B
#6078	`StartFinishScope`	netcoreapp3.1	651ns	0.271ns	1.02ns	0.00944	696 B
#6078	`StartFinishScope`	net472	819ns	0.704ns	2.73ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6078

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.147	612.66	702.78
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1	1.138	849.29	966.66

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	612ns	0.446ns	1.73ns	0.00973	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	849ns	0.736ns	2.85ns	0.00936	696 B
master	`RunOnMethodBegin`	net472	1.12μs	0.834ns	3.23ns	0.104	658 B
#6078	`RunOnMethodBegin`	net6.0	702ns	0.586ns	2.27ns	0.00986	696 B
#6078	`RunOnMethodBegin`	netcoreapp3.1	966ns	0.633ns	2.45ns	0.00919	696 B
#6078	`RunOnMethodBegin`	net472	1.14μs	1.12ns	4.32ns	0.104	658 B

andrewlock · 2024-09-25T15:08:20Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6078) (11.096M)   : 0, 11096482
    master (11.115M)   : 0, 11115019
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6078) (7.286M)   : 0, 7286456
    master (7.288M)   : 0, 7288058
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.570M)   : 0, 7569548

    section Manual
    master (11.119M)   : 0, 11118645

    section Manual + Automatic
    This PR (6078) (6.825M)   : 0, 6825021
    master (6.759M)   : 0, 6759326

    section DD_TRACE_ENABLED=0
    master (10.256M)   : 0, 10256341

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6078) (9.496M)   : 0, 9496299
    master (9.521M)   : 0, 9521038
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6078) (6.537M)   : 0, 6537352
    master (6.498M)   : 0, 6498406

    section Trace stats
    master (6.942M)   : 0, 6941628

    section Manual
    master (9.493M)   : 0, 9493351

    section Manual + Automatic
    This PR (6078) (6.116M)   : 0, 6115824
    master (5.986M)   : 0, 5986449

    section DD_TRACE_ENABLED=0
    master (8.976M)   : 0, 8976249

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6078) (10.058M)   : 0, 10057743
    master (10.101M)   : 0, 10100514
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6078) (6.734M)   : 0, 6733681
    master (6.620M)   : 0, 6619828
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.357M)   : 0, 7356653

    section Manual
    master (10.092M)   : 0, 10091514

    section Manual + Automatic
    This PR (6078) (6.195M)   : 0, 6195384
    master (6.098M)   : 0, 6097760

    section DD_TRACE_ENABLED=0
    master (9.472M)   : 0, 9472383

…ceptions

github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Sep 25, 2024

more checks for getting field and property values to avoid runtime ex…

5ab9cfa

…ceptions

dudikeleti force-pushed the dudik/get-field-value-error branch from af5b359 to 5ab9cfa Compare September 26, 2024 07:16

dudikeleti changed the title ~~more checks for getting field and property values to avoid runtime ex…~~ [Dynamic Instrumentation] DEBUG-2913 Fix runtime reflection exceptions when getting field value Sep 26, 2024

dudikeleti marked this pull request as ready for review September 26, 2024 12:16

dudikeleti requested a review from a team as a code owner September 26, 2024 12:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] DEBUG-2913 Fix runtime reflection exceptions when getting field value #6078

[Dynamic Instrumentation] DEBUG-2913 Fix runtime reflection exceptions when getting field value #6078

dudikeleti commented Sep 25, 2024 •

edited

Loading

datadog-ddstaging bot commented Sep 25, 2024 •

edited

Loading

andrewlock commented Sep 25, 2024 •

edited

Loading

andrewlock commented Sep 25, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6078

Faster 🎉 in #6078

Raw results

Slower ⚠️ in #6078

Raw results

andrewlock commented Sep 25, 2024 •

edited

Loading

[Dynamic Instrumentation] DEBUG-2913 Fix runtime reflection exceptions when getting field value #6078

Are you sure you want to change the base?

[Dynamic Instrumentation] DEBUG-2913 Fix runtime reflection exceptions when getting field value #6078

Conversation

dudikeleti commented Sep 25, 2024 • edited Loading

Summary of changes

datadog-ddstaging bot commented Sep 25, 2024 • edited Loading

Datadog Report

andrewlock commented Sep 25, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Sep 25, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6078

Faster 🎉 in #6078

Raw results

Slower ⚠️ in #6078

Raw results

andrewlock commented Sep 25, 2024 • edited Loading

Throughput/Crank Report ⚡

dudikeleti commented Sep 25, 2024 •

edited

Loading

datadog-ddstaging bot commented Sep 25, 2024 •

edited

Loading

andrewlock commented Sep 25, 2024 •

edited

Loading

andrewlock commented Sep 25, 2024 •

edited

Loading

andrewlock commented Sep 25, 2024 •

edited

Loading