Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamic Instrumentation] DEBUG-2842 Snapshot exploration test #6064

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Dynamic Instrumentation] DEBUG-2842 Snapshot exploration test #6064

wants to merge 1 commit into from
+816 −93

Conversation

dudikeleti
Copy link
Contributor

@dudikeleti dudikeleti commented Sep 23, 2024 •
edited
Loading

Summary of changes

This PR expand the curent exploration test functionality to test not only the produced bytcode but also the snapshot of a probe.

Reason for change

In many cases the instrumentation itself is valid but still we fail to create a valid snapshot for a certain probe.

Implementation details

We run open source projects tests and put probe on each method, then validate the produced snapshot.

Test coverage

Exploration tests

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Sep 23, 2024 •
edited
Loading

Datadog Report

Branch report: dudik/explorationtests-snapshots
Commit report: 61f004f
Test service: dd-trace-dotnet

❌ 25 Failed (0 Known Flaky), 295687 Passed, 2645 Skipped, 25h 33m 1.41s Total Time

❌ Failed Tests (25)

This report shows up to 5 failed tests.

  • AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

    Expand for error 
     Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found {"DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_ENABLED", "DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_PROBES_PATH", "DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_REPORT_PATH"}.

  • AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

    Expand for error 
     Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found {"DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_ENABLED", "DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_PROBES_PATH", "DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_REPORT_PATH"}.

  • AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

    Expand for error 
     Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found {"DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_ENABLED", "DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_PROBES_PATH", "DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_REPORT_PATH"}.

  • AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

    Expand for error 
     Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found {"DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_ENABLED", "DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_PROBES_PATH", "DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_REPORT_PATH"}.

  • AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

    Expand for error 
     Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found {"DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_ENABLED", "DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_PROBES_PATH", "DD_INTERNAL_SNAPSHOT_EXPLORATION_TEST_REPORT_PATH"}.

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6064) - mean (69ms)  : 67, 72
     .   : milestone, 69,
    master - mean (69ms)  : 67, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6064) - mean (1,099ms)  : 1075, 1122
     .   : milestone, 1099,
    master - mean (1,097ms)  : 1072, 1123
     .   : milestone, 1097,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6064) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6064) - mean (766ms)  : 751, 782
     .   : milestone, 766,
    master - mean (822ms)  : 610, 1034
     .   : milestone, 822,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6064) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6064) - mean (721ms)  : 703, 739
     .   : milestone, 721,
    master - mean (725ms)  : 708, 741
     .   : milestone, 725,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6064) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6064) - mean (1,195ms)  : 1170, 1221
     .   : milestone, 1195,
    master - mean (1,196ms)  : 1171, 1221
     .   : milestone, 1196,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6064) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6064) - mean (936ms)  : 921, 952
     .   : milestone, 936,
    master - mean (940ms)  : 899, 981
     .   : milestone, 940,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6064) - mean (264ms)  : 261, 268
     .   : milestone, 264,
    master - mean (264ms)  : 261, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6064) - mean (922ms)  : 904, 940
     .   : milestone, 922,
    master - mean (929ms)  : 910, 949
     .   : milestone, 929,
Loading

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6064) (11.230M)   : 0, 11230192
    master (11.235M)   : 0, 11235244
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6064) (7.421M)   : 0, 7420891
    master (7.260M)   : 0, 7260359
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.725M)   : 0, 7725315

    section Manual
    master (11.120M)   : 0, 11119606

    section Manual + Automatic
    This PR (6064) (6.721M)   : 0, 6721438
    master (6.846M)   : 0, 6846201

    section DD_TRACE_ENABLED=0
    master (10.137M)   : 0, 10137375
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6064) (9.609M)   : 0, 9609199
    master (9.648M)   : 0, 9648079
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6064) (6.547M)   : 0, 6547076
    master (6.505M)   : 0, 6504554

    section Trace stats
    master (6.807M)   : 0, 6806517

    section Manual
    master (9.546M)   : 0, 9545759

    section Manual + Automatic
    This PR (6064) (6.092M)   : 0, 6091506
    master (6.099M)   : 0, 6098624

    section DD_TRACE_ENABLED=0
    master (8.912M)   : 0, 8911685
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6064) (10.175M)   : 0, 10175434
    master (10.077M)   : 0, 10076741
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6064) (6.718M)   : 0, 6717569
    master (6.720M)   : 0, 6720262
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.303M)   : 0, 7302590

    section Manual
    master (10.135M)   : 0, 10134645

    section Manual + Automatic
    This PR (6064) (6.215M)   : 0, 6215155
    master (6.450M)   : 0, 6449516

    section DD_TRACE_ENABLED=0
    master (9.437M)   : 0, 9437460
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6064 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.169
  • 1 benchmarks are slower, with geometric mean 1.177
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.51μs 42.2ns 299ns 0.0181 0.0108 0.00362 5.42 KB
master StartStopWithChild netcoreapp3.1 10.4μs 66.3ns 629ns 0.0155 0.00516 0 5.62 KB
master StartStopWithChild net472 16.1μs 41.8ns 162ns 1.02 0.307 0.102 6.06 KB
#6064 StartStopWithChild net6.0 7.78μs 43.7ns 287ns 0.0159 0.00397 0 5.43 KB
#6064 StartStopWithChild netcoreapp3.1 10.2μs 57.2ns 375ns 0.0244 0.00976 0 5.62 KB
#6064 StartStopWithChild net472 15.9μs 51.3ns 192ns 1.02 0.31 0.0931 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 465μs 324ns 1.25μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 625μs 536ns 2.08μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 837μs 328ns 1.18μs 0.417 0 0 3.3 KB
#6064 WriteAndFlushEnrichedTraces net6.0 468μs 286ns 991ns 0 0 0 2.7 KB
#6064 WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 534ns 2.07μs 0 0 0 2.7 KB
#6064 WriteAndFlushEnrichedTraces net472 842μs 503ns 1.95μs 0.414 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 214μs 1.24μs 10.7μs 0.156 0 0 18.45 KB
master SendRequest netcoreapp3.1 234μs 1.26μs 7.79μs 0.242 0 0 20.61 KB
master SendRequest net472 0.00148ns 0.0005ns 0.0018ns 0 0 0 0 b
#6064 SendRequest net6.0 226μs 1.31μs 10.8μs 0.213 0 0 18.45 KB
#6064 SendRequest netcoreapp3.1 239μs 1.33μs 9.13μs 0.251 0 0 20.61 KB
#6064 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 577μs 2.09μs 7.55μs 0.581 0 0 41.65 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 685μs 3.07μs 11.9μs 0.34 0 0 41.77 KB
master WriteAndFlushEnrichedTraces net472 875μs 4.08μs 15.8μs 8.87 2.53 0.422 53.34 KB
#6064 WriteAndFlushEnrichedTraces net6.0 609μs 3.28μs 17μs 0.59 0 0 41.76 KB
#6064 WriteAndFlushEnrichedTraces netcoreapp3.1 698μs 3.94μs 29.2μs 0.351 0 0 41.67 KB
#6064 WriteAndFlushEnrichedTraces net472 882μs 3.45μs 12.9μs 8.25 2.6 0.434 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.24μs 1.2ns 4.66ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.76μs 1.45ns 5.63ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.06μs 2.63ns 10.2ns 0.157 0 0 987 B
#6064 ExecuteNonQuery net6.0 1.35μs 1.17ns 4.53ns 0.0142 0 0 1.02 KB
#6064 ExecuteNonQuery netcoreapp3.1 1.76μs 1.38ns 5.33ns 0.0132 0 0 1.02 KB
#6064 ExecuteNonQuery net472 2.12μs 2.01ns 7.77ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.25μs 1.34ns 5.2ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.59μs 0.551ns 2.06ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.64μs 4.45ns 17.2ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.16μs 0.5ns 1.87ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.61μs 0.936ns 3.5ns 0.0137 0 0 1.02 KB
master CallElasticsearchAsync net472 2.62μs 3.07ns 11.9ns 0.166 0 0 1.05 KB
#6064 CallElasticsearch net6.0 1.22μs 0.4ns 1.39ns 0.0135 0 0 976 B
#6064 CallElasticsearch netcoreapp3.1 1.52μs 0.524ns 1.96ns 0.0131 0 0 976 B
#6064 CallElasticsearch net472 2.45μs 0.804ns 3.01ns 0.158 0 0 995 B
#6064 CallElasticsearchAsync net6.0 1.23μs 0.798ns 2.99ns 0.0134 0 0 952 B
#6064 CallElasticsearchAsync netcoreapp3.1 1.67μs 0.834ns 3.23ns 0.0141 0 0 1.02 KB
#6064 CallElasticsearchAsync net472 2.76μs 2.68ns 10.4ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 0.45ns 1.74ns 0.0138 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 0.691ns 2.59ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.86μs 2.9ns 11.2ns 0.145 0 0 915 B
#6064 ExecuteAsync net6.0 1.26μs 0.414ns 1.49ns 0.0135 0 0 952 B
#6064 ExecuteAsync netcoreapp3.1 1.67μs 1.96ns 7.32ns 0.0125 0 0 952 B
#6064 ExecuteAsync net472 1.78μs 1.48ns 5.73ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.3μs 2.21ns 8.27ns 0.0301 0 0 2.22 KB
master SendAsync netcoreapp3.1 4.99μs 2.21ns 8.56ns 0.0375 0 0 2.76 KB
master SendAsync net472 7.76μs 2.54ns 9.84ns 0.498 0 0 3.15 KB
#6064 SendAsync net6.0 4.08μs 1.92ns 7.18ns 0.0307 0 0 2.22 KB
#6064 SendAsync netcoreapp3.1 5.07μs 1.28ns 4.61ns 0.0355 0 0 2.76 KB
#6064 SendAsync net472 7.74μs 1.66ns 6.45ns 0.5 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.6μs 0.787ns 3.05ns 0.0231 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.33μs 1.09ns 4.08ns 0.0223 0 0 1.64 KB
master EnrichedLog net472 2.61μs 4.98ns 19.3ns 0.249 0 0 1.57 KB
#6064 EnrichedLog net6.0 1.49μs 2.81ns 9.73ns 0.0227 0 0 1.64 KB
#6064 EnrichedLog netcoreapp3.1 2.16μs 1.43ns 5.55ns 0.0216 0 0 1.64 KB
#6064 EnrichedLog net472 2.5μs 0.562ns 1.95ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 287ns 1.11μs 0.0582 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 117μs 136ns 510ns 0.0596 0 0 4.28 KB
master EnrichedLog net472 147μs 121ns 467ns 0.659 0.22 0 4.46 KB
#6064 EnrichedLog net6.0 114μs 185ns 691ns 0.0565 0 0 4.28 KB
#6064 EnrichedLog netcoreapp3.1 118μs 295ns 1.06μs 0 0 0 4.28 KB
#6064 EnrichedLog net472 145μs 156ns 604ns 0.649 0.216 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.21μs 0.873ns 3.15ns 0.0304 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.18μs 2.45ns 9.5ns 0.0293 0 0 2.2 KB
master EnrichedLog net472 4.76μs 1.56ns 6.06ns 0.32 0 0 2.02 KB
#6064 EnrichedLog net6.0 3.22μs 4.19ns 16.2ns 0.0307 0 0 2.2 KB
#6064 EnrichedLog netcoreapp3.1 4.34μs 2.79ns 10.8ns 0.0282 0 0 2.2 KB
#6064 EnrichedLog net472 4.71μs 0.986ns 3.82ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.33μs 1.37ns 5.12ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.8μs 1.48ns 5.55ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.05μs 0.574ns 1.99ns 0.183 0 0 1.16 KB
#6064 SendReceive net6.0 1.45μs 0.631ns 2.44ns 0.0159 0 0 1.14 KB
#6064 SendReceive netcoreapp3.1 1.79μs 1.63ns 6.31ns 0.0152 0 0 1.14 KB
#6064 SendReceive net472 2.12μs 0.669ns 2.59ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.86μs 1.97ns 7.62ns 0.0213 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.95μs 1.01ns 3.91ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 4.3μs 1.5ns 5.62ns 0.323 0 0 2.04 KB
#6064 EnrichedLog net6.0 2.68μs 1.34ns 5.21ns 0.0225 0 0 1.6 KB
#6064 EnrichedLog netcoreapp3.1 3.86μs 2.36ns 9.15ns 0.0212 0 0 1.65 KB
#6064 EnrichedLog net472 4.27μs 2.03ns 7.87ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6064

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.214 738.16 607.82
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.125 536.40 476.60

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 399ns 0.0884ns 0.319ns 0.00799 0 0 576 B
master StartFinishSpan netcoreapp3.1 550ns 0.234ns 0.844ns 0.00778 0 0 576 B
master StartFinishSpan net472 738ns 0.441ns 1.71ns 0.0917 0 0 578 B
master StartFinishScope net6.0 536ns 0.171ns 0.663ns 0.00982 0 0 696 B
master StartFinishScope netcoreapp3.1 680ns 1.21ns 4.69ns 0.00936 0 0 696 B
master StartFinishScope net472 883ns 0.902ns 3.49ns 0.104 0 0 658 B
#6064 StartFinishSpan net6.0 405ns 0.13ns 0.502ns 0.00818 0 0 576 B
#6064 StartFinishSpan netcoreapp3.1 578ns 3.27ns 21.9ns 0.00765 0 0 576 B
#6064 StartFinishSpan net472 608ns 0.27ns 1.04ns 0.0916 0 0 578 B
#6064 StartFinishScope net6.0 477ns 0.187ns 0.726ns 0.00971 0 0 696 B
#6064 StartFinishScope netcoreapp3.1 721ns 0.482ns 1.87ns 0.00938 0 0 696 B
#6064 StartFinishScope net472 828ns 0.341ns 1.32ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6064

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.177 616.88 726.06

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 617ns 0.29ns 1.12ns 0.00996 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 936ns 0.367ns 1.37ns 0.00929 0 0 696 B
master RunOnMethodBegin net472 1.09μs 0.297ns 1.15ns 0.104 0 0 658 B
#6064 RunOnMethodBegin net6.0 726ns 0.533ns 2.07ns 0.00985 0 0 696 B
#6064 RunOnMethodBegin netcoreapp3.1 980ns 0.492ns 1.91ns 0.00926 0 0 696 B
#6064 RunOnMethodBegin net472 1.06μs 0.406ns 1.57ns 0.104 0 0 658 B

@dudikeleti dudikeleti marked this pull request as ready for review September 26, 2024 12:25
@dudikeleti dudikeleti requested review from a team as code owners September 26, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:debugger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dudikeleti @andrewlock