-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiled renderer improvements and fixes #1333
base: master
Are you sure you want to change the base?
Tiled renderer improvements and fixes #1333
Conversation
The non-UBO and non-integer texture code was supposed to be used when those extensions are not available, however: 1. These extnesions are available on nearly all hardware nowadays. These extensions became core in 3.1 as well. 2. Hardware that doesn't support those extensions porbably won't be using `r_realtimeighting on` anyway due to performance reasons. 3. These old code paths were broken.
I confirm that the alternative code for missing In my database of collected The glxinfo dumps for those cards are from 2020 so I may re-run them with latest mesa. Intel gma 3 misses them but is not able to compile the tiled renderer shaders to begin with. The gma 4 can probably compile them but I have no dump and it would probably be super slow to run dynamic lights (I'll have to restart the related computer to check). |
Yeah, both extensions seem to really be supported by the same set of hardware. |
9dad554
to
d136604
Compare
In the commit |
@@ -48,6 +48,16 @@ static void EnableAvailableFeatures() | |||
glConfig2.realtimeLighting = false; | |||
} | |||
|
|||
if ( !glConfig2.uniformBufferObjectAvailable ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These could be else-if's
r_realtimeighting on
anyway due to performance reasons.lightMapping_fp
. Some projectile shaders and such might need to be adjusted due to this.lighttile_fp
andcomputeLight_fp
.