More renderer debug logs #1331
Open
More renderer debug logs #1331
+25
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slipher
reviewed
Oct 2, 2024
| logger.WithoutSuppression().Notice( "...using GL_%s", name ); | ||
| if ( flags & ExtFlag_REQUIRED ) | ||
| { | ||
| logger.WithoutSuppression().Notice( "...using required core extension GL_%s.", name ); |
There was a problem hiding this comment.
The message is wrong, taking this branch doesn't mean it must be core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some renderer debug logs I needed to debug things:
When it is suspected an extension may be buggy, it is useful to know which ones are optional so one can disable them to verify the assumption.
When the OpenGL driver reports errors when creating or uploading an image, it's useful to have such debug logs to know exactly which image failed, just by reading the immediate previous line. It is useful to identify which image format may be broken in an OpenGL driver.