-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send client version to server #267
base: main
Are you sure you want to change the base?
feat: send client version to server #267
Conversation
natthan-pigoux
commented
Jun 27, 2024
- create a middleware to check that the client version pass in header is recent enough from what is defined in the entry_point
closes #258 |
|
a2aee1f
to
d2ab06f
Compare
@chaen find how to add properly the header in the client: |
Do I need to add more unit tests ? |
|
last commits add these tests: 92fac94 |
7450962
to
672df6a
Compare
2b47b6e
to
5b55e88
Compare
Please tell me when review is ok, so that I can squash the commits. |
Alright, you can squash the commits, it looks good 👍 |
- add an entry point for min client version - create a middleware to verify server/client version
963941f
to
1551b0c
Compare