Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(Gubbins): Extension workflow #218

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

ci(Gubbins): Extension workflow #218

wants to merge 7 commits into from

Conversation

Loxeris
Copy link
Member

@Loxeris Loxeris commented Aug 29, 2024

New CI/CD workflow for the Gubbins extension.

Runs next lint and e2e tests.

aldbr
aldbr requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@aldbr aldbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part looks good! However, we should also modify the deployment.yaml file such as:

  • every push to main triggers the deployment of a new gubbins image with the tag `dev
  • every new release triggers the deployment of a new gubbins image with the tag <version>

@aldbr aldbr mentioned this pull request Aug 29, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldbr aldbr aldbr requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Loxeris @aldbr