Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] IAM2CS: ForceNickname, fix duplicate accounts for users #7784

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

andresailer
Copy link
Contributor

@andresailer andresailer commented Sep 11, 2024

BEGINRELEASENOTES

*ConfigurationSystem
CHANGE: VOMS2CSAgent: if a nickname is set, this nickname will always be used and no new accounts are going to be created if a DN changes or a user is in multiple VOs
NEW: VOMS2CSAgent: New option "ForceNickname", if this option is enabled no dirac user is created if no nickname attribute is set for a user
CHANGE: IAMService: use logger and return errors for users so that the VOMS2CSAgent can notify admins about issues

ENDRELEASENOTES

When there are multiple VOs where a user is present and there are multiple Certificates multiple dirac accounts where created for that user.
Now the nickname is always used and no index is added with new users
@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Sep 11, 2024
@andresailer andresailer marked this pull request as ready for review September 13, 2024 14:25
@fstagni fstagni merged commit 3fc58a8 into DIRACGrid:rel-v8r0 Sep 17, 2024
26 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Sep 17, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/10902080612

Failed:

  • integration
    cherry-pick 3fc58a8 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-3fc58a8e9-integration
    git cherry-pick -x -m 1 3fc58a8e9
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7784 IAM2CS: ForceNickname, fix duplicate accounts for users' --author='Andre Sailer <[email protected]>'
    git push -u origin cherry-pick-2-3fc58a8e9-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] IAM2CS: ForceNickname, fix duplicate accounts for users' \
         --body 'Sweep #7784 `IAM2CS: ForceNickname, fix duplicate accounts for users` to `integration`.
    
    Adding original author @andresailer as watcher.
    
    BEGINRELEASENOTES
    
    *ConfigurationSystem
    CHANGE: VOMS2CSAgent: if a nickname is set, this nickname will always be used and no new accounts are going to be created if a DN changes or a user is in multiple VOs
    NEW: VOMS2CSAgent: New option "ForceNickname", if this option is enabled no dirac user is created if no nickname attribute is set for a user
    CHANGE: IAMService: use logger and return errors for users so that the VOMS2CSAgent can notify admins about issues
    
    ENDRELEASENOTES
    Closes #7795'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants