Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Change the updating logic of the TS FileStatus #7741

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

chaen
Copy link
Contributor

@chaen chaen commented Jul 31, 2024

This aims at solving #7116
It is quite a big change of logic, but should not impact anybody but LHCb, as it mostly matters for complex body plugin

Also, it speeds up a lot the RequestTaskAgent.
Hotfixed in LHCb, we observe a huge speedup on a transformation with 4M files:

# Before
2024-08-13 05:24:33 UTC Transformation/RequestTaskAgent/[231355] ._execute INFO: Processed transformation in 2134.9 seconds

# After
2024-08-13 09:29:19 UTC Transformation/RequestTaskAgent/[231355] ._execute INFO: Processed transformation in 62.4 seconds

BEGINRELEASENOTES
*TS
FIX: RequestTaskAgent only considers requests in final states, and consider files in intermediate state as problematic (#7116)
NEW: RequestTaskAgent uses getBulkRequestStatus instead of getRequestStatus

RMS:
NEW: implement getRequestStatus

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Jul 31, 2024
@chaen chaen linked an issue Aug 13, 2024 that may be closed by this pull request
Copy link
Contributor

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions for my understanding.

Do you mean

Implement getBulkRequestStatus

In the release notes?

else:
badRequestID += 1
# We don't care updating the tasks to Assigned while the request is being processed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify this comment?

I don't understand what we "don't care" about here?

Or like:

Suggested change
# We don't care updating the tasks to Assigned while the request is being processed
# We do not update the tasks to Assigned while the request is being processed

But why? (what is the status while it is being processed?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Assigned for the RMS request, that is, it is currently bewing treated by the REA, so it is a very temporary status

src/DIRAC/TransformationSystem/Client/RequestTasks.py Outdated Show resolved Hide resolved
@chaen chaen force-pushed the v8.0_fix_TSFileStatus branch 2 times, most recently from d9c89d9 to 7af5cfc Compare August 16, 2024 12:18
@chaen chaen marked this pull request as ready for review September 16, 2024 21:33
fstagni
fstagni previously approved these changes Sep 23, 2024
@fstagni fstagni merged commit 8d7c3e6 into DIRACGrid:rel-v8r0 Sep 23, 2024
26 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Sep 23, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/10993993193

Failed:

  • integration
    cherry-pick 8d7c3e6 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-8d7c3e650-integration
    git cherry-pick -x -m 1 8d7c3e650
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7741 Change the updating logic of the TS FileStatus' --author='Christophe Haen <[email protected]>'
    git push -u origin cherry-pick-2-8d7c3e650-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] Change the updating logic of the TS FileStatus' \
         --body 'Sweep #7741 `Change the updating logic of the TS FileStatus` to `integration`.
    
    Adding original author @chaen as watcher.
    
    BEGINRELEASENOTES
    *TS
    FIX: RequestTaskAgent only considers requests in final states, and consider files in intermediate state as problematic (https://github.com/DIRACGrid/DIRAC/issues/7116)
    NEW: RequestTaskAgent uses getBulkRequestStatus instead of getRequestStatus
    
    RMS:
    NEW: implement getRequestStatus
    
    
    
    ENDRELEASENOTES
    Closes #7804'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files in transformations will stay assigned for ever
4 participants