-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] Drop the system instance level in the CS #7186
Open
atsareg
wants to merge
7
commits into
DIRACGrid:rel-v8r0
Choose a base branch
from
atsareg:drop-system-instances
base: rel-v8r0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
Cherry pick this PR to integration after merge
label
Sep 5, 2023
atsareg
removed
the
alsoTargeting:integration
Cherry pick this PR to integration after merge
label
Sep 13, 2024
atsareg
force-pushed
the
drop-system-instances
branch
from
September 13, 2024 11:53
d23e35d
to
ad15178
Compare
DIRACGridBot
added
the
alsoTargeting:integration
Cherry pick this PR to integration after merge
label
Sep 13, 2024
atsareg
removed
the
alsoTargeting:integration
Cherry pick this PR to integration after merge
label
Sep 13, 2024
DIRACGridBot
added
the
alsoTargeting:integration
Cherry pick this PR to integration after merge
label
Sep 13, 2024
atsareg
removed
the
alsoTargeting:integration
Cherry pick this PR to integration after merge
label
Sep 13, 2024
4 tasks
So, IIUC:
At a minimum we need some instructions, to be added to the v9 wiki. A script that does the CS update would be better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to drop the System instance section level from the CS. The presence of the /DIRAC/NoSetup=True option in the CS suggests that the configuration is defined without Setups (to be introduced in 9.0 #7671). This forces the system section not to contain the instance level in the output of getSystemSection() and similar cases. This way it should be compatible with CS both with and without Setups defined.
BEGINRELEASENOTES
*Configuration
CHANGE: PathFinder.getSystemInstance() returns empty string if Setups are dropped from the CS
*WorkloadManagement
CHANGE: StalledJobAgent, Watchdog - use getSystemSection() instead of getSystemInstance()
ENDRELEASENOTES