Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate scripts widgets constant to use getter/setter style #1313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate scripts widgets constant to use getter/setter style #1313

wants to merge 1 commit into from

Conversation

wiktor-obrebski
Copy link
Contributor

Pair PR: DFHack/dfhack#4972

Continuation of DFHack/dfhack#4955, its answer for the comment:
DFHack/dfhack#4955 (comment)

Shortly, its migrate widgets constants to use getter/setter style.

@wiktor-obrebski wiktor-obrebski marked this pull request as ready for review October 1, 2024 16:49
@wiktor-obrebski wiktor-obrebski mentioned this pull request Oct 1, 2024
Open
myk002
myk002 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending merge of DFHack/dfhack#4972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myk002 myk002 myk002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
50.14-r2
Status: Review In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktor-obrebski @myk002